Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Side by Side Diff: Source/bindings/core/v8/CallbackPromiseAdapter.h

Issue 1221693004: (WONT COMMIT) Pass a bool object allocated on heap to CallbackPromiseAdapter::onSuccess (4) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@cbadapter2
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 18 matching lines...) Expand all
29 */ 29 */
30 30
31 #ifndef CallbackPromiseAdapter_h 31 #ifndef CallbackPromiseAdapter_h
32 #define CallbackPromiseAdapter_h 32 #define CallbackPromiseAdapter_h
33 33
34 #include "bindings/core/v8/ScriptPromiseResolver.h" 34 #include "bindings/core/v8/ScriptPromiseResolver.h"
35 #include "public/platform/WebCallbacks.h" 35 #include "public/platform/WebCallbacks.h"
36 36
37 namespace blink { 37 namespace blink {
38 38
39 // TODO(nhiroki): Remove ifdef hack after Chromium-side patch is landed.
40 // http://crbug.com/493531
41 #define CRBUG_493531
42
43 // This class provides an easy way to convert from a Script-exposed 39 // This class provides an easy way to convert from a Script-exposed
44 // class (i.e. a class that has a toV8() overload) that uses Promises 40 // class (i.e. a class that has a toV8() overload) that uses Promises
45 // to a WebKit API class that uses WebCallbacks. You can define 41 // to a WebKit API class that uses WebCallbacks. You can define
46 // separate Success and Error classes, but this example just uses one 42 // separate Success and Error classes, but this example just uses one
47 // object for both. 43 // object for both.
48 // 44 //
49 // To use: 45 // To use:
50 // 46 //
51 // class MyClass ... { 47 // class MyClass ... {
52 // typedef blink::WebMyClass WebType; 48 // typedef blink::WebMyClass WebType;
(...skipping 211 matching lines...) Expand 10 before | Expand all | Expand 10 after
264 m_resolver->reject(); 260 m_resolver->reject();
265 } 261 }
266 262
267 private: 263 private:
268 RefPtrWillBePersistent<ScriptPromiseResolver> m_resolver; 264 RefPtrWillBePersistent<ScriptPromiseResolver> m_resolver;
269 }; 265 };
270 266
271 } // namespace blink 267 } // namespace blink
272 268
273 #endif 269 #endif
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698