Chromium Code Reviews

Unified Diff: chrome/android/java/res/layout/custom_tabs_toolbar.xml

Issue 1221693002: Fix accessibility issues in custom tab UI (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Index: chrome/android/java/res/layout/custom_tabs_toolbar.xml
diff --git a/chrome/android/java/res/layout/custom_tabs_toolbar.xml b/chrome/android/java/res/layout/custom_tabs_toolbar.xml
index 5f117bee6a98987d42780a2958cc2f20215775fe..43ed0a1655149b52d1b74aa615143b04436b3697 100644
--- a/chrome/android/java/res/layout/custom_tabs_toolbar.xml
+++ b/chrome/android/java/res/layout/custom_tabs_toolbar.xml
@@ -8,7 +8,8 @@
android:id="@+id/back_button"
style="@style/ToolbarButton"
android:layout_gravity="center_vertical"
- android:src="@drawable/btn_chevron_left" />
+ android:src="@drawable/btn_chevron_left"
+ android:contentDescription="@string/accessibility_toolbar_btn_back" />
Yusuf 2015/06/29 18:03:17 is this the string we want to have? Or we need a n
Ian Wen 2015/06/29 18:27:42 This string only says "Go back". Do you want me to
Yusuf 2015/06/29 18:30:07 Yes, lets add a new one and say "Close webpage"
Ian Wen 2015/06/30 18:31:23 Done.
<ImageButton android:id="@+id/security_button"
style="@style/LocationBarButton"
android:layout_width="@dimen/location_bar_icon_width"

Powered by Google App Engine