Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1715)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java

Issue 1221693002: Fix accessibility issues in custom tab UI (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java
index 078f52aa3998ac50a70e74dae51363daef40d82d..f04a17f1a1d99ed23f350664c8436dc543949794 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java
@@ -54,7 +54,8 @@ import org.chromium.ui.base.WindowAndroid;
/**
* The Toolbar layout to be used for a custom tab. This is used for both phone and tablet UIs.
*/
-public class CustomTabToolbar extends ToolbarLayout implements LocationBar {
+public class CustomTabToolbar extends ToolbarLayout implements LocationBar,
+ View.OnLongClickListener {
private View mUrlInfoContainer;
private UrlBar mUrlBar;
private TextView mTitleBar;
@@ -90,6 +91,9 @@ public class CustomTabToolbar extends ToolbarLayout implements LocationBar {
mSecurityButtonShowAnimator = ObjectAnimator.ofFloat(mSecurityButton, ALPHA, 1);
mSecurityButtonShowAnimator
.setDuration(ToolbarPhone.URL_FOCUS_CHANGE_ANIMATION_DURATION_MS);
+
+ mReturnButton.setOnLongClickListener(this);
+ mCustomActionButton.setOnLongClickListener(this);
}
@Override
@@ -450,6 +454,17 @@ public class CustomTabToolbar extends ToolbarLayout implements LocationBar {
super.onLayout(changed, left, top, right, bottom);
}
+ @Override
+ public boolean onLongClick(View v) {
+ int stringResourceId = 0;
+ if (v == mReturnButton) {
+ stringResourceId = R.string.accessibility_toolbar_btn_back;
+ } else if (v == mCustomActionButton) {
+ stringResourceId = R.string.accessibility_toolbar_btn_custom;
+ }
Yusuf 2015/06/29 18:03:17 else { return false; } here since we may actually
Ian Wen 2015/06/29 18:27:42 Done.
+ return showLongPressToast(v, stringResourceId);
+ }
+
// Toolbar and LocationBar calls that are not relevant here.
@Override

Powered by Google App Engine
This is Rietveld 408576698