Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Side by Side Diff: chrome/android/java/res/layout/custom_tabs_toolbar.xml

Issue 1221693002: Fix accessibility issues in custom tab UI (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <?xml version="1.0" encoding="utf-8"?> 1 <?xml version="1.0" encoding="utf-8"?>
2 <!-- Copyright 2015 The Chromium Authors. All rights reserved. 2 <!-- Copyright 2015 The Chromium Authors. All rights reserved.
3 Use of this source code is governed by a BSD-style license that can be 3 Use of this source code is governed by a BSD-style license that can be
4 found in the LICENSE file. --> 4 found in the LICENSE file. -->
5 5
6 <org.chromium.chrome.browser.toolbar.CustomTabToolbar xmlns:android="http://sche mas.android.com/apk/res/android"> 6 <org.chromium.chrome.browser.toolbar.CustomTabToolbar xmlns:android="http://sche mas.android.com/apk/res/android">
7 <org.chromium.chrome.browser.widget.TintedImageButton 7 <org.chromium.chrome.browser.widget.TintedImageButton
8 android:id="@+id/back_button" 8 android:id="@+id/back_button"
9 style="@style/ToolbarButton" 9 style="@style/ToolbarButton"
10 android:layout_gravity="center_vertical" 10 android:layout_gravity="center_vertical"
11 android:src="@drawable/btn_chevron_left" /> 11 android:src="@drawable/btn_chevron_left"
12 android:contentDescription="@string/accessibility_toolbar_btn_back" />
Yusuf 2015/06/29 18:03:17 is this the string we want to have? Or we need a n
Ian Wen 2015/06/29 18:27:42 This string only says "Go back". Do you want me to
Yusuf 2015/06/29 18:30:07 Yes, lets add a new one and say "Close webpage"
Ian Wen 2015/06/30 18:31:23 Done.
12 <ImageButton android:id="@+id/security_button" 13 <ImageButton android:id="@+id/security_button"
13 style="@style/LocationBarButton" 14 style="@style/LocationBarButton"
14 android:layout_width="@dimen/location_bar_icon_width" 15 android:layout_width="@dimen/location_bar_icon_width"
15 android:layout_height="match_parent" 16 android:layout_height="match_parent"
16 android:layout_marginStart="48dp" 17 android:layout_marginStart="48dp"
17 android:scaleType="center" 18 android:scaleType="center"
18 android:layout_gravity="center_vertical" 19 android:layout_gravity="center_vertical"
19 android:alpha="0" 20 android:alpha="0"
20 android:visibility="gone" 21 android:visibility="gone"
21 android:contentDescription="@string/accessibility_toolbar_btn_site_info" /> 22 android:contentDescription="@string/accessibility_toolbar_btn_site_info" />
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
70 android:contentDescription="@string/accessibility_toolbar_btn_menu" 71 android:contentDescription="@string/accessibility_toolbar_btn_menu"
71 android:background="@null" /> 72 android:background="@null" />
72 <org.chromium.chrome.browser.widget.ToolbarProgressBar 73 <org.chromium.chrome.browser.widget.ToolbarProgressBar
73 android:id="@+id/progress" 74 android:id="@+id/progress"
74 style="@style/Widget.AppCompat.ProgressBar.Horizontal" 75 style="@style/Widget.AppCompat.ProgressBar.Horizontal"
75 android:progressDrawable="@drawable/progress_bar" 76 android:progressDrawable="@drawable/progress_bar"
76 android:layout_width="match_parent" 77 android:layout_width="match_parent"
77 android:layout_height="2dp" 78 android:layout_height="2dp"
78 android:progress="0" /> 79 android:progress="0" />
79 </org.chromium.chrome.browser.toolbar.CustomTabToolbar> 80 </org.chromium.chrome.browser.toolbar.CustomTabToolbar>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698