src/IceInstX86Base.h - Issue 1221643012: Subzero: Add -Wshadow to the build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceInstX86Base.h

Issue 1221643012: Subzero: Add -Wshadow to the build. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Code review changes Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/IceInstX86Base.h

diff --git a/src/IceInstX86Base.h b/src/IceInstX86Base.h

index 7275e44995924f993966728148c620dc3594e90c..9ea6f4ad6d3c64838602601a7e0569ab14a48d7d 100644

--- a/src/IceInstX86Base.h

+++ b/src/IceInstX86Base.h

@@ -2053,8 +2053,8 @@ protected:

InstX86BaseLockable(Cfg *Func,

typename InstX86Base<Machine>::InstKindX86 Kind,

- SizeT Maxsrcs, Variable *Dest, bool Locked)

- : InstX86Base<Machine>(Func, Kind, Maxsrcs, Dest), Locked(Locked) {

+ SizeT Maxsrcs, Variable *Dest, bool MyLocked)

+ : InstX86Base<Machine>(Func, Kind, Maxsrcs, Dest), Locked(MyLocked) {

// Assume that such instructions are used for Atomics and be careful

// with optimizations.

this->HasSideEffects = Locked;