Subzero: Add -Wshadow to the build.

src/IceInst.h

Index: src/IceInst.h
diff --git a/src/IceInst.h b/src/IceInst.h
index cfa6dd3a48a0ba26d10ec5f87c7d5ef1f487a634..74a540bbab68ea6b7325b10862fa80c569033774 100644
--- a/src/IceInst.h
+++ b/src/IceInst.h
@@ -395,8 +395,9 @@ public:
 
 protected:
   InstCall(Cfg *Func, SizeT NumArgs, Variable *Dest, Operand *CallTarget,
-           bool HasTailCall, bool HasSideEff, InstKind Kind)
-      : InstHighLevel(Func, Kind, NumArgs + 1, Dest), HasTailCall(HasTailCall) {
+           bool MyHasTailCall, bool HasSideEff, InstKind Kind)

[jvoung (off chromium), 2015/07/14 01:25:19]

I suppose HasSideEff can be MyHasSideEffects (it was working around the
shadowing from the base class).

+      : InstHighLevel(Func, Kind, NumArgs + 1, Dest),
+        HasTailCall(MyHasTailCall) {
     HasSideEffects = HasSideEff;
     addSource(CallTarget);
   }
@@ -566,10 +567,11 @@ public:
 
 private:
   InstIntrinsicCall(Cfg *Func, SizeT NumArgs, Variable *Dest,
-                    Operand *CallTarget, const Intrinsics::IntrinsicInfo &Info)
-      : InstCall(Func, NumArgs, Dest, CallTarget, false, Info.HasSideEffects,
+                    Operand *CallTarget,
+                    const Intrinsics::IntrinsicInfo &MyInfo)
+      : InstCall(Func, NumArgs, Dest, CallTarget, false, MyInfo.HasSideEffects,
                  Inst::IntrinsicCall),
-        Info(Info) {}
+        Info(MyInfo) {}
 
   const Intrinsics::IntrinsicInfo Info;
 };