Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Side by Side Diff: src/IceInstX86Base.h

Issue 1221643012: Subzero: Add -Wshadow to the build. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Code review changes Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 //===- subzero/src/IceInstX86Base.h - Generic x86 instructions -*- C++ -*--===// 1 //===- subzero/src/IceInstX86Base.h - Generic x86 instructions -*- C++ -*--===//
2 // 2 //
3 // The Subzero Code Generator 3 // The Subzero Code Generator
4 // 4 //
5 // This file is distributed under the University of Illinois Open Source 5 // This file is distributed under the University of Illinois Open Source
6 // License. See LICENSE.TXT for details. 6 // License. See LICENSE.TXT for details.
7 // 7 //
8 //===----------------------------------------------------------------------===// 8 //===----------------------------------------------------------------------===//
9 /// 9 ///
10 /// \file 10 /// \file
(...skipping 2035 matching lines...) Expand 10 before | Expand all | Expand 10 after
2046 class InstX86BaseLockable : public InstX86Base<Machine> { 2046 class InstX86BaseLockable : public InstX86Base<Machine> {
2047 InstX86BaseLockable() = delete; 2047 InstX86BaseLockable() = delete;
2048 InstX86BaseLockable(const InstX86BaseLockable &) = delete; 2048 InstX86BaseLockable(const InstX86BaseLockable &) = delete;
2049 InstX86BaseLockable &operator=(const InstX86BaseLockable &) = delete; 2049 InstX86BaseLockable &operator=(const InstX86BaseLockable &) = delete;
2050 2050
2051 protected: 2051 protected:
2052 bool Locked; 2052 bool Locked;
2053 2053
2054 InstX86BaseLockable(Cfg *Func, 2054 InstX86BaseLockable(Cfg *Func,
2055 typename InstX86Base<Machine>::InstKindX86 Kind, 2055 typename InstX86Base<Machine>::InstKindX86 Kind,
2056 SizeT Maxsrcs, Variable *Dest, bool Locked) 2056 SizeT Maxsrcs, Variable *Dest, bool MyLocked)
2057 : InstX86Base<Machine>(Func, Kind, Maxsrcs, Dest), Locked(Locked) { 2057 : InstX86Base<Machine>(Func, Kind, Maxsrcs, Dest), Locked(MyLocked) {
2058 // Assume that such instructions are used for Atomics and be careful 2058 // Assume that such instructions are used for Atomics and be careful
2059 // with optimizations. 2059 // with optimizations.
2060 this->HasSideEffects = Locked; 2060 this->HasSideEffects = Locked;
2061 } 2061 }
2062 }; 2062 };
2063 2063
2064 /// Mul instruction - unsigned multiply. 2064 /// Mul instruction - unsigned multiply.
2065 template <class Machine> class InstX86Mul final : public InstX86Base<Machine> { 2065 template <class Machine> class InstX86Mul final : public InstX86Base<Machine> {
2066 InstX86Mul() = delete; 2066 InstX86Mul() = delete;
2067 InstX86Mul(const InstX86Mul &) = delete; 2067 InstX86Mul(const InstX86Mul &) = delete;
(...skipping 1071 matching lines...) Expand 10 before | Expand all | Expand 10 after
3139 &InstX86Base<Machine>::Traits::Assembler::psrl}; \ 3139 &InstX86Base<Machine>::Traits::Assembler::psrl}; \
3140 } \ 3140 } \
3141 } 3141 }
3142 3142
3143 } // end of namespace X86Internal 3143 } // end of namespace X86Internal
3144 } // end of namespace Ice 3144 } // end of namespace Ice
3145 3145
3146 #include "IceInstX86BaseImpl.h" 3146 #include "IceInstX86BaseImpl.h"
3147 3147
3148 #endif // SUBZERO_SRC_ICEINSTX86BASE_H 3148 #endif // SUBZERO_SRC_ICEINSTX86BASE_H
OLDNEW
« src/IceInst.h ('K') | « src/IceInstX8632.cpp ('k') | src/IceInstX86BaseImpl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698