Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Issue 1216013005: Fixed all overloaded virtual methods on Windows. (Closed)

Created:
5 years, 5 months ago by Matt Giuca
Modified:
5 years, 5 months ago
CC:
chromium-reviews, grt+watch_chromium.org, wfh+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixed all overloaded virtual methods on Windows. This fixes the 'overloaded-virtual' Clang warning on Windows (currently disabled; will be enabled in a follow-up CL). - PpapiThread::PreCacheFont: Renamed to PreCacheFontForFlash to avoid conflict with PreCacheFont method in base class ChildThreadImpl. (This method is only called by another method called PreCacheFontForFlash so the new name is appropriate.) - PrintingContextSytemDialogWin::InitializeSettings: Renamed to InitializeSettingsWithRanges to avoid conflict with InitializeSettings in base class PrintingContextWin. (These two methods are called on different code paths and the former is not meant to override the latter, so they should have different names.) - Removed PrintingContextWin::ShowPrintDialog. This method was totally unused and its name was conflicting with a method in a subclass. BUG=505301 Committed: https://crrev.com/8ca5918882daa6ab1be0c50825af47fe9a896b23 Cr-Commit-Position: refs/heads/master@{#337735}

Patch Set 1 #

Patch Set 2 : Rebase (grt already fixed the install_worker_unittest problem). #

Patch Set 3 : Finish fixes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -54 lines) Patch
M content/ppapi_plugin/ppapi_thread.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/ppapi_plugin/ppapi_thread.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ppapi/nacl_irt/ppapi_dispatcher.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ppapi/nacl_irt/ppapi_dispatcher.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/plugin_globals.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/plugin_proxy_delegate.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/ppapi_proxy_test.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/ppapi_proxy_test.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M printing/printing_context_system_dialog_win.h View 1 2 1 chunk +5 lines, -5 lines 0 comments Download
M printing/printing_context_system_dialog_win.cc View 1 2 3 chunks +6 lines, -7 lines 0 comments Download
M printing/printing_context_win.h View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M printing/printing_context_win.cc View 1 2 1 chunk +0 lines, -29 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (4 generated)
Matt Giuca
vitalybuka@chromium.org: Please review changes in printing/*. brettw@chromium.org: Please review changes in content/ppapi_plugin/* and ppapi/*. See ...
5 years, 5 months ago (2015-07-07 04:42:43 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1216013005/40001
5 years, 5 months ago (2015-07-07 04:43:22 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-07 05:29:48 UTC) #6
brettw
lgtm
5 years, 5 months ago (2015-07-07 22:26:16 UTC) #7
Vitaly Buka (NO REVIEWS)
lgtm
5 years, 5 months ago (2015-07-07 22:33:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1216013005/40001
5 years, 5 months ago (2015-07-08 01:57:37 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 5 months ago (2015-07-08 02:10:36 UTC) #11
commit-bot: I haz the power
5 years, 5 months ago (2015-07-08 02:12:27 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8ca5918882daa6ab1be0c50825af47fe9a896b23
Cr-Commit-Position: refs/heads/master@{#337735}

Powered by Google App Engine
This is Rietveld 408576698