DescriptionFixed all overloaded virtual methods on Windows.
This fixes the 'overloaded-virtual' Clang warning on Windows (currently
disabled; will be enabled in a follow-up CL).
- PpapiThread::PreCacheFont: Renamed to PreCacheFontForFlash to avoid
conflict with PreCacheFont method in base class ChildThreadImpl. (This
method is only called by another method called PreCacheFontForFlash so
the new name is appropriate.)
- PrintingContextSytemDialogWin::InitializeSettings: Renamed to
InitializeSettingsWithRanges to avoid conflict with InitializeSettings
in base class PrintingContextWin. (These two methods are called on
different code paths and the former is not meant to override the
latter, so they should have different names.)
- Removed PrintingContextWin::ShowPrintDialog. This method was totally
unused and its name was conflicting with a method in a subclass.
BUG=505301
Committed: https://crrev.com/8ca5918882daa6ab1be0c50825af47fe9a896b23
Cr-Commit-Position: refs/heads/master@{#337735}
Patch Set 1 #Patch Set 2 : Rebase (grt already fixed the install_worker_unittest problem). #Patch Set 3 : Finish fixes. #
Dependent Patchsets: Messages
Total messages: 12 (4 generated)
|