Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1009)

Unified Diff: build/common.gypi

Issue 1221333010: Removed -Wno-overloaded-virtual warning suppression. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@wno-overloaded-virtual-fixes
Patch Set: Update comment to refer to this bug. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index e4433e6b5de692ca551bac596e69b44d3170cd4f..adf556336ea2609951fb34043f568cb97cad82f3 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -3087,6 +3087,13 @@
'variables': { 'clang_warning_flags': ['-Wexit-time-destructors']},
}],
['chromium_code==0', {
+ 'variables': {
+ 'clang_warning_flags': [
+ # TODO(mgiuca): Move this suppression into individual third-party
+ # libraries as required. http://crbug.com/505301.
+ '-Wno-overloaded-virtual',
+ ],
+ },
'conditions': [
[ 'os_posix==1 and OS!="mac" and OS!="ios"', {
# We don't want to get warnings from third-party code,
@@ -5707,7 +5714,6 @@
'-Wno-microsoft', # http://crbug.com/505296
'-Wno-missing-braces', # http://crbug.com/505297
'-Wno-msvc-include', # http://crbug.com/505299
- '-Wno-overloaded-virtual', # http://crbug.com/505301
'-Wno-pointer-sign', # http://crbug.com/505303
'-Wno-reorder', # http://crbug.com/505304
'-Wno-switch', # http://crbug.com/505308
« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698