Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Issue 12212048: Linux/ChromeOS Chromium style checker cleanup, chrome/browser edition. (Closed)

Created:
7 years, 10 months ago by Ryan Sleevi
Modified:
7 years, 10 months ago
Reviewers:
Nico
CC:
chromium-reviews, MAD, tburkard+watch_chromium.org, tzik+watch_chromium.org, rpetterson, ahutter, yoshiki+watch_chromium.org, gideonwald, dbeam+watch-autofill_chromium.org, sail+watch_chromium.org, Raman Kakilate, kinuko+watch, native-client-reviews_googlegroups.com, Ilya Sherman, markusheintz_, cbentzel+watch_chromium.org, melevin, vsevik, jar (doing other things), shishir+watch_chromium.org, benjhayden+dwatch_chromium.org, rouslan+watch_chromium.org, dyu1, apatrick_chromium, dominich, marja+watch_chromium.org, benquan, darin-cc_chromium.org, dhollowa+watch_chromium.org, groby+spellwatch_chromium.org, chromium-apps-reviews_chromium.org, tim (not reviewing), groby+watch_chromium.org, samarth+watch_chromium.org, gbillock+watch_chromium.org, browser-components-watch_chromium.org, rouslan+spellwatch_chromium.org, gavinp+prer_chromium.org, smckay+watch_chromium.org, Albert Bodenhamer, haitaol1, Jered, akalin, Raghu Simha, feature-media-reviews_chromium.org, tfarina, sreeram, yurys, Aaron Boodman, dominich+watch_chromium.org, eroman, David Black, Dane Wallinga, rdsmith+dwatch_chromium.org, estade+watch_chromium.org, James Su, mmenke, pfeldman
Visibility:
Public.

Description

Linux/ChromeOS Chromium style checker cleanup, chrome/browser edition. Automated clean up of style checker errors that were missed due to the plugin not being executed on implementation files. BUG=115047 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181164

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+527 lines, -466 lines) Patch
M chrome/browser/autocomplete/autocomplete_provider_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/autocomplete/history_contents_provider_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/history_quick_provider_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/autocomplete/shortcuts_provider_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/autofill/autocomplete_history_manager_unittest.cc View 1 chunk +4 lines, -1 line 2 comments Download
M chrome/browser/autofill/autofill_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autofill/autofill_metrics_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/background/background_contents_service_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/background/background_mode_manager_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_html_writer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_model_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser_keyevents_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browsing_data/browsing_data_remover_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/captive_portal/captive_portal_browsertest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/captive_portal/captive_portal_service_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/chrome_browser_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_browser_main_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_switches_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/component_updater/test/component_updater_service_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/content_settings/content_settings_default_provider.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/content_settings/content_settings_default_provider_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/content_settings/content_settings_pref_provider_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/content_settings/content_settings_rule_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/custom_handlers/protocol_handler_registry_browsertest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc View 6 chunks +16 lines, -14 lines 0 comments Download
M chrome/browser/devtools/devtools_file_helper.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M chrome/browser/devtools/devtools_sanity_browsertest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/diagnostics/diagnostics_main.cc View 2 chunks +10 lines, -8 lines 0 comments Download
M chrome/browser/diagnostics/diagnostics_model.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/diagnostics/diagnostics_model_unittest.cc View 3 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/diagnostics/recon_diagnostics.cc View 7 chunks +14 lines, -14 lines 0 comments Download
M chrome/browser/diagnostics/sqlite_diagnostics.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/download/download_browsertest.cc View 3 chunks +23 lines, -13 lines 0 comments Download
M chrome/browser/download/download_request_infobar_delegate_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/download/download_request_limiter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/save_page_browsertest.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/errorpage_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/external_extension_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/external_protocol/external_protocol_handler_unittest.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/fast_shutdown_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/favicon/favicon_handler_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/feedback/feedback_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/first_run/first_run.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/fullscreen_gtk.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/geolocation/chrome_geolocation_permission_context_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/geolocation/geolocation_browsertest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/geolocation/geolocation_infobar_queue_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/google/google_url_tracker_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gpu/chrome_gpu_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/expire_history_backend.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/history/expire_history_backend_unittest.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/history/history_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/history/history_unittest.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/history/in_memory_url_index_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/multipart_browsertest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/history/scored_history_match_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/shortcuts_backend_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/history/shortcuts_database_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/history/text_database_manager_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/history/text_database_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/thumbnail_database_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/history/top_sites.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/history/top_sites_unittest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/history/url_database_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/history/visit_database_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/history/visit_filter_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/importer/firefox_importer_unittest.cc View 8 chunks +17 lines, -15 lines 0 comments Download
M chrome/browser/importer/firefox_importer_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/infobars/infobars_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/instant/instant_loader.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/intents/native_services_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/intents/web_intents_registry.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/io_thread.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/jankometer.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/logging_chrome_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/chrome_webrtc_browsertest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/media_gallery/media_file_system_registry.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media_gallery/media_gallery_database_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/metrics/metrics_service.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/metrics/thread_watcher.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/metrics/thread_watcher_unittest.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/metrics/variations/resource_request_allowed_notifier_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/nacl_host/nacl_process_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/nacl_host/nacl_validation_cache_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/nacl_host/test/gdb_debug_stub_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/nacl_host/test/nacl_gdb_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/chrome_fraudulent_certificate_reporter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/chrome_net_log_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/net/connection_tester.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/net/connection_tester_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/net/pref_proxy_config_tracker_impl_unittest.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M chrome/browser/net/ssl_config_service_manager_pref.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/net/transport_security_persister_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/page_cycler/page_cycler_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/password_manager/password_store_x_unittest.cc View 4 chunks +28 lines, -20 lines 0 comments Download
M chrome/browser/performance_monitor/database_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/policy/config_dir_policy_loader_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/device_management_service_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/device_status_collector_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/proxy_policy_provider_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/predictors/autocomplete_action_predictor_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/predictors/resource_prefetch_predictor_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/predictors/resource_prefetcher_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/pref_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/scoped_user_pref_update_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prerender/prerender_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prerender/prerender_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/cloud_print/cloud_print_proxy_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc View 3 chunks +8 lines, -4 lines 0 comments Download
M chrome/browser/printing/print_dialog_cloud_interative_uitest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/printing/print_job_unittest.cc View 4 chunks +9 lines, -8 lines 0 comments Download
M chrome/browser/printing/print_preview_dialog_controller_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/process_singleton_browsertest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/process_singleton_linux.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/profiles/off_the_record_profile_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_dependency_manager_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/malware_details.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/malware_details_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_blocking_page.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_database.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc View 10 chunks +24 lines, -21 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/search_provider_install_data.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/template_url_fetcher.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/search_engines/template_url_parser_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/search_engines/template_url_service_test_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/service/service_process_control_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sessions/better_session_restore_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sessions/persistent_tab_restore_service_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sessions/session_restore.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sessions/session_service_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/shell_integration_unittest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/signin/signin_global_error_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/speech/speech_recognition_bubble_browsertest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/speech/speech_recognition_bubble_controller_unittest.cc View 3 chunks +9 lines, -8 lines 0 comments Download
M chrome/browser/speech/tts_controller_unittest.cc View 1 chunk +9 lines, -9 lines 0 comments Download
M chrome/browser/speech/tts_extension_loader_chromeos.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/speech/tts_linux.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/spellchecker/spellcheck_custom_dictionary_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/spellchecker/spellcheck_service_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/spellchecker/spelling_service_client_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ssl/ssl_browser_tests.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ssl/ssl_tab_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/app_notification_data_type_controller_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/frontend_data_type_controller_unittest.cc View 2 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/sync/glue/history_model_worker.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/non_frontend_data_type_controller_unittest.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/sync/glue/session_model_associator_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/glue/synced_device_tracker_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/glue/typed_url_model_associator_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service_autofill_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service_bookmark_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service_preference_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_session_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_startup_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service_typed_url_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/local_file_sync_service_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync_file_system/sync_file_system_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/system_monitor/removable_device_notifications_linux_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/system_monitor/removable_storage_notifications_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/task_manager/task_manager_unittest.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/themes/theme_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/themes/theme_syncable_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/translate/translate_manager_browsertest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/unload_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/usb/usb_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/web_resource/json_asynchronous_unpacker.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/webdata/web_data_service_unittest.cc View 4 chunks +10 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Ryan Sleevi
thakis: Please consider rubberstamping. This is an automated fixup that was generated by our Clang ...
7 years, 10 months ago (2013-02-06 22:15:42 UTC) #1
Nico
(half-way through) https://codereview.chromium.org/12212048/diff/1/chrome/browser/autofill/autocomplete_history_manager_unittest.cc File chrome/browser/autofill/autocomplete_history_manager_unittest.cc (right): https://codereview.chromium.org/12212048/diff/1/chrome/browser/autofill/autocomplete_history_manager_unittest.cc#newcode183 chrome/browser/autofill/autocomplete_history_manager_unittest.cc:183: delete message; Out of curiosity, did you ...
7 years, 10 months ago (2013-02-06 22:22:57 UTC) #2
Nico
This is a horrible idea and I don't think we should do this. Also, lgtm
7 years, 10 months ago (2013-02-06 22:25:13 UTC) #3
Ryan Sleevi
https://codereview.chromium.org/12212048/diff/1/chrome/browser/autofill/autocomplete_history_manager_unittest.cc File chrome/browser/autofill/autocomplete_history_manager_unittest.cc (right): https://codereview.chromium.org/12212048/diff/1/chrome/browser/autofill/autocomplete_history_manager_unittest.cc#newcode183 chrome/browser/autofill/autocomplete_history_manager_unittest.cc:183: delete message; On 2013/02/06 22:22:58, Nico wrote: > Out ...
7 years, 10 months ago (2013-02-06 22:29:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/12212048/1
7 years, 10 months ago (2013-02-06 22:30:52 UTC) #5
commit-bot: I haz the power
Presubmit check for 12212048-1 failed and returned exit status 1. Running presubmit commit checks ...
7 years, 10 months ago (2013-02-06 22:31:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/12212048/1
7 years, 10 months ago (2013-02-07 00:01:06 UTC) #7
commit-bot: I haz the power
7 years, 10 months ago (2013-02-07 00:02:35 UTC) #8
Presubmit check for 12212048-1 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit Warnings **
New code should not use wstrings.  If you are calling a cross-platform API that
accepts a wstring, fix the API.
    chrome/browser/diagnostics/diagnostics_main.cc:149

Presubmit checks took 12.0s to calculate.

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

Powered by Google App Engine
This is Rietveld 408576698