Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5188)

Unified Diff: chrome/browser/diagnostics/diagnostics_main.cc

Issue 12212048: Linux/ChromeOS Chromium style checker cleanup, chrome/browser edition. (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/diagnostics/diagnostics_main.cc
===================================================================
--- chrome/browser/diagnostics/diagnostics_main.cc (revision 181040)
+++ chrome/browser/diagnostics/diagnostics_main.cc (working copy)
@@ -139,24 +139,24 @@
public:
PosixConsole() : use_color_(false) { }
- virtual bool Init() {
+ virtual bool Init() OVERRIDE {
// Technically, we should also check the terminal capabilities before using
// color, but in practice this is unlikely to be an issue.
use_color_ = isatty(STDOUT_FILENO);
return true;
}
- virtual bool Write(const std::wstring& text) {
+ virtual bool Write(const std::wstring& text) OVERRIDE {
printf("%s", base::SysWideToNativeMB(text).c_str());
return true;
}
- virtual void OnQuit() {
+ virtual void OnQuit() OVERRIDE {
// The "press enter to continue" prompt isn't very unixy, so only do that on
// Windows.
}
- virtual bool SetColor(Color color) {
+ virtual bool SetColor(Color color) OVERRIDE {
if (!use_color_)
return false;
@@ -292,19 +292,21 @@
}
// Next four are overridden from DiagnosticsModel::Observer.
- virtual void OnProgress(int id, int percent, DiagnosticsModel* model) {
+ virtual void OnProgress(int id,
+ int percent,
+ DiagnosticsModel* model) OVERRIDE {
}
- virtual void OnSkipped(int id, DiagnosticsModel* model) {
+ virtual void OnSkipped(int id, DiagnosticsModel* model) OVERRIDE {
// TODO(cpu): display skipped tests.
}
- virtual void OnFinished(int id, DiagnosticsModel* model) {
+ virtual void OnFinished(int id, DiagnosticsModel* model) OVERRIDE {
// As each test completes we output the results.
ShowResult(&model->GetTest(id));
}
- virtual void OnDoneAll(DiagnosticsModel* model) {
+ virtual void OnDoneAll(DiagnosticsModel* model) OVERRIDE {
if (writer_->failures() > 0) {
writer_->WriteInfoText(base::StringPrintf(
"DONE. %d failure(s)\n\n", writer_->failures()));

Powered by Google App Engine
This is Rietveld 408576698