Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2919)

Unified Diff: chrome/browser/printing/print_job_unittest.cc

Issue 12212048: Linux/ChromeOS Chromium style checker cleanup, chrome/browser edition. (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/printing/print_job_unittest.cc
===================================================================
--- chrome/browser/printing/print_job_unittest.cc (revision 181040)
+++ chrome/browser/printing/print_job_unittest.cc (working copy)
@@ -31,12 +31,13 @@
class TestOwner : public printing::PrintJobWorkerOwner {
public:
- virtual void GetSettingsDone(const printing::PrintSettings& new_settings,
- printing::PrintingContext::Result result) {
+ virtual void GetSettingsDone(
+ const printing::PrintSettings& new_settings,
+ printing::PrintingContext::Result result) OVERRIDE {
EXPECT_FALSE(true);
}
virtual printing::PrintJobWorker* DetachWorker(
- printing::PrintJobWorkerOwner* new_owner) {
+ printing::PrintJobWorkerOwner* new_owner) OVERRIDE {
// We're screwing up here since we're calling worker from the main thread.
// That's fine for testing. It is actually simulating PrinterQuery behavior.
TestPrintJobWorker* worker(new TestPrintJobWorker(new_owner));
@@ -45,14 +46,14 @@
settings_ = worker->printing_context()->settings();
return worker;
}
- virtual MessageLoop* message_loop() {
+ virtual MessageLoop* message_loop() OVERRIDE {
EXPECT_FALSE(true);
return NULL;
}
- virtual const printing::PrintSettings& settings() const {
+ virtual const printing::PrintSettings& settings() const OVERRIDE {
return settings_;
}
- virtual int cookie() const {
+ virtual int cookie() const OVERRIDE {
return 42;
}
@@ -67,7 +68,7 @@
explicit TestPrintJob(volatile bool* check) : check_(check) {
}
private:
- ~TestPrintJob() {
+ virtual ~TestPrintJob() {
*check_ = true;
}
volatile bool* check_;
@@ -78,7 +79,7 @@
// content::NotificationObserver
virtual void Observe(int type,
const content::NotificationSource& source,
- const content::NotificationDetails& details) {
+ const content::NotificationDetails& details) OVERRIDE {
ADD_FAILURE();
}
};

Powered by Google App Engine
This is Rietveld 408576698