Linux/ChromeOS Chromium style checker cleanup, chrome/browser/extensions edition.

Linux/ChromeOS Chromium style checker cleanup, chrome/browser/extensions edition.

Automated clean up of style checker errors that were missed due to the plugin
not being executed on implementation files.

BUG=115047
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181160

[Ryan Sleevi, 2013-02-06 22:07:20]

jyasskin: Please consider rubberstamping.

This is an automated fixup that was generated by our Clang style checker plugin
to automatically add "virtual" and "OVERRIDE" to methods that are overriding
virtual methods, consistent with
http://dev.chromium.org/developers/coding-style/chromium-style-checker-errors...
and
http://dev.chromium.org/developers/coding-style/chromium-style-checker-errors...

The plugin is currently disabled in implementation files because of errors like
these.

This change in one part in a 751 file change set, unfortunately being managed by
hand. As such, please consider refraining from any additional nits or further
unrelated cleanups.

[Jeffrey Yasskin, 2013-02-06 22:59:15]

lgtm

https://codereview.chromium.org/12212047/diff/1/chrome/browser/extensions/api...
File chrome/browser/extensions/api/record/record_api_test.cc (right):

https://codereview.chromium.org/12212047/diff/1/chrome/browser/extensions/api...
chrome/browser/extensions/api/record/record_api_test.cc:90:
std::vector<std::string>* errors) OVERRIDE {
Your script missed reindenting this line.

https://codereview.chromium.org/12212047/diff/1/chrome/browser/extensions/ext...
File chrome/browser/extensions/extension_service_unittest.cc (right):

https://codereview.chromium.org/12212047/diff/1/chrome/browser/extensions/ext...
chrome/browser/extensions/extension_service_unittest.cc:5569: virtual void
SetUp() {
Why no OVERRIDE here?

https://codereview.chromium.org/12212047/diff/1/chrome/browser/extensions/man...
File chrome/browser/extensions/management_policy_unittest.cc (right):

https://codereview.chromium.org/12212047/diff/1/chrome/browser/extensions/man...
chrome/browser/extensions/management_policy_unittest.cc:15: virtual void SetUp()
{
Missing OVERRIDE here too.

[Ryan Sleevi, 2013-02-06 23:09:45]

https://codereview.chromium.org/12212047/diff/1/chrome/browser/extensions/ext...
File chrome/browser/extensions/extension_service_unittest.cc (right):

https://codereview.chromium.org/12212047/diff/1/chrome/browser/extensions/ext...
chrome/browser/extensions/extension_service_unittest.cc:5569: virtual void
SetUp() {
On 2013/02/06 22:59:15, Jeffrey Yasskin wrote:
> Why no OVERRIDE here?

Discussion with Nico on whether overrides from testing (specifically
::testing::Test) should require overrides.

Consistent with our exemptions for WK code, it was decided to exempt
testing::Test from the OVERRIDE requirement, since 'all tests should fail' if
GTest renamed SetUp.

[commit-bot: I haz the power, 2013-02-06 23:13:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsleevi@chromium.org/12212047/13008

[commit-bot: I haz the power, 2013-02-07 02:53:17]

Change committed as 181160