chrome/browser/extensions/external_policy_loader_unittest.cc - Issue 12212047: Linux/ChromeOS Chromium style checker cleanup, chrome/browser/extensions edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/external_policy_loader_unittest.cc

Issue 12212047: Linux/ChromeOS Chromium style checker cleanup, chrome/browser/extensions edition. (Closed) Base URL: http://src.chromium.org/svn/trunk/src/

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extensions_quota_service_unittest.cc ('k') | chrome/browser/extensions/isolated_app_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/external_policy_loader_unittest.cc

===================================================================

--- chrome/browser/extensions/external_policy_loader_unittest.cc (revision 181040)

+++ chrome/browser/extensions/external_policy_loader_unittest.cc (working copy)

@@ -73,14 +73,14 @@

const FilePath& path,

Manifest::Location unused,

int unused2,

- bool unused3) {

+ bool unused3) OVERRIDE {

ADD_FAILURE() << "There should be no external extensions from files.";

return false;

}

virtual bool OnExternalExtensionUpdateUrlFound(

const std::string& id, const GURL& update_url,

- Manifest::Location location) {

+ Manifest::Location location) OVERRIDE {

// Extension has the correct location.

EXPECT_EQ(Manifest::EXTERNAL_POLICY_DOWNLOAD, location);

@@ -97,7 +97,7 @@

}

virtual void OnExternalProviderReady(

- const ExternalProviderInterface* provider) {

+ const ExternalProviderInterface* provider) OVERRIDE {

EXPECT_EQ(provider, provider_.get());

EXPECT_TRUE(provider->IsReady());

}