chrome/browser/extensions/api/bookmarks/bookmarks_api.cc - Issue 12212047: Linux/ChromeOS Chromium style checker cleanup, chrome/browser/extensions edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/bookmarks/bookmarks_api.cc

Issue 12212047: Linux/ChromeOS Chromium style checker cleanup, chrome/browser/extensions edition. (Closed) Base URL: http://src.chromium.org/svn/trunk/src/

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/app_window/app_window_apitest.cc ('k') | chrome/browser/extensions/api/browsing_data/browsing_data_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/bookmarks/bookmarks_api.cc

===================================================================

--- chrome/browser/extensions/api/bookmarks/bookmarks_api.cc (revision 181040)

+++ chrome/browser/extensions/api/bookmarks/bookmarks_api.cc (working copy)

@@ -723,7 +723,8 @@

explicit CreateBookmarkBucketMapper(Profile* profile) : profile_(profile) {}

// TODO(tim): This should share code with BookmarksCreateFunction::RunImpl,

// but I can't figure out a good way to do that with all the macros.

- virtual void GetBucketsForArgs(const ListValue* args, BucketList* buckets) {

+ virtual void GetBucketsForArgs(const ListValue* args,

+ BucketList* buckets) OVERRIDE {

const DictionaryValue* json;

if (!args->GetDictionary(0, &json))

return;

@@ -761,7 +762,8 @@

class RemoveBookmarksBucketMapper : public BookmarkBucketMapper<std::string> {

public:

explicit RemoveBookmarksBucketMapper(Profile* profile) : profile_(profile) {}

- virtual void GetBucketsForArgs(const ListValue* args, BucketList* buckets) {

+ virtual void GetBucketsForArgs(const ListValue* args,

+ BucketList* buckets) OVERRIDE {

typedef std::list<int64> IdList;

IdList ids;

bool invalid_id = false;