[Mac] Inform reference counted objects that hold a weak Browser* when the Browser is being destroye…

chrome/browser/ui/cocoa/download/download_shelf_controller_unittest.mm

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import <Cocoa/Cocoa.h>
 
 #import "base/mac/scoped_block.h"
 #import "base/mac/scoped_nsobject.h"
 #include "base/memory/scoped_ptr.h"
 #include "chrome/browser/download/download_shelf.h"
@@ skipping 103 matching lines @@
     resize_delegate_.reset([[ViewResizerPong alloc] init]);
     shelf_.reset([[CountingDownloadShelfController alloc]
                    initWithBrowser:browser()
                     resizeDelegate:resize_delegate_.get()]);
     EXPECT_TRUE([shelf_ view]);
     [[test_window() contentView] addSubview:[shelf_ view]];
   }
 
   void TearDown() override {
     if (shelf_.get()) {
-      [shelf_ exiting];
       shelf_.reset();
     }
     CocoaProfileTest::TearDown();
   }
 
  protected:
   id CreateItemController();
 
   base::scoped_nsobject<CountingDownloadShelfController> shelf_;
   base::scoped_nsobject<ViewResizerPong> resize_delegate_;
@@ skipping 232 matching lines @@
 // Test that pending autoClose calls are cancelled when exiting.
 TEST_F(DownloadShelfControllerTest, CancelAutoCloseOnExit) {
   base::scoped_nsobject<DownloadItemController> item(CreateItemController());
   [shelf_ showDownloadShelf:YES
                isUserAction:NO];
   EXPECT_TRUE([shelf_ isVisible]);
   [shelf_ add:item.get()];
   EXPECT_EQ(0, shelf_.get()->scheduleAutoCloseCount_);
   EXPECT_EQ(2, shelf_.get()->cancelAutoCloseCount_);
 
-  [shelf_ exiting];
+  [shelf_ browserWillBeDestroyed];

[erikchen, 2015/07/08 18:02:17]

Why does this need to be changed from -exiting? 

[jackhou1, 2015/07/09 03:48:02]

They do exactly the same thing. Essentially DownloadShelfController was the only
class using the -browserWillBeDestroyed pattern introduced by this CL. Now that
we have -browserWillBeDestroyed on a bunch of similar classes, it makes sense to
unify it here too.

   EXPECT_EQ(0, shelf_.get()->scheduleAutoCloseCount_);
   EXPECT_EQ(3, shelf_.get()->cancelAutoCloseCount_);
   shelf_.reset();
 }
 
 // The view should not be hidden when the shelf is shown.
 // The view should be hidden after the closing animation.
 TEST_F(DownloadShelfControllerTest, ViewVisibility) {
   [shelf_ showDownloadShelf:YES isUserAction:NO];
   EXPECT_FALSE([[shelf_ view] isHidden]);
 
   [shelf_ setCloseAnimationHandler:^{
       base::MessageLoop::current()->QuitNow();
   }];
   [shelf_ showDownloadShelf:NO isUserAction:NO];
   base::MessageLoop::current()->Run();
   EXPECT_TRUE([[shelf_ view] isHidden]);
 
   [shelf_ showDownloadShelf:YES isUserAction:NO];
   EXPECT_FALSE([[shelf_ view] isHidden]);
 }
 
 }  // namespace