Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1221093002: Add support for refreshing contents of providers which don't support watchers. (Closed)

Created:
5 years, 5 months ago by mtomasz
Modified:
5 years, 5 months ago
Reviewers:
benwells, fukino
CC:
chromium-reviews, extensions-reviews_chromium.org, rginda+watch_chromium.org, jlklein+watch-closure_chromium.org, oshima+watch_chromium.org, vitalyp+closure_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, dbeam+watch-closure_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add support for refreshing contents of providers which don't support watchers. This CL: 1. Adds a file_system_provider.watchable manifest option similar to the existing file_system_provider.configurable. 2. Exposes this flag to Files app. TEST=browser_tests: *FileSystemProvider*Mount* BUG=501864 Committed: https://crrev.com/b577564f300f2cd67cf29e3cd02229f1fd7dd610 Cr-Commit-Position: refs/heads/master@{#337564}

Patch Set 1 #

Patch Set 2 : Fixed tests. #

Total comments: 2

Patch Set 3 : Fixed. #

Patch Set 4 : Fixed tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -41 lines) Patch
M chrome/browser/chromeos/extensions/file_manager/file_manager_private_apitest.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_util.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/file_manager/volume_manager.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/file_manager/volume_manager.cc View 5 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/chromeos/file_system_provider/mount_path_util_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/abort_unittest.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/add_watcher_unittest.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/close_file_unittest.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/configure_unittest.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/copy_entry_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/create_directory_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/create_file_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/delete_entry_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/execute_action_unittest.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/get_actions_unittest.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/get_metadata_unittest.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/move_entry_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/open_file_unittest.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/read_directory_unittest.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/read_file_unittest.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/remove_watcher_unittest.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/truncate_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/unmount_unittest.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/write_file_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/provided_file_system_info.h View 3 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/provided_file_system_info.cc View 3 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/provided_file_system_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/registry_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/service.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/service_unittest.cc View 1 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/throttled_file_system_unittest.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/common/extensions/api/file_manager_private.idl View 1 2 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/file_system_provider.idl View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/file_system_provider_capabilities/file_system_provider_capabilities_handler.h View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/file_system_provider_capabilities/file_system_provider_capabilities_handler.cc View 2 chunks +8 lines, -1 line 0 comments Download
M chrome/common/extensions/api/manifest_types.json View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/templates/intros/fileSystemProvider.html View 2 chunks +5 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/file_browser/mount_test/test.js View 1 2 3 7 chunks +9 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_system_provider/mount/manifest.json View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/file_system_provider/mount/test.js View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/data/extensions/manifest_tests/filesystemprovider_missing_permission.json View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/data/extensions/manifest_tests/filesystemprovider_valid.json View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/closure_compiler/externs/file_manager_private.js View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (6 generated)
mtomasz
@benwells: PTAL (at everything this time). Thanks.
5 years, 5 months ago (2015-07-02 08:52:01 UTC) #2
mtomasz
@benwells: Friendly ping.
5 years, 5 months ago (2015-07-06 08:32:55 UTC) #3
benwells
On 2015/07/06 08:32:55, mtomasz wrote: > @benwells: Friendly ping. There seem to be compile failures ...
5 years, 5 months ago (2015-07-07 00:18:53 UTC) #4
mtomasz
On 2015/07/07 00:18:53, benwells wrote: > On 2015/07/06 08:32:55, mtomasz wrote: > > @benwells: Friendly ...
5 years, 5 months ago (2015-07-07 02:30:00 UTC) #5
benwells
lgtm with the comment fixed. https://codereview.chromium.org/1221093002/diff/20001/chrome/common/extensions/api/file_manager_private.idl File chrome/common/extensions/api/file_manager_private.idl (right): https://codereview.chromium.org/1221093002/diff/20001/chrome/common/extensions/api/file_manager_private.idl#newcode537 chrome/common/extensions/api/file_manager_private.idl:537: // Whether supports configuration ...
5 years, 5 months ago (2015-07-07 03:38:53 UTC) #6
mtomasz
@fukino: PTAL at third_party/closure_compiler/externs/file_manager_private.js. Thanks. https://codereview.chromium.org/1221093002/diff/20001/chrome/common/extensions/api/file_manager_private.idl File chrome/common/extensions/api/file_manager_private.idl (right): https://codereview.chromium.org/1221093002/diff/20001/chrome/common/extensions/api/file_manager_private.idl#newcode537 chrome/common/extensions/api/file_manager_private.idl:537: // Whether supports configuration ...
5 years, 5 months ago (2015-07-07 03:44:48 UTC) #8
mtomasz
5 years, 5 months ago (2015-07-07 03:45:07 UTC) #9
fukino
externs lgtm.
5 years, 5 months ago (2015-07-07 04:14:08 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1221093002/40001
5 years, 5 months ago (2015-07-07 04:14:49 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1221093002/60001
5 years, 5 months ago (2015-07-07 04:42:30 UTC) #16
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 5 months ago (2015-07-07 06:07:54 UTC) #17
commit-bot: I haz the power
5 years, 5 months ago (2015-07-07 06:09:06 UTC) #18
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/b577564f300f2cd67cf29e3cd02229f1fd7dd610
Cr-Commit-Position: refs/heads/master@{#337564}

Powered by Google App Engine
This is Rietveld 408576698