chrome/browser/chromeos/file_system_provider/service_unittest.cc - Issue 1221093002: Add support for refreshing contents of providers which don't support watchers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/file_system_provider/service_unittest.cc

Issue 1221093002: Add support for refreshing contents of providers which don't support watchers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed tests. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/file_system_provider/service.cc ('k') | chrome/browser/chromeos/file_system_provider/throttled_file_system_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/file_system_provider/service_unittest.cc

diff --git a/chrome/browser/chromeos/file_system_provider/service_unittest.cc b/chrome/browser/chromeos/file_system_provider/service_unittest.cc

index 94765ee681fe176df1c3838fffd7d0211f8a2f51..a84598c7358e2749e079d51402c8a1b6e85aabd4 100644

--- a/chrome/browser/chromeos/file_system_provider/service_unittest.cc

+++ b/chrome/browser/chromeos/file_system_provider/service_unittest.cc

@@ -417,7 +417,7 @@ TEST_F(FileSystemProviderServiceTest, RestoreFileSystem_OnExtensionLoad) {

options.supports_notify_tag = true;

ProvidedFileSystemInfo file_system_info(

kExtensionId, options, base::FilePath(FILE_PATH_LITERAL("/a/b/c")),

- false /* configurable */, extensions::SOURCE_FILE);

+ false /* configurable */, false /* watchable */, extensions::SOURCE_FILE);

Watchers fake_watchers;

fake_watchers[WatcherKey(fake_watcher_.entry_path, fake_watcher_.recursive)] =

fake_watcher_;

@@ -437,7 +437,7 @@ TEST_F(FileSystemProviderServiceTest, RestoreFileSystem_OnExtensionLoad) {

EXPECT_EQ(file_system_info.file_system_id(),

observer.mounts[0].file_system_info().file_system_id());

EXPECT_EQ(file_system_info.writable(),

- observer.mounts[0].file_system_info().writable());

+ observer.mounts[0].file_system_info().watchable());

EXPECT_EQ(file_system_info.supports_notify_tag(),

observer.mounts[0].file_system_info().supports_notify_tag());

@@ -481,6 +481,8 @@ TEST_F(FileSystemProviderServiceTest, RememberFileSystem_OnMount) {

EXPECT_EQ(kFileSystemId, registry_->file_system_info()->file_system_id());

EXPECT_EQ(kDisplayName, registry_->file_system_info()->display_name());

EXPECT_FALSE(registry_->file_system_info()->writable());

+ EXPECT_FALSE(registry_->file_system_info()->configurable());

+ EXPECT_FALSE(registry_->file_system_info()->watchable());

EXPECT_FALSE(registry_->file_system_info()->supports_notify_tag());

ASSERT_TRUE(registry_->watchers());