Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 12210137: Revert 181896 (Closed)

Created:
7 years, 10 months ago by jochen (gone - plz use gerrit)
Modified:
7 years, 10 months ago
CC:
chromium-reviews, sadrul, ben+watch_chromium.org, gspencer+watch_chromium.org, gauravsh+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org
Visibility:
Public.

Description

Revert 181896 this change was not at fault > Revert 181806 > > Speculative revert to see whether this broke browser_tests on Win Aura Tests(2) > > A DCHECK() about invalid strings is hit > > > Update NetworkStateListDetailedView, add network_icon::GetImageForTray > > > > This integrates chanhes to the network list and icon code, > > and uses the Ash icon code in the network tray. > > > > This completes the changes for: > > 161869: Create NetworkStateHandler version of Ash network tray > > (Still behind a flag) > > > > BUG=161869 > > TBR=sky@chromium.org (for ash_strings) > > > > Review URL: https://codereview.chromium.org/12221112 > > TBR=stevenjb@chromium.org > Review URL: https://codereview.chromium.org/12218116 TBR=jochen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181899

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+732 lines, -349 lines) Patch
M ash/ash_strings.grd View 1 chunk +3 lines, -0 lines 0 comments Download
M ash/system/chromeos/network/network_icon.h View 2 chunks +22 lines, -10 lines 0 comments Download
M ash/system/chromeos/network/network_icon.cc View 15 chunks +215 lines, -142 lines 0 comments Download
M ash/system/chromeos/network/network_icon_animation.h View 3 chunks +6 lines, -0 lines 0 comments Download
M ash/system/chromeos/network/network_icon_animation.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M ash/system/chromeos/network/network_state_list_detailed_view.h View 6 chunks +22 lines, -5 lines 0 comments Download
M ash/system/chromeos/network/network_state_list_detailed_view.cc View 11 chunks +186 lines, -143 lines 0 comments Download
M ash/system/chromeos/network/tray_network.h View 3 chunks +33 lines, -1 line 0 comments Download
M ash/system/chromeos/network/tray_network.cc View 13 chunks +217 lines, -48 lines 0 comments Download
M ash/system/chromeos/network/tray_network_state_observer.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ash/system/chromeos/network/tray_network_state_observer.cc View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
jochen (gone - plz use gerrit)
7 years, 10 months ago (2013-02-12 09:52:31 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698