Get rid of native-desktop-only BrowserList:: iterator methods in tests.

Get rid of native-desktop-only BrowserList:: iterator methods in tests.

This is the last CL to get rid of BrowserList::const_iterator, BrowserList::begin(), and BrowserList::end() entirely (hopefully -- i.e., I can now build chrome, browser_tests, and unit_tests without these 3 methods -- there are 3 other CLs in the pipeline in parallel, I will land a CL to remove those methods for good once ToT no longer requires them)!

Various browser tests were already making explicit assumptions about native-desktop, hardcoding that some more in some places. Otherwise just replacing all the iterators by BrowserIterator (which in theory is multi-desktop, but in browser tests only the native desktop's list will have browsers for now).

Further changes can be made independently later if multi-desktop browser tests are desired.

BUG=129187
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181878

[gab, 2013-02-07 20:20:55]

Scott, please take a look.

Thanks!
Gab

[gab, 2013-02-11 15:39:18]

@sky: ping

Thanks,
Gab

[sky, 2013-02-11 21:15:01]

LGTM

[commit-bot: I haz the power, 2013-02-11 21:19:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gab@chromium.org/12210067/1001

[commit-bot: I haz the power, 2013-02-12 01:28:09]

Retried try job too often on linux_chromeos for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-02-12 03:27:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gab@chromium.org/12210067/13003

[commit-bot: I haz the power, 2013-02-12 04:34:07]

Retried try job too often on mac_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2013-02-12 04:42:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gab@chromium.org/12210067/13003

[commit-bot: I haz the power, 2013-02-12 06:15:57]

Change committed as 181878