Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Unified Diff: chrome/test/base/ui_test_utils.cc

Issue 12210067: Get rid of native-desktop-only BrowserList:: iterator methods in tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: merge up to r181832 Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/base/in_process_browser_test.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/base/ui_test_utils.cc
diff --git a/chrome/test/base/ui_test_utils.cc b/chrome/test/base/ui_test_utils.cc
index d8245f1315c1042da06c3c5dc6bafdb936413155..29b52362f8f493f671b388be5a1bc9a8ed7266f0 100644
--- a/chrome/test/base/ui_test_utils.cc
+++ b/chrome/test/base/ui_test_utils.cc
@@ -36,6 +36,7 @@
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_commands.h"
#include "chrome/browser/ui/browser_finder.h"
+#include "chrome/browser/ui/browser_iterator.h"
#include "chrome/browser/ui/browser_list.h"
#include "chrome/browser/ui/browser_navigator.h"
#include "chrome/browser/ui/browser_window.h"
@@ -260,11 +261,8 @@ static void NavigateToURLWithDispositionBlockUntilNavigationsComplete(
number_of_navigations);
std::set<Browser*> initial_browsers;
- for (std::vector<Browser*>::const_iterator iter = BrowserList::begin();
- iter != BrowserList::end();
- ++iter) {
- initial_browsers.insert(*iter);
- }
+ for (chrome::BrowserIterator it; !it.done(); it.Next())
+ initial_browsers.insert(*it);
content::WindowedNotificationObserver tab_added_observer(
chrome::NOTIFICATION_TAB_ADDED,
@@ -477,13 +475,10 @@ void SendToOmniboxAndSubmit(LocationBar* location_bar,
}
Browser* GetBrowserNotInSet(std::set<Browser*> excluded_browsers) {
- for (BrowserList::const_iterator iter = BrowserList::begin();
- iter != BrowserList::end();
- ++iter) {
- if (excluded_browsers.find(*iter) == excluded_browsers.end())
- return *iter;
+ for (chrome::BrowserIterator it; !it.done(); it.Next()) {
+ if (excluded_browsers.find(*it) == excluded_browsers.end())
+ return *it;
}
-
return NULL;
}
@@ -525,7 +520,8 @@ BrowserAddedObserver::BrowserAddedObserver()
: notification_observer_(
chrome::NOTIFICATION_BROWSER_OPENED,
content::NotificationService::AllSources()) {
- original_browsers_.insert(BrowserList::begin(), BrowserList::end());
+ for (chrome::BrowserIterator it; !it.done(); it.Next())
+ original_browsers_.insert(*it);
}
BrowserAddedObserver::~BrowserAddedObserver() {
« no previous file with comments | « chrome/test/base/in_process_browser_test.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698