Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1079)

Unified Diff: chrome/browser/ui/browser_browsertest.cc

Issue 12210067: Get rid of native-desktop-only BrowserList:: iterator methods in tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: merge up to r181832 Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sessions/tab_restore_browsertest.cc ('k') | chrome/browser/ui/browser_close_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/browser_browsertest.cc
diff --git a/chrome/browser/ui/browser_browsertest.cc b/chrome/browser/ui/browser_browsertest.cc
index 58232981149d3f4e375b5b1926f0a747ad27e743..6d7a8e36b27d72d88f0cd56001c8caff59d11082 100644
--- a/chrome/browser/ui/browser_browsertest.cc
+++ b/chrome/browser/ui/browser_browsertest.cc
@@ -32,6 +32,7 @@
#include "chrome/browser/ui/browser_command_controller.h"
#include "chrome/browser/ui/browser_commands.h"
#include "chrome/browser/ui/browser_finder.h"
+#include "chrome/browser/ui/browser_iterator.h"
#include "chrome/browser/ui/browser_list.h"
#include "chrome/browser/ui/browser_navigator.h"
#include "chrome/browser/ui/browser_tabstrip.h"
@@ -801,10 +802,9 @@ IN_PROC_BROWSER_TEST_F(BrowserTest, DISABLED_ConvertTabToAppShortcut) {
// Find the new browser.
Browser* app_browser = NULL;
- for (BrowserList::const_iterator i = BrowserList::begin();
- i != BrowserList::end() && !app_browser; ++i) {
- if (*i != browser())
- app_browser = *i;
+ for (chrome::BrowserIterator it; !it.done() && !app_browser; it.Next()) {
+ if (*it != browser())
+ app_browser = *it;
}
ASSERT_TRUE(app_browser);
@@ -937,10 +937,9 @@ IN_PROC_BROWSER_TEST_F(BrowserTest, AppIdSwitch) {
// Find the new browser.
Browser* new_browser = NULL;
- for (BrowserList::const_iterator i = BrowserList::begin();
- i != BrowserList::end() && !new_browser; ++i) {
- if (*i != browser())
- new_browser = *i;
+ for (chrome::BrowserIterator it; !it.done() && !new_browser; it.Next()) {
+ if (*it != browser())
+ new_browser = *it;
}
ASSERT_TRUE(new_browser);
ASSERT_TRUE(new_browser != browser());
@@ -1045,10 +1044,9 @@ IN_PROC_BROWSER_TEST_F(BrowserTest, RestorePinnedTabs) {
// Find the new browser.
Browser* new_browser = NULL;
- for (BrowserList::const_iterator i = BrowserList::begin();
- i != BrowserList::end() && !new_browser; ++i) {
- if (*i != browser())
- new_browser = *i;
+ for (chrome::BrowserIterator it; !it.done() && !new_browser; it.Next()) {
+ if (*it != browser())
+ new_browser = *it;
}
ASSERT_TRUE(new_browser);
ASSERT_TRUE(new_browser != browser());
@@ -1114,10 +1112,9 @@ IN_PROC_BROWSER_TEST_F(BrowserTest, OpenAppWindowLikeNtp) {
// Find the new browser.
Browser* new_browser = NULL;
- for (BrowserList::const_iterator i = BrowserList::begin();
- i != BrowserList::end() && !new_browser; ++i) {
- if (*i != browser())
- new_browser = *i;
+ for (chrome::BrowserIterator it; !it.done() && !new_browser; it.Next()) {
+ if (*it != browser())
+ new_browser = *it;
}
ASSERT_TRUE(new_browser);
ASSERT_TRUE(new_browser != browser());
« no previous file with comments | « chrome/browser/sessions/tab_restore_browsertest.cc ('k') | chrome/browser/ui/browser_close_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698