Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Unified Diff: chrome/browser/autofill/autofill_browsertest.cc

Issue 1220963005: Update base::StartsWith calls to new form (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@starts_with
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autofill/autofill_browsertest.cc
diff --git a/chrome/browser/autofill/autofill_browsertest.cc b/chrome/browser/autofill/autofill_browsertest.cc
index 24101ab6e301e392152e4700c45460f0698861fa..69d6eafef4c044a2ca19be210b40901562a0991a 100644
--- a/chrome/browser/autofill/autofill_browsertest.cc
+++ b/chrome/browser/autofill/autofill_browsertest.cc
@@ -246,11 +246,11 @@ class AutofillTest : public InProcessBrowserTest {
base::SplitString(data, '\n', &lines);
int parsed_profiles = 0;
for (size_t i = 0; i < lines.size(); ++i) {
- if (base::StartsWithASCII(lines[i], "#", false))
+ if (base::StartsWith(lines[i], "#", base::CompareCase::SENSITIVE))
continue;
- std::vector<std::string> fields;
- base::SplitString(lines[i], '|', &fields);
+ std::vector<std::string> fields = base::SplitString(
+ lines[i], "|", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
Nico 2015/07/06 17:55:00 this is unrelated?
brettw 2015/07/06 18:23:34 Oh yeah, I've been doing both SplitString and Star
if (fields.empty())
continue; // Blank line.

Powered by Google App Engine
This is Rietveld 408576698