Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 12209019: Merge 141093 (Closed)

Created:
7 years, 10 months ago by kerz_chromium
Modified:
7 years, 10 months ago
Reviewers:
allan.jensen
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1364/
Visibility:
Public.

Description

Merge 141093 > REGRESSION: ChildrenAffectedBy flags lost between siblings which have child elements sharing style > https://bugs.webkit.org/show_bug.cgi?id=105672 > > Reviewed by Andreas Kling. > > Source/WebCore: > > Change in how childrenAffectedBy bits were stored made it easier to trigger an issue where childrenAffectedBy bits > were not set due to sharing of styles between cousin elements. > > This patch fixes the issue by not sharing styles from children with parents who prevent sharing. > > Tests: fast/selectors/cousin-stylesharing-adjacent-selector.html > fast/selectors/cousin-stylesharing-last-child-selector.html > > * css/StyleResolver.cpp: > (WebCore::parentElementPreventsSharing): > (WebCore::StyleResolver::locateCousinList): > * dom/Element.cpp: > (WebCore::Element::hasFlagsSetDuringStylingOfChildren): > * dom/Element.h: > (Element): > > LayoutTests: > > Two test cases by Philippe Wittenbergh that triggers the issue. > > * fast/selectors/cousin-stylesharing-adjacent-selector-expected.html: Added. > * fast/selectors/cousin-stylesharing-adjacent-selector.html: Added. > * fast/selectors/cousin-stylesharing-last-child-selector-expected.html: Added. > * fast/selectors/cousin-stylesharing-last-child-selector.html: Added. TBR=allan.jensen@digia.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=141895

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -1347 lines) Patch
A + LayoutTests/fast/selectors/cousin-stylesharing-adjacent-selector.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/selectors/cousin-stylesharing-adjacent-selector-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/selectors/cousin-stylesharing-last-child-selector.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/selectors/cousin-stylesharing-last-child-selector-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/ChangeLog View 1 chunk +0 lines, -1340 lines 0 comments Download
M Source/WebCore/css/StyleResolver.cpp View 3 chunks +9 lines, -11 lines 0 comments Download
M Source/WebCore/dom/Element.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/WebCore/dom/Element.cpp View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
kerz_chromium
7 years, 10 months ago (2013-02-05 17:19:29 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698