Index: Source/WebCore/ChangeLog |
=================================================================== |
--- Source/WebCore/ChangeLog (revision 141894) |
+++ Source/WebCore/ChangeLog (working copy) |
@@ -1,1345 +1,5 @@ |
-2013-01-29 James Robinson <jamesr@chromium.org> |
- |
- Scrollbar and scroll corner composited layers positioned incorrectly |
- https://bugs.webkit.org/show_bug.cgi?id=108255 |
- |
- Reviewed by Simon Fraser. |
- |
- ScrollView::updateScrollbars() needs to update the overflow controls composited layers if scrollbars are added |
- or removed. It was doing this by recording on entry to the function if it had horizontal or vertical scrollbars |
- and then comparing that to m_horizontal/verticalScrollbar on exit. Unfortunately updateScrollbars is recursive |
- and exits without running the postamble code when nested on the callstack. As a result, scrollbars may be |
- added or removed several times during the recursion, possibly leaving the overflow control layers in an |
- inconsistent state, while ending up with the same set of scrollbars. |
- |
- This changes the "has anything changed" logic to only compare local state (hasXXXScrollbar vs |
- newHasXXXScrollbar) so changes in recursive calls are not considered. |
- |
- * platform/ScrollView.cpp: |
- (WebCore::ScrollView::updateScrollbars): |
- |
-2013-01-29 Shinya Kawanaka <shinyak@chromium.org> |
- |
- Convert deprecatedShadowAncestorNode() to shadowHost() in Editor.cpp |
- https://bugs.webkit.org/show_bug.cgi?id=108287 |
- |
- Reviewed by Hajime Morita. |
- |
- This is the effort to convert deprecatedShadowAncestorNode() to shadowHost(). |
- |
- Since all the caller object of deprecatedShadowAncestorNode() is in a shadow tree, calling deprecatedShadowAncestorNode() |
- is equiavalent to calling shadowHost(). Also, for all the occurence of deprecatedShadowAncestorNode(), we don't need to |
- worry about nested ShadowDOM issues. So directly converting deprecatedShadowAncestorNode() to shadowHost() should be safe. |
- |
- No new tests, simple refactoring. |
- |
- * editing/Editor.cpp: |
- (WebCore::Editor::rangeOfString): |
- (WebCore::Editor::countMatchesForText): |
- |
-2013-01-29 Simon Fraser <simon.fraser@apple.com> |
- |
- Rubberband scrolling on news.google.com causes text to blink repeatedly |
- https://bugs.webkit.org/show_bug.cgi?id=107326 |
- |
- Reviewed by Beth Dakin. |
- |
- When in the middle of layout, RenderBlock::updateScrollInfoAfterLayout() |
- could cause us to re-evaluate reasons for compositing, via the call |
- to updateLayerCompositingState() in RenderLayer::updateScrollInfoAfterLayout(). |
- |
- At this time, when layout is still happening, it's bad to look at render |
- geometry to decide when to do compositing (e.g. for fixed position); we might |
- incorrectly conclude that the layer is outside the viewport. |
- |
- Fix by having RenderLayerCompositing store in a member whether it's safe |
- to look at layout information. requiresCompositingForPosition() then consults |
- this bit, and, if it needs to make decisions based on layout but layout is not |
- complete, it doesn't change the compositing state of the layer. |
- |
- Not testable, since dumping the layer tree will update layout and mask the bug. |
- |
- * rendering/RenderLayerCompositor.cpp: |
- (WebCore::RenderLayerCompositor::RenderLayerCompositor): |
- (WebCore::RenderLayerCompositor::updateCompositingLayers): |
- (WebCore::RenderLayerCompositor::requiresCompositingForPosition): |
- * rendering/RenderLayerCompositor.h: |
- (RenderLayerCompositor): |
- |
-2013-01-29 Mark Lam <mark.lam@apple.com> |
- |
- Introducing WTF::TypeSafeEnum and DatabaseError. |
- https://bugs.webkit.org/show_bug.cgi?id=108279. |
- |
- Reviewed by Geoffrey Garen. |
- |
- DatabaseError will be used later in the webdatabase refactoring effort. |
- It is currently unused. |
- |
- No new tests. |
- |
- * GNUmakefile.list.am: |
- * Modules/webdatabase/DatabaseError.h: Added. |
- (WebCore): |
- * Target.pri: |
- * WebCore.vcproj/WebCore.vcproj: |
- * WebCore.vcxproj/WebCore.vcxproj: |
- * WebCore.vcxproj/WebCore.vcxproj.filters: |
- * WebCore.xcodeproj/project.pbxproj: |
- |
-2013-01-29 Elliott Sprehn <esprehn@chromium.org> |
- |
- Move ShadowRoot creation into ElementShadow |
- https://bugs.webkit.org/show_bug.cgi?id=108267 |
- |
- Reviewed by Hajime Morita. |
- |
- Instead of the ShadowRoot::create method doing crazy factory things and |
- then needing to assert about the state of the ShadowRoot in addShadowRoot, |
- just create ShadowRoots from inside ElementShadow. |
- |
- No new tests, just refactoring. |
- |
- * dom/Element.cpp: |
- (WebCore::Element::createShadowRoot): Use addShadowRoot(). |
- (WebCore::Element::ensureUserAgentShadowRoot): Use addShadowRoot(). |
- * dom/ElementShadow.cpp: |
- (WebCore::ElementShadow::addShadowRoot): Now returns the new ShadowRoot. |
- * dom/ElementShadow.h: |
- (ElementShadow): |
- * dom/ShadowRoot.cpp: |
- * dom/ShadowRoot.h: |
- (WebCore::ShadowRoot::create): No longer does the association. |
- (WebCore::ShadowRoot::setHost): Sets parent tree scope automatically. |
- |
-2013-01-29 Mark Lam <mark.lam@apple.com> |
- |
- Rename DBBackend::Server to DatabaseServer. |
- https://bugs.webkit.org/show_bug.cgi?id=108278. |
- |
- Rubber stamped by Geoffrey Garen. |
- |
- This is only a renaming operation as part of the webdatabase refactoring |
- effort. There is no semantic change. |
- |
- No new tests. |
- |
- * CMakeLists.txt: |
- * GNUmakefile.list.am: |
- * Modules/webdatabase/DBBackendServer.cpp: Removed. |
- * Modules/webdatabase/DBBackendServer.h: Removed. |
- * Modules/webdatabase/DatabaseManager.cpp: |
- (WebCore::DatabaseManager::DatabaseManager): |
- * Modules/webdatabase/DatabaseServer.cpp: Copied from Source/WebCore/Modules/webdatabase/DBBackendServer.cpp. |
- (WebCore::DatabaseServer::initialize): |
- (WebCore::DatabaseServer::setClient): |
- (WebCore::DatabaseServer::databaseDirectoryPath): |
- (WebCore::DatabaseServer::setDatabaseDirectoryPath): |
- (WebCore::DatabaseServer::fullPathForDatabase): |
- (WebCore::DatabaseServer::hasEntryForOrigin): |
- (WebCore::DatabaseServer::origins): |
- (WebCore::DatabaseServer::databaseNamesForOrigin): |
- (WebCore::DatabaseServer::detailsForNameAndOrigin): |
- (WebCore::DatabaseServer::usageForOrigin): |
- (WebCore::DatabaseServer::quotaForOrigin): |
- (WebCore::DatabaseServer::setQuota): |
- (WebCore::DatabaseServer::deleteAllDatabases): |
- (WebCore::DatabaseServer::deleteOrigin): |
- (WebCore::DatabaseServer::deleteDatabase): |
- (WebCore::DatabaseServer::scheduleNotifyDatabaseChanged): |
- (WebCore::DatabaseServer::databaseChanged): |
- (WebCore::DatabaseServer::closeDatabasesImmediately): |
- (WebCore::DatabaseServer::interruptAllDatabasesForContext): |
- (WebCore::DatabaseServer::canEstablishDatabase): |
- (WebCore::DatabaseServer::addOpenDatabase): |
- (WebCore::DatabaseServer::removeOpenDatabase): |
- (WebCore::DatabaseServer::setDatabaseDetails): |
- (WebCore::DatabaseServer::getMaxSizeForDatabase): |
- (WebCore): |
- * Modules/webdatabase/DatabaseServer.h: Copied from Source/WebCore/Modules/webdatabase/DBBackendServer.h. |
- * Target.pri: |
- * WebCore.gypi: |
- * WebCore.order: |
- * WebCore.vcproj/WebCore.vcproj: |
- * WebCore.vcxproj/WebCore.vcxproj: |
- * WebCore.vcxproj/WebCore.vcxproj.filters: |
- * WebCore.xcodeproj/project.pbxproj: |
- * platform/DatabaseStrategy.cpp: |
- (WebCore::DatabaseStrategy::getDatabaseServer): |
- |
-2013-01-29 Chris Fleizach <cfleizach@apple.com> |
- |
- AX: VoiceOver not reading bullets correctly in the text of notes |
- https://bugs.webkit.org/show_bug.cgi?id=107980 |
- |
- Reviewed by Ryosuke Niwa. |
- |
- Accessibility code should not assume that all list markers end with the same "." suffix. |
- We need to use the actual suffix. |
- |
- Test: platform/mac/accessibility/listmarker-suffix.html |
- |
- * accessibility/AccessibilityObject.cpp: |
- (WebCore::AccessibilityObject::listMarkerTextForNodeAndPosition): |
- |
-2013-01-29 Mark Lam <mark.lam@apple.com> |
- |
- Rename AbstractDatabase to DatabaseBackend. |
- https://bugs.webkit.org/show_bug.cgi?id=108275. |
- |
- Reviewed by Sam Weinig. |
- |
- This is a pure rename operation as part of the webdatabase refactoring |
- effort. There is no semantic change in this patch. |
- |
- No new tests. |
- |
- * CMakeLists.txt: |
- * GNUmakefile.list.am: |
- * Modules/webdatabase/AbstractDatabase.cpp: Removed. |
- * Modules/webdatabase/AbstractDatabase.h: Removed. |
- * Modules/webdatabase/AbstractDatabaseServer.h: |
- (WebCore): |
- (AbstractDatabaseServer): |
- * Modules/webdatabase/DBBackendServer.cpp: |
- (WebCore::DBBackend::Server::databaseChanged): |
- (WebCore::DBBackend::Server::addOpenDatabase): |
- (WebCore::DBBackend::Server::removeOpenDatabase): |
- (WebCore::DBBackend::Server::getMaxSizeForDatabase): |
- * Modules/webdatabase/DBBackendServer.h: |
- * Modules/webdatabase/Database.cpp: |
- (WebCore::Database::Database): |
- (WebCore::Database::version): |
- (WebCore::Database::performOpenAndVerify): |
- * Modules/webdatabase/Database.h: |
- * Modules/webdatabase/DatabaseBackend.cpp: Copied from Source/WebCore/Modules/webdatabase/AbstractDatabase.cpp. |
- (WebCore): |
- (WebCore::DatabaseBackend::databaseInfoTableName): |
- (WebCore::DatabaseBackend::DatabaseBackend): |
- (WebCore::DatabaseBackend::~DatabaseBackend): |
- (WebCore::DatabaseBackend::closeDatabase): |
- (WebCore::DatabaseBackend::version): |
- (WebCore::DatabaseBackend::performOpenAndVerify): |
- (WebCore::DatabaseBackend::scriptExecutionContext): |
- (WebCore::DatabaseBackend::securityOrigin): |
- (WebCore::DatabaseBackend::stringIdentifier): |
- (WebCore::DatabaseBackend::displayName): |
- (WebCore::DatabaseBackend::estimatedSize): |
- (WebCore::DatabaseBackend::fileName): |
- (WebCore::DatabaseBackend::details): |
- (WebCore::DatabaseBackend::getVersionFromDatabase): |
- (WebCore::DatabaseBackend::setVersionInDatabase): |
- (WebCore::DatabaseBackend::setExpectedVersion): |
- (WebCore::DatabaseBackend::getCachedVersion): |
- (WebCore::DatabaseBackend::setCachedVersion): |
- (WebCore::DatabaseBackend::getActualVersionForTransaction): |
- (WebCore::DatabaseBackend::disableAuthorizer): |
- (WebCore::DatabaseBackend::enableAuthorizer): |
- (WebCore::DatabaseBackend::setAuthorizerReadOnly): |
- (WebCore::DatabaseBackend::setAuthorizerPermissions): |
- (WebCore::DatabaseBackend::lastActionChangedDatabase): |
- (WebCore::DatabaseBackend::lastActionWasInsert): |
- (WebCore::DatabaseBackend::resetDeletes): |
- (WebCore::DatabaseBackend::hadDeletes): |
- (WebCore::DatabaseBackend::resetAuthorizer): |
- (WebCore::DatabaseBackend::maximumSize): |
- (WebCore::DatabaseBackend::incrementalVacuumIfNeeded): |
- (WebCore::DatabaseBackend::interrupt): |
- (WebCore::DatabaseBackend::isInterrupted): |
- (WebCore::DatabaseBackend::logErrorMessage): |
- (WebCore::DatabaseBackend::reportOpenDatabaseResult): |
- (WebCore::DatabaseBackend::reportChangeVersionResult): |
- (WebCore::DatabaseBackend::reportStartTransactionResult): |
- (WebCore::DatabaseBackend::reportCommitTransactionResult): |
- (WebCore::DatabaseBackend::reportExecuteStatementResult): |
- (WebCore::DatabaseBackend::reportVacuumDatabaseResult): |
- * Modules/webdatabase/DatabaseBackend.h: Copied from Source/WebCore/Modules/webdatabase/AbstractDatabase.h. |
- (DatabaseBackend): |
- * Modules/webdatabase/DatabaseManager.cpp: |
- (WebCore::DatabaseManager::databaseChanged): |
- (WebCore::DatabaseManager::addOpenDatabase): |
- (WebCore::DatabaseManager::removeOpenDatabase): |
- (WebCore::DatabaseManager::getMaxSizeForDatabase): |
- * Modules/webdatabase/DatabaseManager.h: |
- (DatabaseManager): |
- * Modules/webdatabase/DatabaseSync.cpp: |
- (WebCore::DatabaseSync::DatabaseSync): |
- * Modules/webdatabase/DatabaseSync.h: |
- * Modules/webdatabase/DatabaseTracker.cpp: |
- (WebCore::DatabaseTracker::getMaxSizeForDatabase): |
- (WebCore::DatabaseTracker::databaseChanged): |
- (WebCore::DatabaseTracker::interruptAllDatabasesForContext): |
- (WebCore::DatabaseTracker::addOpenDatabase): |
- (WebCore::DatabaseTracker::removeOpenDatabase): |
- (WebCore::DatabaseTracker::getOpenDatabases): |
- (WebCore::DatabaseTracker::deleteDatabaseFile): |
- * Modules/webdatabase/DatabaseTracker.h: |
- (WebCore): |
- (DatabaseTracker): |
- * Modules/webdatabase/OriginQuotaManager.cpp: |
- (WebCore::OriginQuotaManager::markDatabase): |
- * Modules/webdatabase/OriginQuotaManager.h: |
- (WebCore): |
- (OriginQuotaManager): |
- * Modules/webdatabase/SQLTransactionClient.cpp: |
- (WebCore::SQLTransactionClient::didCommitWriteTransaction): |
- (WebCore::SQLTransactionClient::didExecuteStatement): |
- (WebCore::SQLTransactionClient::didExceedQuota): |
- * Modules/webdatabase/SQLTransactionClient.h: |
- (WebCore): |
- (SQLTransactionClient): |
- * Modules/webdatabase/chromium/DatabaseObserver.h: |
- (WebCore): |
- (DatabaseObserver): |
- * Modules/webdatabase/chromium/DatabaseTrackerChromium.cpp: |
- (WebCore::DatabaseTracker::addOpenDatabase): |
- (WebCore::NotifyDatabaseObserverOnCloseTask::create): |
- (WebCore::NotifyDatabaseObserverOnCloseTask::NotifyDatabaseObserverOnCloseTask): |
- (NotifyDatabaseObserverOnCloseTask): |
- (WebCore::DatabaseTracker::removeOpenDatabase): |
- (WebCore::DatabaseTracker::getMaxSizeForDatabase): |
- (WebCore::DatabaseTracker::CloseOneDatabaseImmediatelyTask::create): |
- (WebCore::DatabaseTracker::CloseOneDatabaseImmediatelyTask::CloseOneDatabaseImmediatelyTask): |
- (DatabaseTracker::CloseOneDatabaseImmediatelyTask): |
- (WebCore::DatabaseTracker::closeOneDatabaseImmediately): |
- * Modules/webdatabase/chromium/SQLTransactionClientChromium.cpp: |
- (WebCore::NotifyDatabaseChangedTask::create): |
- (WebCore::NotifyDatabaseChangedTask::NotifyDatabaseChangedTask): |
- (NotifyDatabaseChangedTask): |
- (WebCore::SQLTransactionClient::didCommitWriteTransaction): |
- (WebCore::SQLTransactionClient::didExecuteStatement): |
- (WebCore::SQLTransactionClient::didExceedQuota): |
- * Target.pri: |
- * WebCore.gypi: |
- * WebCore.order: |
- * WebCore.vcproj/WebCore.vcproj: |
- * WebCore.vcxproj/WebCore.vcxproj: |
- * WebCore.vcxproj/WebCore.vcxproj.filters: |
- * WebCore.xcodeproj/project.pbxproj: |
- |
-2013-01-29 Sheriff Bot <webkit.review.bot@gmail.com> |
- |
- Unreviewed, rolling out r140983. |
- http://trac.webkit.org/changeset/140983 |
- https://bugs.webkit.org/show_bug.cgi?id=108277 |
- |
- Unfortunately, this API has one last client (Requested by |
- abarth on #webkit). |
- |
- * Configurations/FeatureDefines.xcconfig: |
- * Modules/notifications/Notification.cpp: |
- (WebCore::Notification::Notification): |
- (WebCore): |
- (WebCore::Notification::create): |
- * Modules/notifications/Notification.h: |
- (Notification): |
- (WebCore::Notification::isHTML): |
- (WebCore::Notification::setHTML): |
- (WebCore::Notification::url): |
- (WebCore::Notification::setURL): |
- * Modules/notifications/NotificationCenter.h: |
- (WebCore::NotificationCenter::createHTMLNotification): |
- (NotificationCenter): |
- * Modules/notifications/NotificationCenter.idl: |
- * page/FeatureObserver.h: |
- |
-2013-01-29 Rafael Weinstein <rafaelw@chromium.org> |
- |
- parserAppendChild and parserInsertBefore should ensure that child nodes are in the same document |
- https://bugs.webkit.org/show_bug.cgi?id=108260 |
- |
- Reviewed by Eric Seidel. |
- |
- Test: fast/parser/xml-error-adopted.xml |
- |
- The check and adoption if the documents don't match is now moved into ContainerNode::parser* from HTMLConstructionSite. |
- |
- * dom/ContainerNode.cpp: |
- (WebCore::ContainerNode::parserInsertBefore): |
- (WebCore::ContainerNode::parserAppendChild): |
- * html/parser/HTMLConstructionSite.cpp: |
- (WebCore::HTMLConstructionSite::insertTextNode): |
- (WebCore::HTMLConstructionSite::findFosterSite): |
- (WebCore::HTMLConstructionSite::fosterParent): |
- |
-2013-01-29 Shinya Kawanaka <shinyak@chromium.org> |
- |
- [Chromium] Cannot copy text when selecting readonly (or disabled) input elements |
- https://bugs.webkit.org/show_bug.cgi?id=106287 |
- |
- Reviewed by Hajime Morita. |
- |
- When an input element is disabled or readonly, its inner element is not editable. So its rootEditableElement |
- does not exist. In WebViewImpl::caretOrSelectionRange, if rootEditableElement does not exist, it uses |
- a document element. However, the inner element and document element have a different tree scope, the selection range |
- cannot be gotten correctly. |
- |
- We should use ShadowRoot instead of document so that we can stay in the same tree scope. |
- |
- * WebCore.exp.in: |
- * editing/FrameSelection.cpp: |
- (WebCore::FrameSelection::rootEditableElementOrTreeScopeRootNode): Added. Returns ShadowRoot so that we can |
- stay in the same tree scope. |
- (WebCore): |
- * editing/FrameSelection.h: |
- (FrameSelection): |
- * editing/TextIterator.cpp: |
- (WebCore::TextIterator::getLocationAndLengthFromRange): |
- * editing/TextIterator.h: |
- (TextIterator): |
- |
-2013-01-29 Kent Tamura <tkent@chromium.org> |
- |
- INPUT_MULTIPLE_FIELDS_UI: The content should not overflow the <input> boundary |
- https://bugs.webkit.org/show_bug.cgi?id=108069 |
- |
- Reviewed by Hajime Morita. |
- |
- To avoid the overflow, we do: |
- A) Specify overflow:hidden to <input>. |
- |
- However, we need to make sub-fields and buttons workable even if the |
- width is smaller than the intrinsic size. So, we do: |
- B) Make DateTimeEditElement shrinkable, and |
- C) Make the sub-fields scrollable horizontally like input[type=text]. |
- |
- To achieve B, we need to remove -webkit-date-and-time-container (D) |
- because width property for <input> can shrink only the direct child |
- elements. |
- |
- Tests: fast/forms/time-multiple-fields/time-multiple-fields-narrow-width-scroll.html |
- and new test cases in fast/forms/date/date-appearance-basic.html. |
- |
- * css/html.css: |
- (input[type="date"]): |
- Change -webkit-align-items value. (D) |
- Specify overflow:hidden. (A) |
- (input[type="datetime"]): Ditto. |
- (input[type="datetime-local"]): Ditto. |
- (input[type="month"]): Ditto. |
- (input[type="time"]): Ditto. |
- (input[type="week"]): Ditto. |
- (input::-webkit-datetime-edit): |
- Add min-width:0 (B), and overflow:hidden. (C) |
- Remove unnecessary white-space:pre because of white-space:nowrap below. |
- (input::-webkit-datetime-edit-fields-wrapper): |
- Added. This is the child of -webkit-datetime-edit, and contains |
- sub-fields. (C) |
- * html/BaseMultipleFieldsDateAndTimeInputType.cpp: |
- (WebCore::BaseMultipleFieldsDateAndTimeInputType::createShadowSubtree): |
- Remove -webkit-date-and-time-container, and append DateTimeEditElement, |
- spin button, and picker indicator element to the ShadowRoot. (D) |
- (WebCore::BaseMultipleFieldsDateAndTimeInputType::shouldApplyLocaleDirection): |
- <input> for multiple fields UI should have the direction of the browser |
- locale. This is a replacement of the code for dir attribute in |
- updateInnerTextValue below. (D) |
- (WebCore::BaseMultipleFieldsDateAndTimeInputType::updateInnerTextValue): |
- Remove the code to set dir= to -webkit-date-and-time-container. |
- * html/BaseMultipleFieldsDateAndTimeInputType.h: |
- (BaseMultipleFieldsDateAndTimeInputType): |
- Declare shouldApplyLocaleDirection. (D) |
- * html/HTMLInputElement.cpp: |
- (WebCore::HTMLInputElement::HTMLInputElement): |
- Calls setHasCustomCallbacks for customStyleForRenderer. (D) |
- (WebCore::HTMLInputElement::customStyleForRenderer): |
- Set direction to RenderStyle if shouldApplyLocaleDirection is true. This |
- is a replacement of the dir setting code in |
- BaseMultipleFieldsDateAndTimeInputType::updateInnerTextValue. (D) |
- * html/HTMLInputElement.h: |
- (HTMLInputElement): Declare customStyleForRenderer. (D) |
- * html/InputType.cpp: |
- (WebCore::InputType::shouldApplyLocaleDirection): |
- Add default implmentation of shouldApplyLocaleDirection. (D) |
- * html/InputType.h: |
- (InputType): Declare shouldApplyLocaleDirection. (D) |
- |
- * html/shadow/DateTimeEditElement.cpp: |
- (WebCore::DateTimeEditBuilder::visitLiteral): |
- Add elements to -webkit-datetime-edit-fields-wrapper element. (C) |
- (WebCore::DateTimeEditElement::fieldsWrapperElement): |
- A helper to get -webkit-datetime-edit-fields-wrapper element. (C) |
- (WebCore::DateTimeEditElement::addField): |
- Add elements to -webkit-datetime-edit-fields-wrapper element. (C) |
- (WebCore::DateTimeEditElement::customStyleForRenderer): |
- - Iterate over children of -webkit-datetime-edit-fields-wrapper element. (C) |
- - Set width property instead of min-width. (B) |
- (WebCore::DateTimeEditElement::layout): |
- - Prepare -webkit-datetime-edit-fields-wrapper element. (C) |
- - Handle children of -webkit-datetime-edit-fields-wrapper element. (C) |
- - Need to do style recalc because child structure is changed. (C) |
- * html/shadow/DateTimeEditElement.h: |
- (DateTimeEditElement): Declare fieldsWrapperElement. (C) |
- |
-2013-01-29 Tom Sepez <tsepez@chromium.org> |
- |
- [v8] Enable binding integrity on linux |
- https://bugs.webkit.org/show_bug.cgi?id=108242 |
- |
- Reviewed by Adam Barth. |
- |
- Patch is correct if existing tests pass. |
- |
- * html/TextMetrics.idl: |
- Suppress check to allow link on linux. |
- |
-2013-01-29 Tim Horton <timothy_horton@apple.com> |
- |
- Don't updateTileCoverageMap() from setScrollingModeIndication if we don't need to. |
- |
- Reviewed by Simon Fraser. |
- |
- Only do the work if the tiled scrolling indicator/map is enabled. |
- |
- * platform/graphics/ca/mac/TileCache.mm: |
- (WebCore::TileCache::setScrollingModeIndication): |
- |
-2013-01-29 Chris Fleizach <cfleizach@apple.com> |
- |
- AX: Add support for aria-autocomplete="list" on ARIA combobox |
- https://bugs.webkit.org/show_bug.cgi?id=108228 |
- |
- Reviewed by Ryosuke Niwa. |
- |
- Comboboxes behave much like textfields, and so they need |
- to respond like text controls. |
- |
- Test: platform/mac/accessibility/combox-box-value.html |
- |
- * accessibility/AccessibilityObject.cpp: |
- (WebCore::AccessibilityObject::isTextControl): |
- (WebCore): |
- * accessibility/AccessibilityObject.h: |
- (AccessibilityObject): |
- |
-2013-01-29 Nico Weber <thakis@chromium.org> |
- |
- [chromium] Do not mark translation-unit-local functions as extern "C" |
- https://bugs.webkit.org/show_bug.cgi?id=108218 |
- |
- Reviewed by Adam Barth. |
- |
- Requested by darin in https://bugs.webkit.org/show_bug.cgi?id=107845 |
- This also allows enabling -Wreturn-type-c-linkage again, but I'd like to |
- wait for the next clang roll (which tweaks this warning) before undoing |
- r140800 (which removed that warning). |
- |
- No behavior change. |
- |
- * bindings/v8/npruntime.cpp: |
- |
-2013-01-29 Geoffrey Garen <ggaren@apple.com> |
- |
- Removed GGC because it has been disabled for a long time |
- https://bugs.webkit.org/show_bug.cgi?id=108245 |
- |
- Reviewed by Filip Pizlo. |
- |
- * ForwardingHeaders/heap/CardSet.h: Removed. |
- * WebCore.vcxproj/WebCore.vcxproj: |
- * WebCore.vcxproj/WebCore.vcxproj.filters: |
- |
-2013-01-29 Elliott Sprehn <esprehn@chromium.org> |
- Refactor ShadowRoot exception handling |
- https://bugs.webkit.org/show_bug.cgi?id=108209 |
- |
- Reviewed by Dimitri Glazkov. |
- |
- Many of the exception cases for ShadowRoot are actually impossible and |
- should be asserts instead. We can also move the one case of exception logic, |
- for elements that don't allow author shadows into Element::createShadowRoot |
- instead of having it all over the ShadowRoot and ElementShadow classes. This |
- is the first step in centralizing all ShadowRoot creation inside ElementShadow. |
- |
- No new tests, covered by existing tests. |
- |
- * WebCore.exp.in: |
- * dom/Element.cpp: |
- (WebCore::Element::createShadowRoot): Be explicit about what kind of ShadowRoot you're creating. |
- (WebCore::Element::ensureUserAgentShadowRoot): No more exceptions. |
- * dom/ElementShadow.cpp: |
- (WebCore::ElementShadow::addShadowRoot): This never actually throws exceptions, remove ExceptionCode. |
- * dom/ElementShadow.h: |
- (ElementShadow): |
- * dom/ShadowRoot.cpp: |
- (WebCore::determineUsageType): Merge with Element::createShadowRoot. |
- (WebCore): |
- (WebCore::ShadowRoot::ShadowRoot): Moved Histogram logic here since it's actually about the constructor anyway. |
- (WebCore::ShadowRoot::create): Removed overload that made the code less obvious. |
- * dom/ShadowRoot.h: |
- (ShadowRoot): |
- * html/HTMLKeygenElement.cpp: |
- (WebCore::HTMLKeygenElement::HTMLKeygenElement): |
- * html/shadow/TextFieldDecorationElement.cpp: |
- (WebCore::getDecorationRootAndDecoratedRoot): |
- * testing/Internals.cpp: |
- (WebCore::Internals::ensureShadowRoot): |
- (WebCore::Internals::createShadowRoot): |
- |
-2013-01-29 Mark Lam <mark.lam@apple.com> |
- |
- Change DatabaseContext lookup to be thread-safe. |
- https://bugs.webkit.org/show_bug.cgi?id=107784. |
- |
- Reviewed by Geoffrey Garen. |
- |
- DatabaseContext will no longer be a Supplement of ScriptExecutionContext. |
- Instead we will maintain a mutex guarded contextMap in the DatabaseManager |
- which maps ScriptExecutionContexts to DatabaseContexts. |
- |
- Also cleaned up the shutdown mechanism of the DatabaseContext, |
- DatabaseThread, and Databases when their owner ScriptExecutionContext |
- destructs. |
- |
- No new tests. |
- |
- * Modules/webdatabase/AbstractDatabase.cpp: |
- (WebCore::AbstractDatabase::AbstractDatabase): |
- * Modules/webdatabase/AbstractDatabase.h: |
- (WebCore::AbstractDatabase::databaseContext): |
- (AbstractDatabase): |
- * Modules/webdatabase/Database.cpp: |
- (WebCore::Database::Database): |
- * Modules/webdatabase/Database.h: |
- (WebCore): |
- (Database): |
- * Modules/webdatabase/DatabaseContext.cpp: |
- (WebCore): |
- (WebCore::DatabaseContext::DatabaseContext): |
- (WebCore::DatabaseContext::~DatabaseContext): |
- (WebCore::DatabaseContext::contextDestroyed): |
- (WebCore::DatabaseContext::stop): |
- (WebCore::DatabaseContext::databaseThread): |
- (WebCore::DatabaseContext::stopDatabases): |
- * Modules/webdatabase/DatabaseContext.h: |
- (DatabaseContext): |
- (WebCore::DatabaseContext::scriptExecutionContext): |
- (WebCore::DatabaseContext::hasOpenDatabases): |
- (WebCore::DatabaseContext::stopDatabases): |
- * Modules/webdatabase/DatabaseManager.cpp: |
- (WebCore::DatabaseManager::manager): |
- (WebCore::DatabaseManager::DatabaseManager): |
- (WebCore::DatabaseManager::getExistingDatabaseContext): |
- (WebCore): |
- (WebCore::DatabaseManager::getDatabaseContext): |
- (WebCore::DatabaseManager::registerDatabaseContext): |
- (WebCore::DatabaseManager::unregisterDatabaseContext): |
- (WebCore::DatabaseManager::notifyDatabaseContextConstructed): |
- (WebCore::DatabaseManager::notifyDatabaseContextDestructed): |
- (WebCore::DatabaseManager::openDatabase): |
- (WebCore::DatabaseManager::openDatabaseSync): |
- (WebCore::DatabaseManager::hasOpenDatabases): |
- (WebCore::DatabaseManager::stopDatabases): |
- (WebCore::DatabaseManager::interruptAllDatabasesForContext): |
- * Modules/webdatabase/DatabaseManager.h: |
- (WebCore): |
- (DatabaseManager): |
- (WebCore::DatabaseManager::notifyDatabaseContextConstructed): |
- (WebCore::DatabaseManager::notifyDatabaseContextDestructed): |
- * Modules/webdatabase/DatabaseSync.cpp: |
- (WebCore::DatabaseSync::DatabaseSync): |
- * Modules/webdatabase/DatabaseSync.h: |
- (WebCore): |
- (DatabaseSync): |
- * Modules/webdatabase/DatabaseThread.cpp: |
- (WebCore::DatabaseThread::~DatabaseThread): |
- (WebCore::DatabaseThread::requestTermination): |
- * Modules/webdatabase/DatabaseTracker.cpp: |
- (WebCore::DatabaseTracker::canEstablishDatabase): |
- * dom/ActiveDOMObject.cpp: |
- (WebCore::ActiveDOMObject::~ActiveDOMObject): |
- |
-2013-01-29 Julien Chaffraix <jchaffraix@webkit.org> |
- |
- [CSS Grid Layout] Make resolveContentBasedTrackSizingFunctionsForItems reuse distributeSpaceToTracks |
- https://bugs.webkit.org/show_bug.cgi?id=108110 |
- |
- Reviewed by Tony Chang. |
- |
- This change makes us match more closely the specification by reusing distributeSpaceToTracks inside |
- resolveContentBasedTrackSizingFunctionsForItems. This also removes some existing code duplication. |
- |
- Refactoring covered by existing tests. |
- |
- * rendering/RenderGrid.cpp: |
- (WebCore::RenderGrid::computedUsedBreadthOfGridTracks): |
- Updated after distributeSpaceToTracks new arguments. Copying the tracks to a Vector<GridTrack*> is |
- now done here. |
- |
- (WebCore::RenderGrid::resolveContentBasedTrackSizingFunctionsForItems): |
- Removed code duplication and switched to using distributeSpaceToTracks. |
- |
- (WebCore::RenderGrid::distributeSpaceToTracks): |
- Refactored distributeSpaceToTracks to implement the distribution of any extra space above max breadth |
- as it was required to pass the tests (required to properly handling min-content > max). Also changed |
- the arguments of the function to better match the intent of the function. |
- |
- * rendering/RenderGrid.h: Updated distributeSpaceToTracks's arguments. |
- |
-2013-01-29 Elliott Sprehn <esprehn@chromium.org> |
- |
- Remove all ShadowRoots during ElementShadow destruction |
- https://bugs.webkit.org/show_bug.cgi?id=108207 |
- |
- Reviewed by Dimitri Glazkov. |
- |
- There's no reason to expose removeAllShadowRoots since the only legitimate |
- place to call it is right as we're destroying the ElementShadow. |
- |
- No new tests, just refactoring. |
- |
- * dom/Element.cpp: |
- (WebCore::Element::~Element): Remove call to removeAllShadowRoots() |
- * dom/ElementShadow.h: |
- (WebCore::ElementShadow::~ElementShadow): Call removeAllShadowRoots(). |
- (ElementShadow): Make removeAllShadowRoots() private. |
- |
-2013-01-29 Justin Novosad <junov@google.com> |
- |
- REGRESSION (r135628-135632): Double box shadow failure to render |
- https://bugs.webkit.org/show_bug.cgi?id=107833 |
- |
- Reviewed by Simon Fraser. |
- |
- Regression caused by http://trac.webkit.org/changeset/135629 |
- The regression was due to faulty occlusion logic that was assuming |
- that drawing the background color of a render box background layer |
- could be skipped when the same layer also has an opaque image attached. |
- In the case where the background color is drawn for the purpose of |
- rendering a box shadow, the shadow is typically not |
- completely occluded by the background image because of the shadow |
- blur and/or offset. This patch fixes the problem by not culling a |
- background draw if it is used to draw a box shadow. |
- |
- Test: fast/backgrounds/gradient-background-shadow.html |
- |
- * rendering/RenderBoxModelObject.cpp: |
- (WebCore::RenderBoxModelObject::paintFillLayerExtended): |
- Changing occlusion culling test to never cull background color |
- draw if it is used to draw a box shadow. This is because box shadows |
- can draw outside the border fill region. |
- |
-2013-01-29 Ian Vollick <vollick@chromium.org> |
- |
- Add RenderLayer::enclosingStackingContainer |
- https://bugs.webkit.org/show_bug.cgi?id=108211 |
- |
- Reviewed by Simon Fraser. |
- |
- No new tests, no change in functionality. |
- |
- * rendering/RenderLayer.h: |
- (WebCore::RenderLayer::enclosingStackingContainer): |
- This function is similar to RenderLayer::stackingContainer, but may return the |
- layer itself if it's a stacking container. |
- |
-2013-01-29 Patrick Gansterer <paroga@webkit.org> |
- |
- Rename TextBreakIteratorWinCE to TextBreakIteratorWchar |
- https://bugs.webkit.org/show_bug.cgi?id=108094 |
- |
- Reviewed by Ryosuke Niwa. |
- |
- TextBreakIteratorWinCE does not contain any Windows CE specific code. |
- Rename it to TextBreakIteratorWchar to match the name in wtf/unicode. |
- |
- * platform/text/wchar/TextBreakIteratorWchar.cpp: Renamed from Source/WebCore/platform/text/wince/TextBreakIteratorWinCE.cpp. |
- |
-2013-01-29 Tommy Widenflycht <tommyw@google.com> |
- |
- MediaStream API: A MediaStreamComponent should be able to return the MediaStreamDescriptor it belongs to |
- https://bugs.webkit.org/show_bug.cgi?id=108173 |
- |
- Reviewed by Adam Barth. |
- |
- To be able to return the MediaStreamDescriptor a MediaStreamComponent belongs to the "ownership" |
- of the MediaStreamDescriptor needed to move from a MediaStreamTrack to the MediaStreamComponent. |
- This is also better from an architectonic view as well. |
- |
- Patch covered by existing tests. |
- |
- * Modules/mediastream/MediaStream.cpp: |
- (WebCore::MediaStream::MediaStream): |
- (WebCore::MediaStream::addTrack): |
- (WebCore::MediaStream::addRemoteTrack): |
- * Modules/mediastream/MediaStreamTrack.cpp: |
- (WebCore::MediaStreamTrack::create): |
- (WebCore::MediaStreamTrack::MediaStreamTrack): |
- (WebCore::MediaStreamTrack::setEnabled): |
- * Modules/mediastream/MediaStreamTrack.h: |
- (MediaStreamTrack): |
- * Modules/mediastream/RTCStatsRequestImpl.cpp: |
- (WebCore::RTCStatsRequestImpl::RTCStatsRequestImpl): |
- * platform/chromium/support/WebMediaStreamComponent.cpp: |
- (WebKit::WebMediaStreamComponent::stream): |
- (WebKit): |
- * platform/mediastream/MediaStreamComponent.h: |
- (WebCore): |
- (WebCore::MediaStreamComponent::create): |
- (MediaStreamComponent): |
- (WebCore::MediaStreamComponent::stream): |
- (WebCore::MediaStreamComponent::setStream): |
- (WebCore::MediaStreamComponent::MediaStreamComponent): |
- * platform/mediastream/MediaStreamDescriptor.h: |
- (WebCore::MediaStreamDescriptor::MediaStreamDescriptor): |
- |
-2013-01-29 Alec Flett <alecflett@chromium.org> |
- |
- IndexedDB: Pass metadata in to IDBOpenDBRequest.onUpgradeNeeded/onSuccess |
- https://bugs.webkit.org/show_bug.cgi?id=103920 |
- |
- Reviewed by Dimitri Glazkov. |
- |
- Update IDBCallbacks::onSuccess and IDBCallbacks::onUpgradeNeeded to |
- pass through a metadata parameter. While there, remove the unused |
- IDBTransactionBackendInterface parameter to onUpgradeNeeded. |
- |
- As this is another step in the IDB refactor, I've simplified future cleanup |
- work by making the WebKit API code still use the old API. This |
- will make it possible to outright remove code on the chromium side rather |
- than another three-step checkin. |
- |
- No new tests, as this is more refactoring. |
- |
- * Modules/indexeddb/IDBCallbacks.h: |
- (WebCore::IDBCallbacks::onUpgradeNeeded): new method signature. |
- (WebCore::IDBCallbacks::onSuccess): new method signature. |
- * Modules/indexeddb/IDBDatabaseBackendImpl.cpp: |
- (WebCore::IDBDatabaseBackendImpl::VersionChangeOperation::perform): |
- (WebCore::IDBDatabaseBackendImpl::processPendingCalls): |
- (WebCore::IDBDatabaseBackendImpl::openConnection): |
- * Modules/indexeddb/IDBOpenDBRequest.cpp: |
- (WebCore::IDBOpenDBRequest::onUpgradeNeeded): use passed-in metadata. |
- (WebCore::IDBOpenDBRequest::onSuccess): use passed-in metadata. |
- * Modules/indexeddb/IDBOpenDBRequest.h: |
- (IDBOpenDBRequest): |
- |
-2013-01-29 Dirk Schulze <dschulze@adobe.com> |
- |
- Canvas support for isPointInStroke |
- https://bugs.webkit.org/show_bug.cgi?id=108185 |
- |
- Reviewed by Dean Jackson. |
- |
- isPointInStroke(x,y) returns true if a point hits the stroke |
- with applied stroke styles like dashArray, lineCap, lineJoin, lineWidth. |
- The syntax is similar to isPointInPath, which returns true if a point hits |
- the fill area of a path. |
- Firefox implemented isPointInStroke originally and unprefixed it recently: |
- |
- https://bugzilla.mozilla.org/show_bug.cgi?id=803124 |
- |
- Test: fast/canvas/canvas-isPointInStroke.html |
- |
- * html/canvas/CanvasRenderingContext2D.cpp: |
- (WebCore::CanvasStrokeStyleApplier::strokeStyle): Take dashArray and lineDashOffset into account. |
- (WebCore): |
- (WebCore::CanvasRenderingContext2D::isPointInStroke): The implementation of the function. |
- * html/canvas/CanvasRenderingContext2D.h: |
- (CanvasRenderingContext2D): |
- * html/canvas/CanvasRenderingContext2D.idl: Added operation to interface. |
- |
-2013-01-29 Nate Chapin <japhet@chromium.org> |
- |
- Enable reuse of cached main resources |
- https://bugs.webkit.org/show_bug.cgi?id=105667 |
- |
- Reviewed by Adam Barth. |
- |
- Test: http/tests/cache/cached-main-resource.html |
- |
- * WebCore.exp.in: |
- * dom/Document.cpp: |
- (WebCore::Document::hasManifest): Returns true if the <html> element has a non-empty manifest attribute. |
- (WebCore): |
- * dom/Document.h: |
- (Document): |
- * loader/FrameLoader.cpp: |
- (WebCore::FrameLoader::loadedResourceFromMemoryCache): Don't send delegate callbacks for cache hit here, since |
- MainResourceLoader will take care of it. |
- * loader/MainResourceLoader.cpp: |
- (WebCore::MainResourceLoader::MainResourceLoader): |
- (WebCore::MainResourceLoader::receivedError): |
- (WebCore::MainResourceLoader::willSendRequest): |
- (WebCore::MainResourceLoader::responseReceived): Don't try to cache loads from the application cache. |
- (WebCore::MainResourceLoader::didFinishLoading): Don't try to cache loads from the application cache. |
- (WebCore::MainResourceLoader::load): Ensure we create a resource load identifier for cache hits. Also, |
- ensure we correctly popualate fragment identifiers in the ResourceRequest reported to DocumentLoader. |
- (WebCore::MainResourceLoader::identifier): |
- * loader/MainResourceLoader.h: Rename m_substituteDataLoadIdentifier to m_identifierForLoadWithoutResourceLoader |
- to better describe when it is used. |
- * loader/cache/CachedRawResource.cpp: |
- (WebCore::CachedRawResource::didAddClient): Synthesize redirect notifications for cache hits if necessary. |
- (WebCore::CachedRawResource::willSendRequest): Note the redirects we received. |
- (WebCore::CachedRawResource::canReuse): Don't reuse a resource if the redirect chain included a "Cache-control: no-store". |
- * loader/cache/CachedRawResource.h: |
- (CachedRawResource): |
- (RedirectPair): |
- (WebCore::CachedRawResource::RedirectPair::RedirectPair): |
- * loader/cache/CachedResource.cpp: |
- (WebCore::CachedResource::addClientToSet): Don't return cached data for a main resource synchronously |
- * loader/cache/CachedResource.h: |
- (WebCore::CachedResource::canReuse): |
- (CachedResource): |
- * loader/cache/CachedResourceLoader.cpp: |
- (WebCore::CachedResourceLoader::requestResource): Leave cahce reuse of main resources off for chromium for now. |
- (WebCore::CachedResourceLoader::determineRevalidationPolicy): Permit cache reuse for main resources. |
- * testing/Internals.cpp: |
- (WebCore::Internals::isPreloaded): |
- (WebCore): |
- (WebCore::Internals::isLoadingFromMemoryCache): |
- * testing/Internals.h: |
- (Internals): |
- * testing/Internals.idl: |
- |
-2013-01-29 Min Qin <qinmin@chromium.org> |
- |
- Fix a problem that deferred image decoding is enabled for multiframe images |
- https://bugs.webkit.org/show_bug.cgi?id=108152 |
- |
- Reviewed by Stephen White. |
- |
- Deferred image decoding should only work for single frame images now. |
- However, using ImageDecoder::repetitionCount() does not capture all the cases. |
- Enforce the rule using ImageDecoder::frameCount()==1. |
- Fixing a failing layout test: platform/chromium/virtual/deferred/fast/images/icon-0colors.html |
- |
- * platform/graphics/chromium/DeferredImageDecoder.cpp: |
- (WebCore::DeferredImageDecoder::frameBufferAtIndex): |
- |
-2013-01-29 Elliott Sprehn <esprehn@chromium.org> |
- |
- Move ElementShadow creation to ElementRareData |
- https://bugs.webkit.org/show_bug.cgi?id=108195 |
- |
- Reviewed by Dimitri Glazkov. |
- |
- Move the creation of ElementShadow to ElementRareData |
- for better encapsulation, and get rid of ElementRareData::setShadow. |
- |
- No new tests, just refactoring. |
- |
- * dom/Element.cpp: |
- (WebCore::Element::~Element): Use clearShadow() instead of setShadow which is removed. |
- (WebCore::Element::shadow): |
- (WebCore::Element::ensureShadow): Use ElementRareData::ensureShadow(). |
- * dom/ElementRareData.h: |
- (WebCore::ElementRareData::clearShadow): Added. |
- (WebCore::ElementRareData::ensureShadow): Added. |
- |
-2013-01-29 Alpha Lam <hclam@chromium.org> |
- |
- [chromium] Unreviewed build fix. |
- |
- Revert my revert at 141033 which can cause deadlock. |
- |
- * platform/graphics/chromium/DiscardablePixelRef.cpp: |
- (WebCore::DiscardablePixelRefAllocator::allocPixelRef): |
- (WebCore::DiscardablePixelRef::DiscardablePixelRef): |
- * platform/graphics/chromium/DiscardablePixelRef.h: |
- (DiscardablePixelRef): |
- |
-2013-01-29 Joshua Bell <jsbell@chromium.org> |
- |
- [Chromium] IndexedDB: Let callers specify reason (error) for aborting transaction |
- https://bugs.webkit.org/show_bug.cgi?id=107851 |
- |
- Reviewed by Tony Chang. |
- |
- Internal to the back-end, callers are able to abort transactions and specify a reason |
- as an IDBDatabaseError, e.g. ConstraintError. Expose this to the WebKit/chromium/public |
- API so that intermediate layers can specify reasons as well, e.g. QuotaExceededError. |
- |
- Test will land in Chromium as fix for crbug.com/113118 |
- |
- * Modules/indexeddb/IDBDatabaseBackendImpl.cpp: |
- (WebCore::IDBDatabaseBackendImpl::abort): Added overload that takes error. |
- * Modules/indexeddb/IDBDatabaseBackendImpl.h: Ditto. |
- * Modules/indexeddb/IDBDatabaseBackendInterface.h: Ditto. |
- |
-2013-01-29 Victor Carbune <vcarbune@chromium.org> |
- |
- Heap-use-after-free in WebCore::RenderTextTrackCue::layout |
- https://bugs.webkit.org/show_bug.cgi?id=108197 |
- |
- Reviewed by Eric Carlson. |
- |
- Test: media/track/track-cue-rendering-tree-is-removed-properly.html |
- |
- * html/HTMLMediaElement.cpp: |
- (WebCore::HTMLMediaElement::textTrackRemoveCue): Ensure the display tree |
- is removed when the cue is removed from the list of cues. |
- * html/track/TextTrackCue.cpp: |
- (WebCore::TextTrackCue::~TextTrackCue): Enfore display tree removal. |
- |
-2013-01-29 Eli Fidler <efidler@rim.com> |
- |
- On HarfbuzzNG ports, Arabic TATWEEL is not joined. |
- https://bugs.webkit.org/show_bug.cgi?id=108037 |
- |
- Reviewed by Tony Chang. |
- |
- The tatweel (U+0640) is being split into a separate run, because its script is USCRIPT_COMMON. |
- It has script extensions for USCRIPT_ARABIC, so I think it shouldn't trigger a new run. |
- |
- Test: fast/text/international/arabic-tatweel-join.html |
- |
- * platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp: |
- (WebCore::HarfBuzzShaper::collectHarfBuzzRuns): |
- |
-2013-01-29 Martin Robinson <mrobinson@igalia.com> |
- |
- [Freetype] Cannot use characters outside the BMP |
- https://bugs.webkit.org/show_bug.cgi?id=108102 |
- |
- Reviewed by Carlos Garcia Campos. |
- |
- Test: platform/gtk/fonts/non-bmp-characters.html |
- |
- Instead of never handling surrogate pairs when dealing with UChar arrays, |
- abstract way the logic for this into UTF16UChar32Iterator and use it |
- everywhere in Freetype. This allows the Freetype backend to render |
- non-BMP characters which are always represented as surrogate pairs in |
- UTF-16. |
- |
- * GNUmakefile.list.am: Added UTF16UChar32Iterator to the source list. |
- * platform/graphics/freetype/FontCacheFreeType.cpp: |
- (WebCore::createFontConfigPatternForCharacters): Use the new iterator. |
- (WebCore::FontCache::getFontDataForCharacters): Ditto. |
- * platform/graphics/freetype/GlyphPageTreeNodeFreeType.cpp: |
- (WebCore::GlyphPage::fill): Ditto. Remove the early return when dealing |
- with non-BMP data. |
- * platform/graphics/freetype/SimpleFontDataFreeType.cpp: |
- (WebCore::SimpleFontData::containsCharacters): Use the new iterator. |
- * platform/graphics/freetype/UTF16UChar32Iterator.h: Added. An iterator that |
- extracts UChar32 from UTF-16 UChar arrays. |
- |
- * GNUmakefile.list.am: |
- * platform/graphics/freetype/FontCacheFreeType.cpp: |
- (WebCore::createFontConfigPatternForCharacters): |
- (WebCore::FontCache::getFontDataForCharacters): |
- * platform/graphics/freetype/GlyphPageTreeNodeFreeType.cpp: |
- (WebCore::GlyphPage::fill): |
- * platform/graphics/freetype/SimpleFontDataFreeType.cpp: |
- (WebCore::SimpleFontData::containsCharacters): |
- * platform/graphics/freetype/UTF16UChar32Iterator.h: Added. |
- (WebCore): |
- (UTF16UChar32Iterator): |
- (WebCore::UTF16UChar32Iterator::UTF16UChar32Iterator): |
- (WebCore::UTF16UChar32Iterator::end): |
- (WebCore::UTF16UChar32Iterator::next): |
- |
- * GNUmakefile.list.am: |
- * platform/graphics/freetype/FontCacheFreeType.cpp: |
- (WebCore::createFontConfigPatternForCharacters): |
- * platform/graphics/freetype/GlyphPageTreeNodeFreeType.cpp: |
- (WebCore::GlyphPage::fill): |
- * platform/graphics/freetype/SimpleFontDataFreeType.cpp: |
- (WebCore::SimpleFontData::containsCharacters): |
- * platform/graphics/freetype/UTF16UChar32Iterator.h: Added. |
- (WebCore): |
- (UTF16UChar32Iterator): |
- (WebCore::UTF16UChar32Iterator::UTF16UChar32Iterator): |
- (WebCore::UTF16UChar32Iterator::end): |
- (WebCore::UTF16UChar32Iterator::next): |
- |
-2013-01-29 Glenn Hartmann <hartmanng@chromium.org> |
- |
- Don't overlap test for composited scroll DIVs after scroll |
- https://bugs.webkit.org/show_bug.cgi?id=107471 |
- |
- Reviewed by Simon Fraser. |
- |
- We don't need to test for overlap after scroll when both |
- usesCompositedScrolling and !hasOutOfFlowPositionedDescendant |
- because: |
- |
- a) Since we're using composited-scrolling, the composited region |
- presented by the composited-scrolling element to other non-descendant |
- layers doesn't change during composited scrolling (it's always the |
- entire scroll layer), and |
- |
- b) Since we have no out of flow positioned descendants, the scrolling |
- descendants all move together, so their overlap with respect to each |
- other cannot change. |
- |
- So no descendants nor any non-descendants can have their overlap |
- affected, so it's safe to skip testing. |
- |
- No new tests (no change in behaviour). |
- |
- * rendering/RenderLayer.cpp: |
- (WebCore::RenderLayer::updateCompositingLayersAfterScroll): |
- * rendering/RenderLayerCompositor.cpp: |
- (WebCore::RenderLayerCompositor::updateCompositingLayers): |
- * rendering/RenderLayerCompositor.h: |
- |
-2013-01-29 Alexis Menard <alexis@webkit.org> |
- |
- Implement pseudoElement attribute on transition DOM events. |
- https://bugs.webkit.org/show_bug.cgi?id=107986 |
- |
- Reviewed by Julien Chaffraix. |
- |
- Implement the pseudoElement attribute documented here : |
- http://dev.w3.org/csswg/css3-transitions/#transition-events. |
- This add a new attribute to the transition DOM event useful when |
- animating pseudo elements. As they are not accessible in JS, it's |
- very useful to get on which pseudo element the transition just ended. |
- This patch adds the new attribute on the IDLs of DOM transition events as well |
- as adding it to the C++ classes representing them. The event |
- dispatching code have been patched to change the target of the event |
- (we can't send the current target as it is the actual DOM |
- representation of the pseudo element). |
- |
- Test: fast/css-generated-content/pseudo-transition-event.html |
- |
- * dom/EventDispatcher.cpp: |
- (WebCore::eventTargetRespectingTargetRules): Change the target of the |
- event in the case of a pseudo element. We can't expose them through the |
- public interface so the target is the node they belong to. |
- (WebCore::EventDispatcher::ensureEventAncestors): |
- (WebCore::EventDispatcher::dispatchScopedEvent): |
- (WebCore::EventDispatcher::dispatchEvent): |
- (WebCore::EventDispatcher::dispatchEventPostProcess): |
- * dom/EventTarget.cpp: |
- (WebCore::createMatchingPrefixedEvent): |
- * dom/PseudoElement.cpp: |
- (WebCore::PseudoElement::pseudoElementNameForEvents): |
- (WebCore): |
- * dom/PseudoElement.h: |
- * dom/TransitionEvent.cpp: |
- (WebCore::TransitionEventInit::TransitionEventInit): |
- (WebCore::TransitionEvent::TransitionEvent): |
- (WebCore::TransitionEvent::pseudoElement): |
- (WebCore): |
- * dom/TransitionEvent.h: |
- (TransitionEventInit): |
- (WebCore::TransitionEvent::create): |
- (TransitionEvent): |
- * dom/TransitionEvent.idl: |
- * dom/WebKitTransitionEvent.cpp: |
- (WebCore::WebKitTransitionEventInit::WebKitTransitionEventInit): |
- (WebCore::WebKitTransitionEvent::WebKitTransitionEvent): |
- (WebCore::WebKitTransitionEvent::pseudoElement): |
- (WebCore): |
- * dom/WebKitTransitionEvent.h: |
- (WebKitTransitionEventInit): |
- (WebCore::WebKitTransitionEvent::create): |
- (WebKitTransitionEvent): |
- * dom/WebKitTransitionEvent.idl: |
- * page/animation/AnimationController.cpp: |
- (WebCore::AnimationControllerPrivate::fireEventsAndUpdateStyle): Pass |
- the pseudo element name when creating the Event objects. If the element |
- is not a pseudo element then the name will be empty which is what the |
- spec is telling to do. If the element is a pseudo element then the name |
- will be the pseudo element's name with "::" as a prefix. |
- |
2013-01-29 Allan Sandfeld Jensen <allan.jensen@digia.com> |
- [Qt] Implement GCActivityCallback |
- https://bugs.webkit.org/show_bug.cgi?id=103998 |
- |
- Reviewed by Simon Hausmann. |
- |
- Implements the activity triggered garbage collector, |
- and disables the timer based fallback. |
- |
- * bindings/js/GCController.cpp: |
- (WebCore::GCController::GCController): |
- (WebCore::GCController::garbageCollectSoon): |
- * bindings/js/GCController.h: |
- (GCController): |
- |
-2013-01-29 Andrey Lushnikov <lushnikov@chromium.org> |
- |
- Web Inspector: fix bottom span in token highlight in DTE |
- https://bugs.webkit.org/show_bug.cgi?id=108194 |
- |
- Reviewed by Pavel Feldman. |
- |
- Change css style for token highlight from "border" to "outline" to |
- avoid border included in box dimensions. |
- |
- No new tests: no change in behaviour. |
- |
- * inspector/front-end/textEditor.css: |
- (.text-editor-token-highlight): |
- |
-2013-01-29 Andrey Lushnikov <lushnikov@chromium.org> |
- |
- Web Inspector: introduce HighlightDescriptor interface in DTE. |
- https://bugs.webkit.org/show_bug.cgi?id=108161 |
- |
- Reviewed by Pavel Feldman. |
- |
- Introduce new HighlightDescriptor interface and its |
- RegexHighlightDescriptor implementation and use it in DTE to |
- support overlay highlight. |
- |
- No new tests: no change in behaviour. |
- |
- * inspector/front-end/DefaultTextEditor.js: |
- (WebInspector.DefaultTextEditor.prototype.highlightRegex): |
- (WebInspector.DefaultTextEditor.prototype.removeRegexHighlight): |
- (WebInspector.TextEditorMainPanel): |
- (WebInspector.TextEditorMainPanel.prototype.highlightRegex): |
- (WebInspector.TextEditorMainPanel.prototype.removeRegexHighlight): |
- (WebInspector.TextEditorMainPanel.prototype._paintLines): |
- (WebInspector.TextEditorMainPanel.prototype._measureHighlightDescriptor): |
- (WebInspector.TextEditorMainPanel.HighlightDescriptor): Added. |
- (WebInspector.TextEditorMainPanel.HighlightDescriptor.prototype.affectsLine): |
- (WebInspector.TextEditorMainPanel.HighlightDescriptor.prototype.rangesForLine): |
- (WebInspector.TextEditorMainPanel.HighlightDescriptor.prototype.cssClass): |
- (WebInspector.TextEditorMainPanel.RegexHighlightDescriptor): Added. |
- (WebInspector.TextEditorMainPanel.RegexHighlightDescriptor.prototype.affectsLine): |
- (WebInspector.TextEditorMainPanel.RegexHighlightDescriptor.prototype.rangesForLine): |
- (WebInspector.TextEditorMainPanel.RegexHighlightDescriptor.prototype.cssClass): |
- (WebInspector.TextEditorMainPanel.TokenHighlighter.prototype._highlight): |
- (WebInspector.TextEditorMainPanel.TokenHighlighter.prototype._removeHighlight): |
- * inspector/front-end/TextEditor.js: |
- (WebInspector.TextEditor.prototype.removeRegexHighlight): |
- |
-2013-01-29 Grzegorz Czajkowski <g.czajkowski@samsung.com> |
- |
- [EFL] Unified text checker implementation. |
- https://bugs.webkit.org/show_bug.cgi?id=107682 |
- |
- Reviewed by Anders Carlsson. |
- |
- No new tests, covered by editing/spelling tests. |
- |
- * platform/text/TextChecking.h: |
- (WebCore): |
- Enabling unified text checker feature for WebKit-EFL. |
- |
-2013-01-29 Vladislav Kaznacheev <kaznacheev@chromium.org> |
- |
- Web Inspector: Wrong indent in Styles sidebar pane |
- https://bugs.webkit.org/show_bug.cgi?id=108186 |
- |
- Reviewed by Alexander Pavlov. |
- |
- Added an extra selector to prevent a conflict with a rule in elementsPanel.css. |
- |
- No new tests. |
- |
- * inspector/front-end/inspector.css: |
- (.pane.expanded .section .properties, .event-bar .event-properties): |
- |
-2013-01-29 Florin Malita <fmalita@chromium.org> |
- |
- [Chromium] Unreviewed gardening. |
- |
- Update bindings-tests results after http://trac.webkit.org/changeset/141034. |
- |
- * bindings/scripts/test/V8/V8Float64Array.cpp: |
- (WebCore): |
- (WebCore::checkTypeOrDieTrying): |
- (WebCore::V8Float64Array::createWrapper): |
- * bindings/scripts/test/V8/V8TestActiveDOMObject.cpp: |
- (WebCore): |
- (WebCore::checkTypeOrDieTrying): |
- (WebCore::V8TestActiveDOMObject::createWrapper): |
- * bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp: |
- (WebCore): |
- (WebCore::checkTypeOrDieTrying): |
- (WebCore::V8TestCustomNamedGetter::createWrapper): |
- * bindings/scripts/test/V8/V8TestEventConstructor.cpp: |
- (WebCore): |
- (WebCore::checkTypeOrDieTrying): |
- (WebCore::V8TestEventConstructor::createWrapper): |
- * bindings/scripts/test/V8/V8TestEventTarget.cpp: |
- (WebCore): |
- (WebCore::checkTypeOrDieTrying): |
- (WebCore::V8TestEventTarget::createWrapper): |
- * bindings/scripts/test/V8/V8TestException.cpp: |
- (WebCore): |
- (WebCore::checkTypeOrDieTrying): |
- (WebCore::V8TestException::createWrapper): |
- * bindings/scripts/test/V8/V8TestInterface.cpp: |
- (WebCore): |
- (WebCore::checkTypeOrDieTrying): |
- (WebCore::V8TestInterface::createWrapper): |
- * bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp: |
- (WebCore): |
- (WebCore::checkTypeOrDieTrying): |
- (WebCore::V8TestMediaQueryListListener::createWrapper): |
- * bindings/scripts/test/V8/V8TestNamedConstructor.cpp: |
- (WebCore): |
- (WebCore::checkTypeOrDieTrying): |
- (WebCore::V8TestNamedConstructor::createWrapper): |
- * bindings/scripts/test/V8/V8TestNode.cpp: |
- (WebCore): |
- (WebCore::checkTypeOrDieTrying): |
- (WebCore::V8TestNode::createWrapper): |
- * bindings/scripts/test/V8/V8TestObj.cpp: |
- (WebCore): |
- (WebCore::checkTypeOrDieTrying): |
- (WebCore::V8TestObj::createWrapper): |
- * bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp: |
- (WebCore): |
- (WebCore::checkTypeOrDieTrying): |
- (WebCore::V8TestOverloadedConstructors::createWrapper): |
- * bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp: |
- (WebCore): |
- (WebCore::checkTypeOrDieTrying): |
- (WebCore::V8TestSerializedScriptValueInterface::createWrapper): |
- |
-2013-01-29 Andrey Adaikin <aandrey@chromium.org> |
- |
- Web Inspector: [Canvas] support instrumenting canvases in iframes (backend side) |
- https://bugs.webkit.org/show_bug.cgi?id=107951 |
- |
- Reviewed by Pavel Feldman. |
- |
- Accept optional FrameId argument for captureFrame and startCapturing commands. |
- Add event to the protocol to inform about instrumented canvas context creation. |
- |
- * inspector/Inspector.json: |
- * inspector/InspectorCanvasAgent.cpp: |
- (WebCore::InspectorCanvasAgent::InspectorCanvasAgent): |
- (WebCore::InspectorCanvasAgent::hasUninstrumentedCanvases): |
- (WebCore::InspectorCanvasAgent::captureFrame): |
- (WebCore::InspectorCanvasAgent::startCapturing): |
- (WebCore::InspectorCanvasAgent::getTraceLog): |
- (WebCore::InspectorCanvasAgent::replayTraceLog): |
- (WebCore::InspectorCanvasAgent::getResourceInfo): |
- (WebCore::InspectorCanvasAgent::getResourceState): |
- (WebCore::InspectorCanvasAgent::wrapCanvas2DRenderingContextForInstrumentation): |
- (WebCore::InspectorCanvasAgent::wrapWebGLRenderingContextForInstrumentation): |
- (WebCore::InspectorCanvasAgent::notifyRenderingContextWasWrapped): |
- (WebCore): |
- (WebCore::InspectorCanvasAgent::findFramesWithUninstrumentedCanvases): |
- (WebCore::InspectorCanvasAgent::frameNavigated): |
- (WebCore::InspectorCanvasAgent::frameDetached): |
- * inspector/InspectorCanvasAgent.h: |
- (WebCore): |
- (WebCore::InspectorCanvasAgent::create): |
- (InspectorCanvasAgent): |
- * inspector/InspectorController.cpp: |
- (WebCore::InspectorController::InspectorController): |
- * inspector/InspectorInstrumentation.cpp: |
- (WebCore): |
- (WebCore::InspectorInstrumentation::frameDetachedFromParentImpl): |
- (WebCore::InspectorInstrumentation::didCommitLoadImpl): |
- |
-2013-01-29 Eugene Klyuchnikov <eustas@chromium.org> |
- |
- Web Inspector: [CPU Profile] Taking profile crashes renderer. |
- https://bugs.webkit.org/show_bug.cgi?id=108072 |
- |
- Reviewed by Yury Semikhatsky. |
- |
- Test: inspector/profiler/cpu-profiler-agent-crash-on-start.html |
- |
- Fixed null-pointer access. |
- |
- * bindings/v8/ScriptProfiler.cpp: |
- (WebCore::ScriptProfiler::start): Fixed null-pointer access. |
- (WebCore::ScriptProfiler::stop): Ditto. |
- |
-2013-01-29 Allan Sandfeld Jensen <allan.jensen@digia.com> |
- |
REGRESSION: ChildrenAffectedBy flags lost between siblings which have child elements sharing style |
https://bugs.webkit.org/show_bug.cgi?id=105672 |