Refactor app_list_util.h into AppListService abstract base.

chrome/browser/ui/app_list/app_list_service_cocoa.h

Index: chrome/browser/ui/app_list/app_list_service_cocoa.h
diff --git a/chrome/browser/ui/app_list/app_list_service_cocoa.h b/chrome/browser/ui/app_list/app_list_service_cocoa.h
new file mode 100644
index 0000000000000000000000000000000000000000..8a9fc0f53fce1e02e29b03dc4fd50394fdad5e8d
--- /dev/null
+++ b/chrome/browser/ui/app_list/app_list_service_cocoa.h
@@ -0,0 +1,21 @@
+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_UI_APP_LIST_APP_LIST_SERVICE_COCOA_H_

[tfarina, 2013/02/20 03:29:44]

what is this file doing here?

Can you move it to c/b/ui/cocoa/app_list/?

[tapted, 2013/02/20 04:15:07]

This one, technically yes. But not so for app_list_service_win.h. All three
{ash,cocoa,views} are included from
c/b/ui/app_list/app_list_service_selector.cc, which can not include things from
c/b/ui/views due to DEPS.

This arrangement is not ideal, but is a link in the chain to a bigger refactor.

+#define CHROME_BROWSER_UI_APP_LIST_APP_LIST_SERVICE_COCOA_H_
+
+#include "chrome/browser/ui/app_list/app_list_service.h"
+
+class AppListServiceCocoa : public AppListService {
+ public:
+  static AppListServiceCocoa* GetInstance();
+
+ protected:
+  AppListServiceCocoa() {}

[tfarina, 2013/02/20 03:29:44]

is this protected to disallow manual instantiation? can you make it private?

[tapted, 2013/02/20 04:15:07]

AppListControllerCocoa inherits from this, so needs a non-private constructor.

+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(AppListServiceCocoa);
+};
+
+#endif  // CHROME_BROWSER_UI_APP_LIST_APP_LIST_SERVICE_COCOA_H_