chrome/browser/ui/app_list/app_list_service_cocoa.h - Issue 12207104: Refactor app_list_util.h into AppListService abstract base.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/app_list/app_list_service_cocoa.h

Issue 12207104: Refactor app_list_util.h into AppListService abstract base. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: stray newline Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/ui/app_list/app_list_service.h ('K') | « chrome/browser/ui/app_list/app_list_service_ash.h ('k') | chrome/browser/ui/app_list/app_list_service_disabled.cc » ('j') | chrome/browser/ui/ash/app_list/app_list_service_ash.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2013 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_UI_APP_LIST_APP_LIST_SERVICE_COCOA_H_
	tfarina 2013/02/20 03:29:44 what is this file doing here? Can you move it to what is this file doing here? Can you move it to c/b/ui/cocoa/app_list/? tapted 2013/02/20 04:15:07 This one, technically yes. But not so for app_list Show quoted text On 2013/02/20 03:29:44, tfarina wrote: > what is this file doing here? > > Can you move it to c/b/ui/cocoa/app_list/? This one, technically yes. But not so for app_list_service_win.h. All three {ash,cocoa,views} are included from c/b/ui/app_list/app_list_service_selector.cc, which can not include things from c/b/ui/views due to DEPS. This arrangement is not ideal, but is a link in the chain to a bigger refactor.
	6 #define CHROME_BROWSER_UI_APP_LIST_APP_LIST_SERVICE_COCOA_H_

	7

	8 #include "chrome/browser/ui/app_list/app_list_service.h"

	9

	10 class AppListServiceCocoa : public AppListService {

	11 public:

	12 static AppListServiceCocoa* GetInstance();

	13

	14 protected:

	15 AppListServiceCocoa() {}
	tfarina 2013/02/20 03:29:44 is this protected to disallow manual instantiation is this protected to disallow manual instantiation? can you make it private? tapted 2013/02/20 04:15:07 AppListControllerCocoa inherits from this, so need Show quoted text On 2013/02/20 03:29:44, tfarina wrote: > is this protected to disallow manual instantiation? can you make it private? AppListControllerCocoa inherits from this, so needs a non-private constructor.
	16

	17 private:

	18 DISALLOW_COPY_AND_ASSIGN(AppListServiceCocoa);

	19 };

	20

	21 #endif // CHROME_BROWSER_UI_APP_LIST_APP_LIST_SERVICE_COCOA_H_

OLD	NEW