Refactor app_list_util.h into AppListService abstract base.

chrome/browser/ui/ash/app_list/app_list_service_ash.cc

Index: chrome/browser/ui/ash/app_list/app_list_service_ash.cc
diff --git a/chrome/browser/ui/ash/app_list/app_list_service_ash.cc b/chrome/browser/ui/ash/app_list/app_list_service_ash.cc
new file mode 100644
index 0000000000000000000000000000000000000000..6307b401aba25062602c9e9802960bdcb5ae9ea2
--- /dev/null
+++ b/chrome/browser/ui/ash/app_list/app_list_service_ash.cc
@@ -0,0 +1,53 @@
+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/ui/app_list/app_list_service_ash.h"
+
+#include "ash/shell.h"
+#include "base/memory/singleton.h"
+#include "chrome/browser/ui/app_list/app_list_service_ash.h"

[tapted, 2013/02/20 04:15:07]

oops - just noticed this is a dupe - removed.

+
+namespace {
+
+class AppListServiceAshImpl : public AppListServiceAsh {

[benwells, 2013/02/19 07:34:28]

Why have the impl class? It would be more transparent to have the ShowAppList
etc. on the AppListServiceAsh class in app_list_service_ash.h.

[tapted, 2013/02/20 04:15:07]

I went this route to minimise the cross-directory symbols (and also inspired by
your earlier comment:
https://codereview.chromium.org/12207104/diff/20/chrome/browser/ui/views/app_...
;-).

That is, in this form, there is just a static function with its declaration in
c/b/ui/app_list and the definition in c/b/ui/{ash,cocoa,views}/app_list . I see
merit in at least moving the overrides to the headers though.. Done for ash, but
re:

On 2013/02/19 07:34:28, benwells wrote:
not done for win & cocoa. For those, it wouldn't be enough just to push the
overrides up into app_list_service_foo.h -- implementing them at that level
wouldn't have access to necessary members in the leaf class. E.g. for cocoa,
we'd need the scoped_nsobject and an objective C @class forward declaration in
the header, requiring app_list_service_selector to be compiled as Objective C++.

+ public:
+  static AppListServiceAshImpl* GetInstance() {
+    return Singleton<AppListServiceAshImpl>::get();
+  }
+
+  // AppListService overrides:
+  virtual void ShowAppList(Profile* default_profile) OVERRIDE;
+  virtual bool IsAppListVisible() const OVERRIDE;
+  virtual void DismissAppList() OVERRIDE;
+
+ private:
+  AppListServiceAshImpl() {}
+
+  friend struct DefaultSingletonTraits<AppListServiceAshImpl>;
+
+  DISALLOW_COPY_AND_ASSIGN(AppListServiceAshImpl);
+};
+
+void AppListServiceAshImpl::ShowAppList(Profile* default_profile) {
+  // This may not work correctly if the profile passed in is different from the
+  // one the ash Shell is currently using.
+  // TODO(ananta): Handle profile changes correctly when !defined(OS_CHROMEOS).
+  if (!IsAppListVisible())
+    ash::Shell::GetInstance()->ToggleAppList(NULL);
+}
+
+bool AppListServiceAshImpl::IsAppListVisible() const {
+  return ash::Shell::GetInstance()->GetAppListTargetVisibility();
+}
+
+void AppListServiceAshImpl::DismissAppList() {
+  if (IsAppListVisible())
+    ash::Shell::GetInstance()->ToggleAppList(NULL);
+}
+
+}  // namespace
+
+AppListServiceAsh* AppListServiceAsh::GetInstance() {
+  return AppListServiceAshImpl::GetInstance();
+}