Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 1220443004: Revert of Revert of Fix CH Width header when preloadScanner and <picture> are involved (Closed)

Created:
5 years, 5 months ago by Noel Gordon
Modified:
5 years, 5 months ago
Reviewers:
Yoav Weiss, Mike West
CC:
blink-reviews, blink-reviews-html_chromium.org, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Revert of Fix CH Width header when preloadScanner and <picture> are involved (patchset #1 id:1 of https://codereview.chromium.org/1217703002/) Reason for revert: Wasn't the cause of build 7701 failure, was a bot flake. Original issue's description: > Revert of Fix CH Width header when preloadScanner and <picture> are involved (patchset #3 id:40001 of https://codereview.chromium.org/1214663004/) > > Reason for revert: > Seems to have broken the Mac10.9 Tests (dbg) on the chromium waterfall, see build #7701 > > > > Original issue's description: > > Fix CH Width header when preloadScanner and <picture> are involved > > > > When images are loaded by the preloader and <picture> is involved, > > there was a bug where the sent sizes value was related to the fallback > > <img> tag rather than the picked resource. > > This CL fixes that. > > > > BUG=458983 > > > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197948 > > TBR=mkwst@chromium.org,yoav@yoav.ws > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=458983 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197949 TBR=mkwst@chromium.org,yoav@yoav.ws NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=458983 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197950

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -15 lines) Patch
M Source/core/html/parser/HTMLPreloadScanner.h View 2 chunks +14 lines, -1 line 0 comments Download
M Source/core/html/parser/HTMLPreloadScanner.cpp View 3 chunks +24 lines, -14 lines 0 comments Download
M Source/core/html/parser/HTMLPreloadScannerTest.cpp View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Noel Gordon
Created Revert of Revert of Fix CH Width header when preloadScanner and <picture> are involved
5 years, 5 months ago (2015-06-28 18:25:09 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1220443004/1
5 years, 5 months ago (2015-06-28 18:25:15 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=197950
5 years, 5 months ago (2015-06-28 18:25:36 UTC) #3
Yoav Weiss
On 2015/06/28 18:25:36, commit-bot: I haz the power wrote: > Committed patchset #1 (id:1) as ...
5 years, 5 months ago (2015-06-28 18:27:05 UTC) #4
Noel Gordon
Just a bot flake by the looks.
5 years, 5 months ago (2015-06-28 18:28:56 UTC) #5
Noel Gordon
CH == Client Hints ?
5 years, 5 months ago (2015-06-28 18:47:36 UTC) #6
Yoav Weiss
5 years, 5 months ago (2015-06-28 18:49:09 UTC) #7
Message was sent while issue was closed.
Yeah, client hints
On Jun 28, 2015 20:47, <noel@chromium.org> wrote:

> CH == Client Hints ?
>
> https://codereview.chromium.org/1220443004/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698