Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(843)

Issue 1214663004: Fix CH Width header when preloadScanner and <picture> are involved (Closed)

Created:
5 years, 5 months ago by Yoav Weiss
Modified:
5 years, 5 months ago
Reviewers:
Mike West
CC:
blink-reviews, blink-reviews-html_chromium.org, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix CH Width header when preloadScanner and <picture> are involved When images are loaded by the preloader and <picture> is involved, there was a bug where the sent sizes value was related to the fallback <img> tag rather than the picked resource. This CL fixes that. BUG=458983 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197948

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : Fixed bug #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -12 lines) Patch
M Source/core/html/parser/HTMLPreloadScanner.h View 1 2 chunks +14 lines, -1 line 0 comments Download
M Source/core/html/parser/HTMLPreloadScanner.cpp View 1 2 3 chunks +21 lines, -11 lines 0 comments Download
M Source/core/html/parser/HTMLPreloadScannerTest.cpp View 1 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
Yoav Weiss
5 years, 5 months ago (2015-06-27 15:11:11 UTC) #2
Mike West
On 2015/06/27 at 15:11:11, yoav wrote: > Patch failure. ;)
5 years, 5 months ago (2015-06-27 15:11:51 UTC) #3
Mike West
LGTM once you fix the patch.
5 years, 5 months ago (2015-06-27 15:16:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1214663004/20001
5 years, 5 months ago (2015-06-27 15:22:38 UTC) #7
commit-bot: I haz the power
Exceeded global retry quota
5 years, 5 months ago (2015-06-27 15:55:32 UTC) #9
Mike West
On 2015/06/27 at 15:55:32, commit-bot wrote: > Exceeded global retry quota Failing: HTMLPreloadScannerTest.testImages HTMLPreloadScannerTest.testImagesWithViewport HTMLPreloadScannerTest.testImagesWithViewportDisabled ...
5 years, 5 months ago (2015-06-27 17:23:47 UTC) #10
Yoav Weiss
On 2015/06/27 17:23:47, Mike West wrote: > On 2015/06/27 at 15:55:32, commit-bot wrote: > > ...
5 years, 5 months ago (2015-06-28 05:06:56 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1214663004/40001
5 years, 5 months ago (2015-06-28 08:11:50 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://src.chromium.org/viewvc/blink?view=rev&revision=197948
5 years, 5 months ago (2015-06-28 08:50:25 UTC) #15
Noel Gordon
5 years, 5 months ago (2015-06-28 16:41:54 UTC) #16
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1217703002/ by noel@chromium.org.

The reason for reverting is: Seems to have broken the Mac10.9 Tests (dbg) on the
chromium waterfall, see build #7701

.

Powered by Google App Engine
This is Rietveld 408576698