Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 1217703002: Revert of Fix CH Width header when preloadScanner and <picture> are involved (Closed)

Created:
5 years, 5 months ago by Noel Gordon
Modified:
5 years, 5 months ago
Reviewers:
Yoav Weiss, Mike West
CC:
blink-reviews, blink-reviews-html_chromium.org, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Fix CH Width header when preloadScanner and <picture> are involved (patchset #3 id:40001 of https://codereview.chromium.org/1214663004/) Reason for revert: Seems to have broken the Mac10.9 Tests (dbg) on the chromium waterfall, see build #7701 Original issue's description: > Fix CH Width header when preloadScanner and <picture> are involved > > When images are loaded by the preloader and <picture> is involved, > there was a bug where the sent sizes value was related to the fallback > <img> tag rather than the picked resource. > This CL fixes that. > > BUG=458983 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197948 TBR=mkwst@chromium.org,yoav@yoav.ws NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=458983 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197949

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -52 lines) Patch
M Source/core/html/parser/HTMLPreloadScanner.h View 2 chunks +1 line, -14 lines 0 comments Download
M Source/core/html/parser/HTMLPreloadScanner.cpp View 3 chunks +14 lines, -24 lines 0 comments Download
M Source/core/html/parser/HTMLPreloadScannerTest.cpp View 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Noel Gordon
Created Revert of Fix CH Width header when preloadScanner and <picture> are involved
5 years, 5 months ago (2015-06-28 16:41:55 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1217703002/1
5 years, 5 months ago (2015-06-28 16:42:03 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=197949
5 years, 5 months ago (2015-06-28 16:42:24 UTC) #3
Yoav Weiss
On 2015/06/28 16:42:24, commit-bot: I haz the power wrote: > Committed patchset #1 (id:1) as ...
5 years, 5 months ago (2015-06-28 17:40:18 UTC) #4
Yoav Weiss
On 2015/06/28 17:40:18, Yoav Weiss wrote: > On 2015/06/28 16:42:24, commit-bot: I haz the power ...
5 years, 5 months ago (2015-06-28 17:46:20 UTC) #5
Noel Gordon
http://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/7701
5 years, 5 months ago (2015-06-28 18:13:02 UTC) #6
Noel Gordon
On 2015/06/28 18:13:02, noel gordon wrote: > http://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/7701 The bot has sine gone green and ...
5 years, 5 months ago (2015-06-28 18:14:13 UTC) #7
Noel Gordon
> so roll it back in? Yes, looking at subsequent builds, seems fine to do ...
5 years, 5 months ago (2015-06-28 18:24:11 UTC) #8
Noel Gordon
5 years, 5 months ago (2015-06-28 18:25:09 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1220443004/ by noel@chromium.org.

The reason for reverting is: Wasn't the cause of build 7701 failure, was a bot
flake..

Powered by Google App Engine
This is Rietveld 408576698