Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 1220053003: Disentangle filter content recording state from FilterData (Closed)

Created:
5 years, 5 months ago by fs
Modified:
5 years, 5 months ago
Reviewers:
Stephen Chennney, pdr.
CC:
blink-reviews, krit, pdr+renderingwatchlist_chromium.org, zoltan1, szager+layoutwatch_chromium.org, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, fs, blink-reviews-rendering, f(malita), slimming-paint-reviews_chromium.org, jchaffraix+rendering, blink-reviews-paint_chromium.org, dshwang, gyuyoung2, Stephen Chennney, rwlbuis, pdr+svgwatchlist_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Disentangle filter content recording state from FilterData In circumstances where an image is being painted, and said image is part of the source graphics for a filter - and the image is animated and needs to catch up - the FilterData for the filter can be destroyed while the source graphic is being recorded. While arguably this shouldn't happen at all, make sure that at least the GC we're currently painting on isn't destroyed by moving it to a separate structure housed by SVGPaintContext. BUG=505444 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198266

Patch Set 1 #

Patch Set 2 : Meh. #

Patch Set 3 : Should learn how this "compiler" thingy works... #

Patch Set 4 : Added test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -34 lines) Patch
A LayoutTests/svg/filters/filtered-animated-image-crash.html View 1 2 3 1 chunk +20 lines, -0 lines 0 comments Download
A + LayoutTests/svg/filters/filtered-animated-image-crash-expected.txt View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/core/layout/svg/LayoutSVGResourceFilter.h View 1 2 2 chunks +0 lines, -4 lines 0 comments Download
M Source/core/layout/svg/LayoutSVGResourceFilter.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/layout/svg/SVGLayoutSupport.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/paint/SVGFilterPainter.h View 1 2 1 chunk +22 lines, -3 lines 0 comments Download
M Source/core/paint/SVGFilterPainter.cpp View 1 2 6 chunks +25 lines, -20 lines 0 comments Download
M Source/core/paint/SVGPaintContext.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/paint/SVGPaintContext.cpp View 1 3 chunks +4 lines, -3 lines 0 comments Download
M Source/core/svg/SVGImageElement.h View 1 2 3 2 chunks +4 lines, -1 line 0 comments Download
M Source/core/testing/Internals.cpp View 1 2 3 2 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
fs
Maybe a tad ugly - could probably use some additional code shuffle - but that ...
5 years, 5 months ago (2015-07-02 15:12:07 UTC) #2
Stephen Chennney
LGTM
5 years, 5 months ago (2015-07-02 15:55:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1220053003/60001
5 years, 5 months ago (2015-07-03 07:58:03 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-07-03 08:02:29 UTC) #6
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198266

Powered by Google App Engine
This is Rietveld 408576698