|
Disentangle filter content recording state from FilterData
In circumstances where an image is being painted, and said image is part
of the source graphics for a filter - and the image is animated and
needs to catch up - the FilterData for the filter can be destroyed while
the source graphic is being recorded.
While arguably this shouldn't happen at all, make sure that at least the
GC we're currently painting on isn't destroyed by moving it to a
separate structure housed by SVGPaintContext.
BUG= 505444
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198266
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+84 lines, -34 lines) |
Patch |
|
A |
LayoutTests/svg/filters/filtered-animated-image-crash.html
|
View
|
1
2
3
|
1 chunk |
+20 lines, -0 lines |
0 comments
|
Download
|
|
A + |
LayoutTests/svg/filters/filtered-animated-image-crash-expected.txt
|
View
|
1
2
3
|
0 chunks |
+-1 lines, --1 lines |
0 comments
|
Download
|
|
M |
Source/core/layout/svg/LayoutSVGResourceFilter.h
|
View
|
1
2
|
2 chunks |
+0 lines, -4 lines |
0 comments
|
Download
|
|
M |
Source/core/layout/svg/LayoutSVGResourceFilter.cpp
|
View
|
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
|
M |
Source/core/layout/svg/SVGLayoutSupport.cpp
|
View
|
1
2
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
Source/core/paint/SVGFilterPainter.h
|
View
|
1
2
|
1 chunk |
+22 lines, -3 lines |
0 comments
|
Download
|
|
M |
Source/core/paint/SVGFilterPainter.cpp
|
View
|
1
2
|
6 chunks |
+25 lines, -20 lines |
0 comments
|
Download
|
|
M |
Source/core/paint/SVGPaintContext.h
|
View
|
1
|
2 chunks |
+2 lines, -0 lines |
0 comments
|
Download
|
|
M |
Source/core/paint/SVGPaintContext.cpp
|
View
|
1
|
3 chunks |
+4 lines, -3 lines |
0 comments
|
Download
|
|
M |
Source/core/svg/SVGImageElement.h
|
View
|
1
2
3
|
2 chunks |
+4 lines, -1 line |
0 comments
|
Download
|
|
M |
Source/core/testing/Internals.cpp
|
View
|
1
2
3
|
2 chunks |
+7 lines, -2 lines |
0 comments
|
Download
|
Total messages: 6 (2 generated)
|