Support for global var shortcuts in script contexts.

Support for global var shortcuts in script contexts.

Committed: https://crrev.com/8fe17a6780e763d4367b4aeaf44b6f572d4bdd70
Cr-Commit-Position: refs/heads/master@{#29498}

[Igor Sheludko, 2015-06-30 12:28:53]

Patchset #2 (id:20001) has been deleted

[Igor Sheludko, 2015-06-30 12:35:20]

Patchset #1 (id:1) has been deleted

[Igor Sheludko, 2015-06-30 12:41:27]

ishell@chromium.org changed reviewers:
+ verwaest@chromium.org

[Igor Sheludko, 2015-06-30 12:41:27]

PTAL

[Igor Sheludko, 2015-06-30 12:45:03]

Patchset #1 (id:40001) has been deleted

[Toon Verwaest, 2015-07-01 09:28:55]

https://codereview.chromium.org/1218783005/diff/60001/src/contexts.h
File src/contexts.h (right):

https://codereview.chromium.org/1218783005/diff/60001/src/contexts.h#newcode561
src/contexts.h:561: void InvalidateGlobalSlots();
InitializeGlobalSlots

https://codereview.chromium.org/1218783005/diff/60001/src/globals.h
File src/globals.h (right):

https://codereview.chromium.org/1218783005/diff/60001/src/globals.h#newcode886
src/globals.h:886: enum class ContextSlotKindFlag { kLocal, kGlobal };
What about changing Variable::Location to have a GLOBAL or so, rather than
having CONTEXT that is kLocal or kGlobal?

https://codereview.chromium.org/1218783005/diff/60001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/1218783005/diff/60001/src/objects.cc#newcode1809
src/objects.cc:1809: if (object->IsGlobalObject()) {
What case is this needed for?
Add a comment at least.

https://codereview.chromium.org/1218783005/diff/60001/src/runtime/runtime-deb...
File src/runtime/runtime-debug.cc (right):

https://codereview.chromium.org/1218783005/diff/60001/src/runtime/runtime-deb...
src/runtime/runtime-debug.cc:691: DCHECK(ContextSlotKindFlag::kLocal ==
slot_kind);
DCHECK_EQ
This may not be necessary anymore if you separate global from context in
Variable::Location

https://codereview.chromium.org/1218783005/diff/60001/src/runtime/runtime-sco...
File src/runtime/runtime-scopes.cc (right):

https://codereview.chromium.org/1218783005/diff/60001/src/runtime/runtime-sco...
src/runtime/runtime-scopes.cc:652: result->InvalidateGlobalSlots();
InitializeGlobalSlots

[Igor Sheludko, 2015-07-02 16:41:34]

Patchset #3 (id:100001) has been deleted

[Igor Sheludko, 2015-07-02 16:50:13]

There are some changes missing related to var->IsUnallocated() usages on non x64
achitectures...

https://codereview.chromium.org/1218783005/diff/60001/src/contexts.h
File src/contexts.h (right):

https://codereview.chromium.org/1218783005/diff/60001/src/contexts.h#newcode561
src/contexts.h:561: void InvalidateGlobalSlots();
On 2015/07/01 09:28:55, Toon Verwaest wrote:
> InitializeGlobalSlots

Done.

https://codereview.chromium.org/1218783005/diff/60001/src/globals.h
File src/globals.h (right):

https://codereview.chromium.org/1218783005/diff/60001/src/globals.h#newcode886
src/globals.h:886: enum class ContextSlotKindFlag { kLocal, kGlobal };
On 2015/07/01 09:28:55, Toon Verwaest wrote:
> What about changing Variable::Location to have a GLOBAL or so, rather than
> having CONTEXT that is kLocal or kGlobal?

Done.

https://codereview.chromium.org/1218783005/diff/60001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/1218783005/diff/60001/src/objects.cc#newcode1809
src/objects.cc:1809: if (object->IsGlobalObject()) {
On 2015/07/01 09:28:55, Toon Verwaest wrote:
> What case is this needed for?
> Add a comment at least.

Done.

https://codereview.chromium.org/1218783005/diff/60001/src/runtime/runtime-deb...
File src/runtime/runtime-debug.cc (right):

https://codereview.chromium.org/1218783005/diff/60001/src/runtime/runtime-deb...
src/runtime/runtime-debug.cc:691: DCHECK(ContextSlotKindFlag::kLocal ==
slot_kind);
On 2015/07/01 09:28:55, Toon Verwaest wrote:
> DCHECK_EQ
> This may not be necessary anymore if you separate global from context in
> Variable::Location

Done.

https://codereview.chromium.org/1218783005/diff/60001/src/runtime/runtime-sco...
File src/runtime/runtime-scopes.cc (right):

https://codereview.chromium.org/1218783005/diff/60001/src/runtime/runtime-sco...
src/runtime/runtime-scopes.cc:652: result->InvalidateGlobalSlots();
On 2015/07/01 09:28:55, Toon Verwaest wrote:
> InitializeGlobalSlots

Done.

[Igor Sheludko, 2015-07-02 17:05:16]

Patchset #3 (id:120001) has been deleted

[Toon Verwaest, 2015-07-06 14:59:49]

lgtm, but verify your ports ;)

[Igor Sheludko, 2015-07-06 15:02:55]

The CQ bit was checked by ishell@chromium.org

[commit-bot: I haz the power, 2015-07-06 15:03:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1218783005/200001

[commit-bot: I haz the power, 2015-07-06 15:04:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-06 15:04:28]

Try jobs failed on following builders:
  v8_linux64_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/7439)
  v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/7366)
  v8_linux_mips64el_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
  v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/build...)
  v8_linux_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel/builds/7324)
  v8_mac_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/7444)
  v8_win64_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel/builds/6393)

(exceeded global retry quota)

[Igor Sheludko, 2015-07-06 15:59:13]

The CQ bit was checked by ishell@chromium.org

[Igor Sheludko, 2015-07-06 15:59:14]

The patchset sent to the CQ was uploaded after l-g-t-m from
verwaest@chromium.org
Link to the patchset: https://codereview.chromium.org/1218783005/#ps240001
(title: "Fixing builds")

[commit-bot: I haz the power, 2015-07-06 15:59:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1218783005/240001

[commit-bot: I haz the power, 2015-07-06 16:36:35]

Committed patchset #8 (id:240001)

[commit-bot: I haz the power, 2015-07-06 16:36:45]

Patchset 8 (id:??) landed as
https://crrev.com/8fe17a6780e763d4367b4aeaf44b6f572d4bdd70
Cr-Commit-Position: refs/heads/master@{#29498}