src/typing.cc - Issue 1218783005: Support for global var shortcuts in script contexts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/typing.cc

Issue 1218783005: Support for global var shortcuts in script contexts. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fixing builds Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/typing.cc

diff --git a/src/typing.cc b/src/typing.cc

index 6f5cd1c6e0337b0ccaea2c07e67732c83e1eb678..2f10328f0978d70363e4809cc343613a02da5b57 100644

--- a/src/typing.cc

+++ b/src/typing.cc

@@ -105,7 +105,9 @@ void AstTyper::ObserveTypesAtOsrEntry(IterationStatement* stmt) {

ZoneList<Variable*> local_vars(locals, zone());

ZoneList<Variable*> context_vars(scope->ContextLocalCount(), zone());

- scope->CollectStackAndContextLocals(&local_vars, &context_vars);

+ ZoneList<Variable*> global_vars(scope->ContextGlobalCount(), zone());

+ scope->CollectStackAndContextLocals(&local_vars, &context_vars,

+ &global_vars);

for (int i = 0; i < locals; i++) {

PrintObserved(local_vars.at(i),

frame->GetExpression(i),

« no previous file with comments | « src/scopes.cc ('k') | src/variables.h » ('j') | no next file with comments »