Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 1218413002: Remove width calculation in `Width` hint (Closed)

Created:
5 years, 5 months ago by Yoav Weiss
Modified:
5 years, 5 months ago
Reviewers:
philipj_slow, Mike West
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove width calculation in `Width` hint Following the discussion on the CH Intent to ship, I'm removing the width attribute part of the `Width` calculation, to match it to the inputs we expose to srcset's selection algorithm. BUG=458983 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198304

Patch Set 1 #

Patch Set 2 : Removed widthAttr support in `Width` hint #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -62 lines) Patch
M LayoutTests/http/tests/misc/client-hints-accept.php View 1 1 chunk +1 line, -1 line 0 comments Download
D LayoutTests/http/tests/misc/client-hints-rw-width.html View 1 1 chunk +0 lines, -23 lines 0 comments Download
M Source/core/html/HTMLImageElement.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLImageElement.cpp View 1 1 chunk +0 lines, -15 lines 0 comments Download
M Source/core/html/HTMLImageElementTest.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/html/parser/HTMLPreloadScanner.cpp View 1 4 chunks +0 lines, -12 lines 0 comments Download
M Source/core/html/parser/HTMLPreloadScannerTest.cpp View 1 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
Yoav Weiss
5 years, 5 months ago (2015-07-03 21:21:41 UTC) #2
Yoav Weiss
Is there a way to add tests the mess around with the runtime flags? I'd ...
5 years, 5 months ago (2015-07-03 21:30:17 UTC) #3
philipj_slow
On 2015/07/03 21:30:17, Yoav Weiss wrote: > Is there a way to add tests the ...
5 years, 5 months ago (2015-07-03 22:00:52 UTC) #4
philipj_slow
This is so little code that perhaps just removing it and then adding it back ...
5 years, 5 months ago (2015-07-03 22:02:05 UTC) #5
Yoav Weiss
On 2015/07/03 22:02:05, philipj wrote: > This is so little code that perhaps just removing ...
5 years, 5 months ago (2015-07-06 05:58:29 UTC) #6
philipj_slow
lgtm
5 years, 5 months ago (2015-07-06 07:08:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1218413002/20001
5 years, 5 months ago (2015-07-06 07:10:40 UTC) #9
commit-bot: I haz the power
5 years, 5 months ago (2015-07-06 07:14:21 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198304

Powered by Google App Engine
This is Rietveld 408576698