Source/core/html/HTMLImageElementTest.cpp - Issue 1218413002: Remove width calculation in `Width` hint

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLImageElementTest.cpp

Issue 1218413002: Remove width calculation in `Width` hint (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Removed widthAttr support in `Width` hint Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/HTMLImageElementTest.cpp

diff --git a/Source/core/html/HTMLImageElementTest.cpp b/Source/core/html/HTMLImageElementTest.cpp

index 442f08c3fddd4ba2b411dc30993bd7a1a1fd1c68..d453af740f54db8bc9ec8d61fc1b94e3dbf747d4 100644

--- a/Source/core/html/HTMLImageElementTest.cpp

+++ b/Source/core/html/HTMLImageElementTest.cpp

@@ -28,7 +28,8 @@ TEST_F(HTMLImageElementTest, width)

{

RefPtrWillBeRawPtr<HTMLImageElement> image = HTMLImageElement::create(m_dummyPageHolder->document(), nullptr, /* createdByParser */ false);

image->setAttribute(HTMLNames::widthAttr, "400");

- EXPECT_EQ(400, image->resourceWidth().width);

+ // TODO(yoav): `width` does not impact resourceWidth until we resolve https://github.com/ResponsiveImagesCG/picture-element/issues/268

+ EXPECT_EQ(500, image->resourceWidth().width);

image->setAttribute(HTMLNames::sizesAttr, "100vw");

EXPECT_EQ(500, image->resourceWidth().width);

}