Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1031)

Issue 1217983003: Allow animation of non-interpolable properties in CSS Animations (Closed)

Created:
5 years, 5 months ago by alancutter (OOO until 2018)
Modified:
5 years, 5 months ago
Reviewers:
dstockwell, shans
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, Eric Willigers, rjwright, shans
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Allow animation of non-interpolable properties in CSS Animations This change adds support to CSS Animations for properties that aren't interpolable. http://dev.w3.org/csswg/css-transitions/#animatable-properties Previously properties like "position" were ignored in @keyframes rules and wouldn't apply. With this change they will start applying their values during the CSS animation. BUG=505754 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198175

Patch Set 1 #

Patch Set 2 : Update CSSProperties.in comment #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -60 lines) Patch
A LayoutTests/animations/interpolation/float-interpolation.html View 1 chunk +16 lines, -0 lines 0 comments Download
D LayoutTests/animations/interpolation/non-animatable-interpolation.html View 1 chunk +0 lines, -50 lines 0 comments Download
M LayoutTests/animations/interpolation/position-interpolation.html View 1 chunk +15 lines, -2 lines 0 comments Download
M Source/core/animation/CSSValueInterpolationType.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M Source/core/animation/css/CSSAnimations.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/css/CSSProperties.in View 1 1 chunk +4 lines, -4 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 6 (2 generated)
alancutter (OOO until 2018)
5 years, 5 months ago (2015-06-30 09:35:06 UTC) #2
dstockwell
lgtm
5 years, 5 months ago (2015-07-02 00:26:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1217983003/40001
5 years, 5 months ago (2015-07-02 00:31:40 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-07-02 01:45:31 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198175

Powered by Google App Engine
This is Rietveld 408576698