Source/core/animation/CSSValueInterpolationType.cpp - Issue 1217983003: Allow animation of non-interpolable properties in CSS Animations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/animation/CSSValueInterpolationType.cpp

Issue 1217983003: Allow animation of non-interpolable properties in CSS Animations (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebased Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/animation/CSSValueInterpolationType.cpp

diff --git a/Source/core/animation/CSSValueInterpolationType.cpp b/Source/core/animation/CSSValueInterpolationType.cpp

index 6684226ec1d40e439375be1225e176d807a9fd8f..bf765d5cb710155cf456f7e6992b24d513c41ce4 100644

--- a/Source/core/animation/CSSValueInterpolationType.cpp

+++ b/Source/core/animation/CSSValueInterpolationType.cpp

@@ -16,7 +16,9 @@ PassOwnPtrWillBeRawPtr<InterpolationValue> CSSValueInterpolationType::maybeConve

void CSSValueInterpolationType::apply(const InterpolableValue&, const NonInterpolableValue* nonInterpolableValue, StyleResolverState& state) const

{

- StyleBuilder::applyProperty(m_property, state, toDefaultNonInterpolableValue(nonInterpolableValue)->cssValue());

+ CSSValue* value = toDefaultNonInterpolableValue(nonInterpolableValue)->cssValue();

+ if (value)

+ StyleBuilder::applyProperty(m_property, state, value);

}

DEFINE_NON_INTERPOLABLE_VALUE_TYPE(DefaultNonInterpolableValue);