Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 1213063004: Rename animatable to interpolable in CSSProperties.in (Closed)

Created:
5 years, 5 months ago by alancutter (OOO until 2018)
Modified:
5 years, 5 months ago
Reviewers:
dstockwell, Timothy Loh
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-css, blink-reviews-style_chromium.org, dglazkov+blink, Eric Willigers, rjwright, rwlbuis, shans
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Rename animatable to interpolable in CSSProperties.in This change renames isAnimatableProperty() to isInterpolableProperty() and renames isAllowedAnimation() to isAnimatableProperty(). This is to avoid confusion about whether a property can be animated versus whether it will interpolate smoothly when animated and to bring our implementation closer to a recent working group decision regarding the name "animatable" for CSS properties: https://lists.w3.org/Archives/Public/www-style/2015May/0256.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198130

Patch Set 1 #

Patch Set 2 : Update comment #

Total comments: 2

Patch Set 3 : Add TODO #

Patch Set 4 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -141 lines) Patch
M Source/build/scripts/css_properties.py View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/build/scripts/make_css_property_metadata.py View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/StringKeyframe.cpp View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/animation/css/CSSAnimatableValueFactory.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/css/CSSAnimations.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/css/CSSAnimations.cpp View 1 2 4 chunks +8 lines, -6 lines 0 comments Download
M Source/core/css/CSSProperties.in View 10 chunks +123 lines, -123 lines 0 comments Download
M Source/core/css/CSSPropertyMetadata.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/resolver/AnimatedStyleBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 14 (6 generated)
alancutter (OOO until 2018)
5 years, 5 months ago (2015-06-30 02:40:13 UTC) #2
Timothy Loh
https://codereview.chromium.org/1213063004/diff/20001/Source/core/css/CSSProperties.in File Source/core/css/CSSProperties.in (right): https://codereview.chromium.org/1213063004/diff/20001/Source/core/css/CSSProperties.in#newcode23 Source/core/css/CSSProperties.in:23: // The interpolable flag indicates whether a property can ...
5 years, 5 months ago (2015-06-30 05:48:19 UTC) #3
Timothy Loh
lgtm
5 years, 5 months ago (2015-06-30 05:48:24 UTC) #4
alancutter (OOO until 2018)
https://codereview.chromium.org/1213063004/diff/20001/Source/core/css/CSSProperties.in File Source/core/css/CSSProperties.in (right): https://codereview.chromium.org/1213063004/diff/20001/Source/core/css/CSSProperties.in#newcode23 Source/core/css/CSSProperties.in:23: // The interpolable flag indicates whether a property can ...
5 years, 5 months ago (2015-06-30 06:04:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1213063004/40001
5 years, 5 months ago (2015-07-01 04:59:01 UTC) #8
commit-bot: I haz the power
Exceeded global retry quota
5 years, 5 months ago (2015-07-01 05:01:44 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1213063004/60001
5 years, 5 months ago (2015-07-01 09:41:24 UTC) #13
commit-bot: I haz the power
5 years, 5 months ago (2015-07-01 10:43:43 UTC) #14
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198130

Powered by Google App Engine
This is Rietveld 408576698