Vector ICs: Introduce an InstanceType for the type feedback vector.

Vector ICs: Introduce an InstanceType for the type feedback vector.

For better validation, printing, and other future enhancements.
Printouts look like this:

DebugPrint: 0x5dc0d2ad: [TypeFeedbackVector]
 - length: 12
 - ics with type info: 3
 - generic ics: 0
 ICSlot 0 CALL_IC MONOMORPHIC
  [4]: 0x5dc0d365 WeakCell for 0x5dc0cd69 <JS Function foo (SharedFunctionInfo 0x5dc0cb0d)>
  [5]: 0x4203c4c1 <Code: HANDLER>
 ICSlot 1 LOAD_IC MONOMORPHIC
  [6]: 0x5dc0d1f5 WeakCell for 0x3a710481 <Map(FAST_HOLEY_SMI_ELEMENTS)>
  [7]: 0x4203a1c1 <Code: HANDLER>
 ICSlot 2 LOAD_IC UNINITIALIZED
  [8]: 0x3060d045 <Symbol: 711234650 <String[20]: uninitialized_symbol>>
  [9]: 0x3060d045 <Symbol: 711234650 <String[20]: uninitialized_symbol>>
 ICSlot 3 LOAD_IC MONOMORPHIC
  [10]: 0x5dc0d3b5 WeakCell for 0x3a710d71 <Map(FAST_HOLEY_ELEMENTS)>
  [11]: 0x4202af01 <Code: HANDLER>


* DECIDED NOT TO DO THIS *

BUG=

[mvstanton, 2015-06-30 09:02:29]

mvstanton@chromium.org changed reviewers:
+ bmeurer@chromium.org, hpayer@chromium.org

[mvstanton, 2015-06-30 09:03:00]

Hi Benedikt, hi Hannes,

Benedikt, could you review the CL generally, and Hannes, the heap changes
specifically?
Thanks yall,
--Michael

[Benedikt Meurer, 2015-06-30 09:43:44]

LGTM with nit. Nice!

https://codereview.chromium.org/1217943004/diff/20001/src/type-feedback-vector.h
File src/type-feedback-vector.h (right):

https://codereview.chromium.org/1217943004/diff/20001/src/type-feedback-vecto...
src/type-feedback-vector.h:12: // #include "src/heap/heap.h"
Nit: Nuke unused includes. No need to leave them as comments.

[Hannes Payer (out of office), 2015-06-30 13:59:11]

https://codereview.chromium.org/1217943004/diff/20001/src/heap/heap.cc
File src/heap/heap.cc (right):

https://codereview.chromium.org/1217943004/diff/20001/src/heap/heap.cc#newcod...
src/heap/heap.cc:4726: // object = EnsureDoubleAligned(this, object, size);
Do you have to double align the type feedback vector?

[Hannes Payer (out of office), 2015-06-30 14:54:31]

lgtm when line is removed

[mvstanton, 2015-06-30 14:58:16]

The CQ bit was checked by mvstanton@chromium.org

[mvstanton, 2015-06-30 14:58:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
bmeurer@chromium.org, hpayer@chromium.org
Link to the patchset: https://codereview.chromium.org/1217943004/#ps40001
(title: "Code comments.")

[commit-bot: I haz the power, 2015-06-30 14:58:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1217943004/40001

[mvstanton, 2015-06-30 15:00:46]

Okay, thanks! Landing...

https://codereview.chromium.org/1217943004/diff/20001/src/heap/heap.cc
File src/heap/heap.cc (right):

https://codereview.chromium.org/1217943004/diff/20001/src/heap/heap.cc#newcod...
src/heap/heap.cc:4726: // object = EnsureDoubleAligned(this, object, size);
On 2015/06/30 13:59:11, Hannes Payer wrote:
> Do you have to double align the type feedback vector?

Nope. Removed comment, thx.

https://codereview.chromium.org/1217943004/diff/20001/src/type-feedback-vector.h
File src/type-feedback-vector.h (right):

https://codereview.chromium.org/1217943004/diff/20001/src/type-feedback-vecto...
src/type-feedback-vector.h:12: // #include "src/heap/heap.h"
On 2015/06/30 09:43:43, Benedikt Meurer wrote:
> Nit: Nuke unused includes. No need to leave them as comments.

Done.

[commit-bot: I haz the power, 2015-06-30 15:06:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-30 15:06:18]

Try jobs failed on following builders:
  v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/build...)

[Hannes Payer (out of office), 2015-07-01 09:30:40]

https://codereview.chromium.org/1217943004/diff/60001/src/objects.h
File src/objects.h (right):

https://codereview.chromium.org/1217943004/diff/60001/src/objects.h#newcode75
src/objects.h:75: //       - ByteArray
Add your type here.

[Hannes Payer (out of office), 2015-07-01 09:44:36]

https://codereview.chromium.org/1217943004/diff/60001/src/runtime/runtime-arr...
File src/runtime/runtime-array.cc (right):

https://codereview.chromium.org/1217943004/diff/60001/src/runtime/runtime-arr...
src/runtime/runtime-array.cc:64: return
TypeFeedbackVector::cast(object)->get(index);
The type feedback vector should actually have to separate assessors to avoid the
ugly conditionals.