Vector ICs: Introduce an InstanceType for the type feedback vector.

src/heap/heap.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/v8.h"
 
 #include "src/accessors.h"
 #include "src/api.h"
 #include "src/base/bits.h"
 #include "src/base/once.h"
@@ skipping 2786 matching lines @@
 #define ALLOCATE_PARTIAL_MAP(instance_type, size, field_name)                \
   {                                                                          \
     Map* map;                                                                \
     if (!AllocatePartialMap((instance_type), (size)).To(&map)) return false; \
     set_##field_name##_map(map);                                             \
   }
 
     ALLOCATE_PARTIAL_MAP(FIXED_ARRAY_TYPE, kVariableSizeSentinel, fixed_array);
     ALLOCATE_PARTIAL_MAP(ODDBALL_TYPE, Oddball::kSize, undefined);
     ALLOCATE_PARTIAL_MAP(ODDBALL_TYPE, Oddball::kSize, null);
+    ALLOCATE_PARTIAL_MAP(FEEDBACK_VECTOR_TYPE, kVariableSizeSentinel,
+                         feedback_vector);
 
 #undef ALLOCATE_PARTIAL_MAP
   }
 
   // Allocate the empty array.
   {
     AllocationResult allocation = AllocateEmptyFixedArray();
     if (!allocation.To(&obj)) return false;
   }
   set_empty_fixed_array(FixedArray::cast(obj));
 
+  // Allocate the empty feedback vector.
+  {
+    AllocationResult allocation = AllocateEmptyFeedbackVector();
+    if (!allocation.To(&obj)) return false;
+  }
+  set_empty_feedback_vector(TypeFeedbackVector::cast(obj));
+
   {
     AllocationResult allocation = Allocate(null_map(), OLD_SPACE);
     if (!allocation.To(&obj)) return false;
   }
   set_null_value(Oddball::cast(obj));
   Oddball::cast(obj)->set_kind(Oddball::kNull);
 
   {
     AllocationResult allocation = Allocate(undefined_map(), OLD_SPACE);
     if (!allocation.To(&obj)) return false;
@@ skipping 41 matching lines @@
   }
 
   null_map()->set_code_cache(empty_fixed_array());
   null_map()->set_dependent_code(DependentCode::cast(empty_fixed_array()));
   null_map()->set_raw_transitions(Smi::FromInt(0));
   null_map()->set_instance_descriptors(empty_descriptor_array());
   if (FLAG_unbox_double_fields) {
     null_map()->set_layout_descriptor(LayoutDescriptor::FastPointerLayout());
   }
 
+  feedback_vector_map()->set_code_cache(empty_fixed_array());
+  feedback_vector_map()->set_dependent_code(
+      DependentCode::cast(empty_fixed_array()));
+  feedback_vector_map()->set_raw_transitions(Smi::FromInt(0));
+  feedback_vector_map()->set_instance_descriptors(empty_descriptor_array());
+  if (FLAG_unbox_double_fields) {
+    feedback_vector_map()->set_layout_descriptor(
+        LayoutDescriptor::FastPointerLayout());
+  }
+
   // Fix prototype object for existing maps.
   meta_map()->set_prototype(null_value());
   meta_map()->set_constructor_or_backpointer(null_value());
 
   fixed_array_map()->set_prototype(null_value());
   fixed_array_map()->set_constructor_or_backpointer(null_value());
 
   undefined_map()->set_prototype(null_value());
   undefined_map()->set_constructor_or_backpointer(null_value());
 
   null_map()->set_prototype(null_value());
   null_map()->set_constructor_or_backpointer(null_value());
 
+  feedback_vector_map()->set_prototype(null_value());
+  feedback_vector_map()->set_constructor_or_backpointer(null_value());
+
   {  // Map allocation
 #define ALLOCATE_MAP(instance_type, size, field_name)               \
   {                                                                 \
     Map* map;                                                       \
     if (!AllocateMap((instance_type), size).To(&map)) return false; \
     set_##field_name##_map(map);                                    \
   }
 
 #define ALLOCATE_VARSIZE_MAP(instance_type, field_name) \
   ALLOCATE_MAP(instance_type, kVariableSizeSentinel, field_name)
@@ skipping 1564 matching lines @@
     AllocationResult allocation = AllocateRaw(size, OLD_SPACE, OLD_SPACE);
     if (!allocation.To(&result)) return allocation;
   }
   // Initialize the object.
   result->set_map_no_write_barrier(fixed_array_map());
   FixedArray::cast(result)->set_length(0);
   return result;
 }
 
 
+AllocationResult Heap::AllocateEmptyFeedbackVector() {
+  FeedbackVectorSpec empty_spec;
+  int size = TypeFeedbackVector::SizeFor(&empty_spec);
+  HeapObject* result;
+  {
+    AllocationResult allocation = AllocateRaw(size, OLD_SPACE, OLD_SPACE);
+    if (!allocation.To(&result)) return allocation;
+  }
+  // Initialize the object.
+  result->set_map_no_write_barrier(feedback_vector_map());
+  TypeFeedbackVector::cast(result)->set_length(0);
+  return result;
+}
+
+
 AllocationResult Heap::AllocateEmptyExternalArray(
     ExternalArrayType array_type) {
   return AllocateExternalArray(0, array_type, NULL, TENURED);
 }
 
 
 AllocationResult Heap::CopyAndTenureFixedCOWArray(FixedArray* src) {
   if (!InNewSpace(src)) {
     return src;
   }
@@ skipping 61 matching lines @@
     if (!allocation.To(&obj)) return allocation;
   }
   obj->set_map_no_write_barrier(map);
   CopyBlock(obj->address() + FixedDoubleArray::kLengthOffset,
             src->address() + FixedDoubleArray::kLengthOffset,
             FixedDoubleArray::SizeFor(len) - FixedDoubleArray::kLengthOffset);
   return obj;
 }
 
 
+AllocationResult Heap::CopyTypeFeedbackVectorWithMap(TypeFeedbackVector* src,
+                                                     Map* map) {
+  int len = src->length();
+  int size = len * kPointerSize + TypeFeedbackVector::kHeaderSize;
+  if (len == 0) {
+    return empty_feedback_vector();
+  }
+
+  AllocationSpace space = SelectSpace(size, TENURED);
+  HeapObject* obj;
+  {
+    AllocationResult allocation = AllocateRaw(size, space, OLD_SPACE);
+    if (!allocation.To(&obj)) return allocation;
+  }
+  obj->set_map_no_write_barrier(map);
+  TypeFeedbackVector* result = TypeFeedbackVector::cast(obj);
+  result->set_length(len);
+
+  // Copy the content
+  DisallowHeapAllocation no_gc;
+  WriteBarrierMode mode = result->GetWriteBarrierMode(no_gc);
+  for (int i = 0; i < len; i++) result->set(i, src->get(i), mode);
+  return result;
+}
+
+
 AllocationResult Heap::AllocateRawFixedArray(int length,
                                              PretenureFlag pretenure) {
   if (length < 0 || length > FixedArray::kMaxLength) {
     v8::internal::Heap::FatalProcessOutOfMemory("invalid array length", true);
   }
   int size = FixedArray::SizeFor(length);
   AllocationSpace space = SelectSpace(size, pretenure);
 
   return AllocateRaw(size, space, OLD_SPACE);
 }
@@ skipping 68 matching lines @@
   {
     AllocationResult allocation =
         AllocateRaw(size, space, OLD_SPACE, kDoubleAligned);
     if (!allocation.To(&object)) return allocation;
   }
 
   return object;
 }
 
 
+template AllocationResult Heap::AllocateTypeFeedbackVector(
+    const ZoneFeedbackVectorSpec* spec);
+template AllocationResult Heap::AllocateTypeFeedbackVector(
+    const FeedbackVectorSpec* spec);
+
+template <typename Spec>
+AllocationResult Heap::AllocateTypeFeedbackVector(const Spec* spec) {
+  int size = TypeFeedbackVector::SizeFor(spec);
+  if (size == TypeFeedbackVector::kHeaderSize) {
+    return empty_feedback_vector();
+  }
+  AllocationSpace space = SelectSpace(size, TENURED);
+
+  HeapObject* object;
+  {
+    AllocationResult allocation = AllocateRaw(size, space, OLD_SPACE);
+    if (!allocation.To(&object)) return allocation;
+  }
+  // object = EnsureDoubleAligned(this, object, size);

[Hannes Payer (out of office), 2015/06/30 13:59:11]

Do you have to double align the type feedback vector?

[mvstanton, 2015/06/30 15:00:46]

Nope. Removed comment, thx.

+  object->set_map_no_write_barrier(feedback_vector_map());
+
+  TypeFeedbackVector* vector = TypeFeedbackVector::cast(object);
+  vector->Init(isolate(), spec);
+  return vector;
+}
+
+
 AllocationResult Heap::AllocateSymbol() {
   // Statically ensure that it is safe to allocate symbols in paged spaces.
   STATIC_ASSERT(Symbol::kSize <= Page::kMaxRegularHeapObjectSize);
 
   HeapObject* result = NULL;
   AllocationResult allocation =
       AllocateRaw(Symbol::kSize, OLD_SPACE, OLD_SPACE);
   if (!allocation.To(&result)) return allocation;
 
   result->set_map_no_write_barrier(symbol_map());
@@ skipping 2193 matching lines @@
     *object_type = "CODE_TYPE";                                                \
     *object_sub_type = "CODE_AGE/" #name;                                      \
     return true;
     CODE_AGE_LIST_COMPLETE(COMPARE_AND_RETURN_NAME)
 #undef COMPARE_AND_RETURN_NAME
   }
   return false;
 }
 }  // namespace internal
 }  // namespace v8