Vector ICs: Introduce an InstanceType for the type feedback vector.

src/type-feedback-vector.h

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_TYPE_FEEDBACK_VECTOR_H_
 #define V8_TYPE_FEEDBACK_VECTOR_H_
 
 #include <vector>
 
 #include "src/checks.h"
 #include "src/elements-kind.h"
-#include "src/heap/heap.h"
+// #include "src/heap/heap.h"

[Benedikt Meurer, 2015/06/30 09:43:43]

Nit: Nuke unused includes. No need to leave them as comments.

[mvstanton, 2015/06/30 15:00:46]

Done.

 #include "src/isolate.h"
 #include "src/objects.h"
 #include "src/zone-containers.h"
 
 namespace v8 {
 namespace internal {
 
 class FeedbackVectorSpec {
  public:
   FeedbackVectorSpec() : slots_(0), has_ic_slot_(false) {}
@@ skipping 156 matching lines @@
   Object* Get(FeedbackVectorICSlot slot) const { return get(GetIndex(slot)); }
   void Set(FeedbackVectorICSlot slot, Object* value,
            WriteBarrierMode mode = UPDATE_WRITE_BARRIER) {
     set(GetIndex(slot), value, mode);
   }
 
   // IC slots need metadata to recognize the type of IC.
   Code::Kind GetKind(FeedbackVectorICSlot slot) const;
 
   template <typename Spec>
-  static Handle<TypeFeedbackVector> Allocate(Isolate* isolate,
-                                             const Spec* spec);
+  static int SizeFor(const Spec* spec);
+
+  template <typename Spec>
+  void Init(Isolate* isolate, const Spec* spec);
 
   static Handle<TypeFeedbackVector> Copy(Isolate* isolate,
                                          Handle<TypeFeedbackVector> vector);
 
+  DECLARE_PRINTER(TypeFeedbackVector)
+
+  // TODO(Mvstanton): why doesn't this macro work?
+  // DECLARE_VERIFIER(TypeFeedbackVector)
+  void TypeFeedbackVectorVerify();
+
   // Clears the vector slots and the vector ic slots.
   void ClearSlots(SharedFunctionInfo* shared) { ClearSlotsImpl(shared, true); }
   void ClearSlotsAtGCTime(SharedFunctionInfo* shared) {
     ClearSlotsImpl(shared, false);
   }
 
   void ClearICSlots(SharedFunctionInfo* shared) {
     ClearICSlotsImpl(shared, true);
   }
   void ClearICSlotsAtGCTime(SharedFunctionInfo* shared) {
@@ skipping 212 matching lines @@
   void ConfigurePolymorphic(Handle<Name> name, MapHandleList* maps,
                             CodeHandleList* handlers);
 
   InlineCacheState StateFromFeedback() const override;
   Name* FindFirstName() const override;
 };
 }
 }  // namespace v8::internal
 
 #endif  // V8_TRANSITIONS_H_