Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1216863004: [DevTools] Move debugger classes to core/inspector. (Closed)

Created:
5 years, 5 months ago by dgozman
Modified:
5 years, 5 months ago
Reviewers:
yurys, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, arv+blink, vivekg_samsung, vivekg, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, blink-reviews-bindings_chromium.org, devtools-reviews_chromium.org, apavlov+blink_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[DevTools] Move debugger classes to core/inspector. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198333

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1354 lines) Patch
D Source/bindings/core/v8/MainThreadDebugger.h View 1 chunk +0 lines, -94 lines 0 comments Download
D Source/bindings/core/v8/MainThreadDebugger.cpp View 1 chunk +0 lines, -178 lines 0 comments Download
D Source/bindings/core/v8/V8Debugger.h View 1 chunk +0 lines, -166 lines 0 comments Download
D Source/bindings/core/v8/V8Debugger.cpp View 1 chunk +0 lines, -714 lines 0 comments Download
M Source/bindings/core/v8/WorkerScriptController.cpp View 1 chunk +1 line, -1 line 0 comments Download
D Source/bindings/core/v8/WorkerThreadDebugger.h View 1 chunk +0 lines, -74 lines 0 comments Download
D Source/bindings/core/v8/WorkerThreadDebugger.cpp View 1 chunk +0 lines, -110 lines 0 comments Download
M Source/bindings/core/v8/inspector/V8InjectedScriptHost.cpp View 2 chunks +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/v8.gypi View 3 chunks +0 lines, -6 lines 0 comments Download
M Source/core/core.gypi View 3 chunks +6 lines, -0 lines 0 comments Download
M Source/core/inspector/InjectedScriptHost.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorDebuggerAgent.cpp View 2 chunks +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorRuntimeAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/inspector/MainThreadDebugger.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/core/inspector/MainThreadDebugger.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/PageDebuggerAgent.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/inspector/PageDebuggerAgent.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/inspector/PageRuntimeAgent.cpp View 2 chunks +1 line, -1 line 0 comments Download
M Source/core/inspector/ScriptDebuggerBase.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/inspector/V8Debugger.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/core/inspector/V8Debugger.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/WorkerDebuggerAgent.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/inspector/WorkerInspectorController.cpp View 2 chunks +1 line, -1 line 0 comments Download
A + Source/core/inspector/WorkerThreadDebugger.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/core/inspector/WorkerThreadDebugger.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebDevToolsAgentImpl.cpp View 2 chunks +1 line, -1 line 0 comments Download

Dependent Patchsets:

Issue 1217773007 Patch 1
Issue 1217773007 Patch 20001

Messages

Total messages: 7 (2 generated)
dgozman
Take a look please.
5 years, 5 months ago (2015-07-06 16:10:06 UTC) #2
pfeldman
lgtm
5 years, 5 months ago (2015-07-06 17:25:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1216863004/1
5 years, 5 months ago (2015-07-06 17:25:52 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=198333
5 years, 5 months ago (2015-07-06 19:26:55 UTC) #6
yurys
5 years, 5 months ago (2015-07-07 06:24:26 UTC) #7
Message was sent while issue was closed. 
DebuggerScript.js should also have been moved under core/inspector along with
V8Debugger.

Powered by Google App Engine
This is Rietveld 408576698