Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Issue 121773003: Makes Window::Init take a WindowLayerType instead of LayerType. (Closed)

Created:
6 years, 11 months ago by sky
Modified:
6 years, 11 months ago
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, dcheng, sievers+watch_chromium.org, yukishiino+watch_chromium.org, ben+aura_chromium.org, miu+watch_chromium.org, joi+watch-content_chromium.org, jam, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, fischman+watch_chromium.org, penghuang+watch_chromium.org, feature-media-reviews_chromium.org, piman+watch_chromium.org, ben+views_chromium.org, tfarina, mcasas+watch_chromium.org, ben+corewm_chromium.org, danakj+watch_chromium.org, James Su, wjia+watch_chromium.org, ben+ash_chromium.org
Visibility:
Public.

Description

Makes Window::Init take a WindowLayerType instead of LayerType. BUG=none TEST=none R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243656

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : merge to master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+567 lines, -159 lines) Patch
M ash/display/mirror_window_controller.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/display/screen_position_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/drag_drop/drag_drop_tracker.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/root_window_controller.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M ash/root_window_controller_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/shelf/shelf_layout_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shell/keyboard_controller_proxy_stub.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shell_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/test/ash_test_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/dock/docked_window_resizer_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/drag_window_resizer_unittest.cc View 1 2 3 chunks +7 lines, -7 lines 0 comments Download
A ash/wm/solo_window_tracker_unittest.cc View 1 2 1 chunk +429 lines, -0 lines 0 comments Download
M ash/wm/stacking_controller_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/toplevel_window_event_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/multi_window_resize_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/workspace_event_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/workspace_layout_manager_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/workspace_window_resizer_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M ash/wm/workspace_controller_unittest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/media/desktop_capture_device_aura_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/aura/window_slider_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_view_aura.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/web_contents/web_contents_view_aura_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/examples/aura_demo/aura_demo.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M ui/aura/demo/demo_main.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/aura/test/aura_test_base.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/test/test_windows.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/window.h View 1 2 2 chunks +1 line, -5 lines 0 comments Download
M ui/aura/window.cc View 1 2 2 chunks +1 line, -18 lines 0 comments Download
M ui/aura/window_tree_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/window_unittest.cc View 1 2 22 chunks +57 lines, -57 lines 0 comments Download
M ui/keyboard/keyboard_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/keyboard/keyboard_controller_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/corewm/shadow_controller_unittest.cc View 1 2 8 chunks +8 lines, -8 lines 0 comments Download
M ui/views/corewm/transient_window_manager_unittest.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_widget_aura.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/widget/native_widget_aura_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M ui/views/widget/widget.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M ui/views/widget/widget.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/widget/widget_unittest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
sky
6 years, 11 months ago (2014-01-06 22:39:45 UTC) #1
Ben Goodger (Google)
lgtm
6 years, 11 months ago (2014-01-07 00:51:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/121773003/60001
6 years, 11 months ago (2014-01-08 15:01:16 UTC) #3
commit-bot: I haz the power
Failed to apply patch for ui/aura/window_tree_host.cc: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 11 months ago (2014-01-08 18:22:06 UTC) #4
sky
6 years, 11 months ago (2014-01-08 21:42:00 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r243656 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698