Issue 1217633003: (WONT COMMIT) Pass a bool object allocated on heap to CallbackPromiseAdapter::onSuccess (1)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1217633003: (WONT COMMIT) Pass a bool object allocated on heap to CallbackPromiseAdapter::onSuccess (1) (Closed)

Created:
5 years, 5 months ago by nhiroki

Modified:
5 years, 5 months ago

Reviewers:
kinuko, Peter Beverloo

CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, johnme+watch_chromium.org, serviceworker-reviews, jam, mvanouwerkerk+watch_chromium.org, darin-cc_chromium.org, horo+watch_chromium.org, kinuko+serviceworker, peter+watch_chromium.org, kinuko+watch

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Pass a bool object allocated on heap to CallbackPromiseAdapter::onSuccess (1) CallbackPromiseAdapter is designed to take ownership of a passed object. See comments in CallbackPromiseAdapter.h for details. (1) Chromium: THIS PATCH (2) Blink: https://codereview.chromium.org/1211353004/ (3) Chromium: https://codereview.chromium.org/1225543002/ (4) Blink: https://codereview.chromium.org/1221693004/ BUG=493531

Patch Set 1 #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -0 lines)			Patch
	M	content/child/push_messaging/push_provider.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
	M	content/child/service_worker/service_worker_dispatcher.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Dependent Patchsets:

Issue 1225543002 Patch 1

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Peter Beverloo

push_messaging lgtm Thanks for doing this clean-up!! :)

5 years, 5 months ago (2015-07-03 11:15:09 UTC) #4

nhiroki

5 years, 5 months ago (2015-07-10 04:19:58 UTC) #5

Thank you for reviewing! And sorry, I'll close this CL because another promising
approach was proposed (see [1]).

[1] https://codereview.chromium.org/1211353004/#msg14

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages