Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Unified Diff: content/child/service_worker/service_worker_dispatcher.cc

Issue 1217633003: (WONT COMMIT) Pass a bool object allocated on heap to CallbackPromiseAdapter::onSuccess (1) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/child/push_messaging/push_provider.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/child/service_worker/service_worker_dispatcher.cc
diff --git a/content/child/service_worker/service_worker_dispatcher.cc b/content/child/service_worker/service_worker_dispatcher.cc
index ce20a7aac5a7d2400f256b89b62e395281ae773a..616eb16a43b655d18600e1151221ed454d8fc778 100644
--- a/content/child/service_worker/service_worker_dispatcher.cc
+++ b/content/child/service_worker/service_worker_dispatcher.cc
@@ -395,7 +395,11 @@ void ServiceWorkerDispatcher::OnUnregistered(int thread_id,
DCHECK(callbacks);
if (!callbacks)
return;
+#ifdef CRBUG_493531
+ callbacks->onSuccess(new bool(is_success));
+#else
callbacks->onSuccess(&is_success);
+#endif
pending_unregistration_callbacks_.Remove(request_id);
}
« no previous file with comments | « content/child/push_messaging/push_provider.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698