Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: content/child/push_messaging/push_provider.cc

Issue 1217633003: (WONT COMMIT) Pass a bool object allocated on heap to CallbackPromiseAdapter::onSuccess (1) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/child/service_worker/service_worker_dispatcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/child/push_messaging/push_provider.cc
diff --git a/content/child/push_messaging/push_provider.cc b/content/child/push_messaging/push_provider.cc
index 927da07baa35fd30984f680cc51c482e0198c973..0d737cf797e01191215c95c8bbbd9296c4df7acd 100644
--- a/content/child/push_messaging/push_provider.cc
+++ b/content/child/push_messaging/push_provider.cc
@@ -182,7 +182,11 @@ void PushProvider::OnUnsubscribeSuccess(int request_id, bool did_unsubscribe) {
if (!callbacks)
return;
+#ifdef CRBUG_493531
+ callbacks->onSuccess(new bool(did_unsubscribe));
+#else
callbacks->onSuccess(&did_unsubscribe);
+#endif
unsubscribe_callbacks_.Remove(request_id);
}
« no previous file with comments | « no previous file | content/child/service_worker/service_worker_dispatcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698