Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 1217593005: Fix gn check errors for webcrypto component (Closed)

Created:
5 years, 5 months ago by agrieve
Modified:
5 years, 5 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@gn3
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix gn check errors for webcrypto component Once blink headers are added as sources (https://codereview.chromium.org/1222673004/), if you run the following command line, you will get errors like this: $ gn check ERROR at //components/webcrypto/webcrypto_util.h:12:11: Include not allowed. ^------------------------------------------------------ It is not in any dependency of //components/webcrypto:webcrypto The include file is in the target(s): //third_party/WebKit/public:blink_headers which should somehow be reachable. BUG=367595 Committed: https://crrev.com/aade26edc0daa8b63d012bd6fc2fa7e2483f35aa Cr-Commit-Position: refs/heads/master@{#337726}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M components/webcrypto/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 7 (2 generated)
agrieve
5 years, 5 months ago (2015-07-04 02:33:37 UTC) #2
brettw
lgtm
5 years, 5 months ago (2015-07-07 21:53:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1217593005/1
5 years, 5 months ago (2015-07-07 23:40:40 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-08 01:57:43 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-08 01:58:40 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aade26edc0daa8b63d012bd6fc2fa7e2483f35aa
Cr-Commit-Position: refs/heads/master@{#337726}

Powered by Google App Engine
This is Rietveld 408576698