DescriptionFix gn check errors for cc/blink
Once blink headers are added as sources (https://codereview.chromium.org/1222673004/), if you run the following
command line, you will get errors like this:
$ gn check
ERROR at //cc/blink/web_layer_impl_fixed_bounds_unittest.cc:13:11: Can't include this header from here.
^-------------------------------------------------
The target:
//cc/blink:_cc_blink_unittests__library
is including a file from the target:
//third_party/WebKit/public:blink_headers
It's usually best to depend directly on the destination target.
In some cases, the destination target is considered a subcomponent
of an intermediate target. In this case, the intermediate target
should depend publicly on the destination to forward the ability
to include headers.
Dependency chain (there may also be others):
//cc/blink:_cc_blink_unittests__library -->
//cc/blink:blink --[private]-->
//third_party/WebKit/public:blink -->
//third_party/WebKit/public:blink_headers
BUG=367595
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Committed: https://crrev.com/b11fbc239c0aa61b0110cd52939ea66ba545586a
Cr-Commit-Position: refs/heads/master@{#337744}
Patch Set 1 #
Depends on Patchset: Dependent Patchsets: Messages
Total messages: 7 (2 generated)
|