Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issue 1216083003: Fix gn check errors for cc/blink (Closed)

Created:
5 years, 5 months ago by agrieve
Modified:
5 years, 5 months ago
Reviewers:
brettw
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@gn2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix gn check errors for cc/blink Once blink headers are added as sources (https://codereview.chromium.org/1222673004/), if you run the following command line, you will get errors like this: $ gn check ERROR at //cc/blink/web_layer_impl_fixed_bounds_unittest.cc:13:11: Can't include this header from here. ^------------------------------------------------- The target: //cc/blink:_cc_blink_unittests__library is including a file from the target: //third_party/WebKit/public:blink_headers It's usually best to depend directly on the destination target. In some cases, the destination target is considered a subcomponent of an intermediate target. In this case, the intermediate target should depend publicly on the destination to forward the ability to include headers. Dependency chain (there may also be others): //cc/blink:_cc_blink_unittests__library --> //cc/blink:blink --[private]--> //third_party/WebKit/public:blink --> //third_party/WebKit/public:blink_headers BUG=367595 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/b11fbc239c0aa61b0110cd52939ea66ba545586a Cr-Commit-Position: refs/heads/master@{#337744}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M cc/blink/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 7 (2 generated)
agrieve
5 years, 5 months ago (2015-07-04 02:30:27 UTC) #2
brettw
lgtm
5 years, 5 months ago (2015-07-07 21:53:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1216083003/1
5 years, 5 months ago (2015-07-07 23:40:24 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-08 02:26:11 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-08 02:27:00 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b11fbc239c0aa61b0110cd52939ea66ba545586a
Cr-Commit-Position: refs/heads/master@{#337744}

Powered by Google App Engine
This is Rietveld 408576698