Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 1222733002: Fix gn check errors for storage/common:common (Closed)

Created:
5 years, 5 months ago by agrieve
Modified:
5 years, 5 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@gn4
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix gn check errors for storage/common:common Once blink headers are added as sources (https://codereview.chromium.org/1222673004/), if you run the following command line, you will get errors like this: $ gn check ERROR at //storage/common/fileapi/file_system_util.h:17:11: Include not allowed. ^------------------------------------------------ It is not in any dependency of //storage/common:common The include file is in the target(s): //third_party/WebKit/public:blink_headers which should somehow be reachable. BUG=367595 Committed: https://crrev.com/deb02768bf9805279461259119a845aa2c734e25 Cr-Commit-Position: refs/heads/master@{#337904}

Patch Set 1 #

Patch Set 2 : depend on blink_headers rather than blink #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M storage/common/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (2 generated)
agrieve
5 years, 5 months ago (2015-07-04 02:34:53 UTC) #2
brettw
I don't think anything labeled "common" (shared between browser and renderer process) should depend on ...
5 years, 5 months ago (2015-07-07 21:57:21 UTC) #3
agrieve
On 2015/07/07 21:57:21, brettw wrote: > I don't think anything labeled "common" (shared between browser ...
5 years, 5 months ago (2015-07-08 18:23:53 UTC) #4
brettw
lgtm
5 years, 5 months ago (2015-07-08 20:08:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1222733002/20001
5 years, 5 months ago (2015-07-08 20:10:43 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-08 20:51:12 UTC) #8
commit-bot: I haz the power
5 years, 5 months ago (2015-07-08 20:52:05 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/deb02768bf9805279461259119a845aa2c734e25
Cr-Commit-Position: refs/heads/master@{#337904}

Powered by Google App Engine
This is Rietveld 408576698